linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: add a warning label for RAID5/6
Date: Wed, 3 Mar 2021 15:41:17 +0100	[thread overview]
Message-ID: <20210303144117.GK7604@twin.jikos.cz> (raw)
In-Reply-To: <bf9594ea55ce40af80548888070427ad97daf78a.1598374255.git.josef@toxicpanda.com>

On Tue, Aug 25, 2020 at 12:51:02PM -0400, Josef Bacik wrote:
> We all know there's some dark and scary corners with RAID5/6, but users
> may not know.  Add a warning message in mkfs so anybody trying to use
> this will know things can go very wrong.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  mkfs/main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mkfs/main.c b/mkfs/main.c
> index 0a4de617..0db24ad4 100644
> --- a/mkfs/main.c
> +++ b/mkfs/main.c
> @@ -1183,6 +1183,8 @@ int BOX_MAIN(mkfs)(int argc, char **argv)
>  	if ((data_profile | metadata_profile) &
>  	    (BTRFS_BLOCK_GROUP_RAID5 | BTRFS_BLOCK_GROUP_RAID6)) {
>  		features |= BTRFS_FEATURE_INCOMPAT_RAID56;
> +		warning("RAID5/6 support is still experimental and has known "
> +			"issues, do not rely on this for data you care about.\n");

I've reworded the message, calling it experimental after so many years
is a bit kappa. Also we'll need something in the docs for reference,
I'll write something.

>  	}
>  
>  	if ((data_profile | metadata_profile) &
> -- 
> 2.24.1

      parent reply	other threads:[~2021-03-04  0:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:51 [PATCH] btrfs-progs: add a warning label for RAID5/6 Josef Bacik
2020-08-31 11:13 ` Johannes Thumshirn
2020-09-02  3:41 ` Neal Gompa
2021-03-03 14:41 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303144117.GK7604@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).