[PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Su Yue]

Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
list api") did conversion from fs_devices::seed to fs_devices::seed_list.

Signed-off-by: Su Yue <l@damenly.su>
---
 fs/btrfs/volumes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 70f94b75f25a..fcc2fede9ffc 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2203,7 +2203,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info, const char *device_path,
 	/*
 	 * In normal cases the cur_devices == fs_devices. But in case
 	 * of deleting a seed device, the cur_devices should point to
-	 * its own fs_devices listed under the fs_devices->seed.
+	 * its own fs_devices listed under the fs_devices->seed_list.
 	 */
 	cur_devices = device->fs_devices;
 	mutex_lock(&fs_devices->device_list_mutex);
-- 
2.30.1

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Anand Jain]

On 18/08/2021 12:15, Su Yue wrote:
> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
> list api") did conversion from fs_devices::seed to fs_devices::seed_list.
> 
> Signed-off-by: Su Yue <l@damenly.su>

Reviewed-by: Anand Jain <anand.jain@oracle.com>


> ---
>   fs/btrfs/volumes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 70f94b75f25a..fcc2fede9ffc 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2203,7 +2203,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info, const char *device_path,
>   	/*
>   	 * In normal cases the cur_devices == fs_devices. But in case
>   	 * of deleting a seed device, the cur_devices should point to
> -	 * its own fs_devices listed under the fs_devices->seed.
> +	 * its own fs_devices listed under the fs_devices->seed_list.
>   	 */
>   	cur_devices = device->fs_devices;
>   	mutex_lock(&fs_devices->device_list_mutex);
> 

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Anand Jain]

On 18/08/2021 12:25, Anand Jain wrote:
> On 18/08/2021 12:15, Su Yue wrote:
>> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
>> list api") did conversion from fs_devices::seed to fs_devices::seed_list.
>>
>> Signed-off-by: Su Yue <l@damenly.su>
> 


> Reviewed-by: Anand Jain <anand.jain@oracle.com>

  Ah. No. I have remove my RB...
> 
>> ---
>>   fs/btrfs/volumes.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index 70f94b75f25a..fcc2fede9ffc 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -2203,7 +2203,7 @@ int btrfs_rm_device(struct btrfs_fs_info 
>> *fs_info, const char *device_path,
>>       /*
>>        * In normal cases the cur_devices == fs_devices. But in case
>>        * of deleting a seed device, the cur_devices should point to
>> -     * its own fs_devices listed under the fs_devices->seed.
>> +     * its own fs_devices listed under the fs_devices->seed_list.


fs_devices->seed is correct.

222 struct btrfs_fs_devices {
::
257         struct btrfs_fs_devices *seed;

Thanks, Anand


>>        */
>>       cur_devices = device->fs_devices;
>>       mutex_lock(&fs_devices->device_list_mutex);
>>
> 

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Nikolay Borisov]

On 18.08.21 г. 9:13, Anand Jain wrote:
> 
> 
> On 18/08/2021 12:25, Anand Jain wrote:
>> On 18/08/2021 12:15, Su Yue wrote:
>>> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
>>> list api") did conversion from fs_devices::seed to
>>> fs_devices::seed_list.
>>>
>>> Signed-off-by: Su Yue <l@damenly.su>
>>
> 
> 
>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
> 
>  Ah. No. I have remove my RB...
>>
>>> ---
>>>   fs/btrfs/volumes.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>>> index 70f94b75f25a..fcc2fede9ffc 100644
>>> --- a/fs/btrfs/volumes.c
>>> +++ b/fs/btrfs/volumes.c
>>> @@ -2203,7 +2203,7 @@ int btrfs_rm_device(struct btrfs_fs_info
>>> *fs_info, const char *device_path,
>>>       /*
>>>        * In normal cases the cur_devices == fs_devices. But in case
>>>        * of deleting a seed device, the cur_devices should point to
>>> -     * its own fs_devices listed under the fs_devices->seed.
>>> +     * its own fs_devices listed under the fs_devices->seed_list.
> 
> 
> fs_devices->seed is correct.
> 
> 222 struct btrfs_fs_devices {
> ::
> 257         struct btrfs_fs_devices *seed;

You are clearly looking at the wrong tree since seed got removed exactly
in the cited patch above.
> 
> Thanks, Anand
> 
> 
>>>        */
>>>       cur_devices = device->fs_devices;
>>>       mutex_lock(&fs_devices->device_list_mutex);
>>>
>>
> 

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Anand Jain]

On 18/08/2021 14:13, Anand Jain wrote:
> 
> 
> On 18/08/2021 12:25, Anand Jain wrote:
>> On 18/08/2021 12:15, Su Yue wrote:
>>> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
>>> list api") did conversion from fs_devices::seed to 
>>> fs_devices::seed_list.
>>>
>>> Signed-off-by: Su Yue <l@damenly.su>
>>
> 
> 
>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
> 
>   Ah. No. I have remove my RB...

My rb is ok. I was looking at a 5.4 stable branch by mistake.
I didn't realize. It is embarrassing. Sorry for the noise.

Thanks, Anand

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[Anand Jain]

On 18/08/2021 14:20, Nikolay Borisov wrote:
> 
> 
> On 18.08.21 г. 9:13, Anand Jain wrote:
>>
>>
>> On 18/08/2021 12:25, Anand Jain wrote:
>>> On 18/08/2021 12:15, Su Yue wrote:
>>>> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
>>>> list api") did conversion from fs_devices::seed to
>>>> fs_devices::seed_list.
>>>>
>>>> Signed-off-by: Su Yue <l@damenly.su>
>>>
>>
>>
>>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
>>
>>   Ah. No. I have remove my RB...
>>>
>>>> ---
>>>>    fs/btrfs/volumes.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>>>> index 70f94b75f25a..fcc2fede9ffc 100644
>>>> --- a/fs/btrfs/volumes.c
>>>> +++ b/fs/btrfs/volumes.c
>>>> @@ -2203,7 +2203,7 @@ int btrfs_rm_device(struct btrfs_fs_info
>>>> *fs_info, const char *device_path,
>>>>        /*
>>>>         * In normal cases the cur_devices == fs_devices. But in case
>>>>         * of deleting a seed device, the cur_devices should point to
>>>> -     * its own fs_devices listed under the fs_devices->seed.
>>>> +     * its own fs_devices listed under the fs_devices->seed_list.
>>
>>
>> fs_devices->seed is correct.
>>
>> 222 struct btrfs_fs_devices {
>> ::
>> 257         struct btrfs_fs_devices *seed;
> 
> You are clearly looking at the wrong tree since seed got removed exactly
> in the cited patch above.

  Yep, I notice a little late.


>>
>> Thanks, Anand
>>
>>
>>>>         */
>>>>        cur_devices = device->fs_devices;
>>>>        mutex_lock(&fs_devices->device_list_mutex);
>>>>
>>>
>>

Re: [PATCH] btrfs: update comment for fs_devices::seed_list in btrfs_rm_device

[David Sterba]

On Wed, Aug 18, 2021 at 12:15:48PM +0800, Su Yue wrote:
> Update it since commit 944d3f9fac61 ("btrfs: switch seed device to
> list api") did conversion from fs_devices::seed to fs_devices::seed_list.
> 
> Signed-off-by: Su Yue <l@damenly.su>

Added to misc-next, thanks.