[PATCH 00/11] sandbox: Minor fixes and improvements

[PATCH 00/11] sandbox: Minor fixes and improvements

[Simon Glass]

This series collects a few patches that correct and improve sandbox and
sandbox_spl:

- Fix a bug in --rm-memory works
- Support an MMC backing file for MMC emulator, to allow filesystems to be
  used without needing the 'host' filesystem
- Allow skipping console output when checking verbose commands
- Suppress unwanted filesystem warnings when probing partitions
- Tidy up a few comments


Simon Glass (11):
  dtoc: Further improve documentation about warnings
  sandbox: Correct handling of --rm_memory
  sandbox: Add license headers to the dts files
  btrfs: Suppress the message about missing filesystem
  sqfs: Suppress the message about missing filesystem
  test: Tidy a comment in the bloblist test
  dm: core: Fix a few incorrect comments on first/next functions
  sandbox: Add a way to find the size of a file
  sandbox: Add a way to map a file into memory
  sandbox: mmc: Support a backing file
  test: Add a way to skip console checking until a string matches

 arch/sandbox/cpu/os.c                        | 52 +++++++++--
 arch/sandbox/dts/overlay0.dts                |  5 ++
 arch/sandbox/dts/overlay1.dts                |  5 ++
 arch/sandbox/dts/sandbox.dts                 |  5 ++
 arch/sandbox/dts/sandbox.dtsi                |  1 +
 arch/sandbox/dts/sandbox64.dts               |  4 +
 arch/sandbox/dts/test.dts                    |  9 ++
 doc/develop/driver-model/of-plat.rst         | 92 +++++++++++++++++++-
 doc/device-tree-bindings/mmc/sandbox,mmc.txt | 18 ++++
 drivers/mmc/sandbox_mmc.c                    | 46 ++++++++--
 fs/btrfs/disk-io.c                           |  8 +-
 fs/squashfs/sqfs.c                           |  2 +-
 include/dm/device.h                          |  4 +-
 include/dm/uclass.h                          |  2 +-
 include/os.h                                 | 21 +++++
 include/test/ut.h                            | 24 +++++
 test/bloblist.c                              |  2 +-
 test/ut.c                                    | 26 ++++++
 18 files changed, 299 insertions(+), 27 deletions(-)
 create mode 100644 doc/device-tree-bindings/mmc/sandbox,mmc.txt

-- 
2.33.0.rc1.237.g0d66db33f3-goog

[PATCH 04/11] btrfs: Suppress the message about missing filesystem

[Simon Glass]

This message comes up a lot when scanning filesystems. It suggests to the
user that there is some sort of error, but in fact there is no reason to
expect that a particular partition has a btrfs filesystem. Other
filesystems don't print this error.

Turn it into a debug message.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 fs/btrfs/disk-io.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 349411c3ccd..1b69346e231 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -886,7 +886,11 @@ static int btrfs_scan_fs_devices(struct blk_desc *desc,
 
 	ret = btrfs_scan_one_device(desc, part, fs_devices, &total_devs);
 	if (ret) {
-		fprintf(stderr, "No valid Btrfs found\n");
+		/*
+		 * Avoid showing this when probing for a possible Btrfs
+		 *
+		 * fprintf(stderr, "No valid Btrfs found\n");
+		 */
 		return ret;
 	}
 	return 0;
@@ -975,7 +979,7 @@ struct btrfs_fs_info *open_ctree_fs_info(struct blk_desc *desc,
 	disk_super = fs_info->super_copy;
 	ret = btrfs_read_dev_super(desc, part, disk_super);
 	if (ret) {
-		printk("No valid btrfs found\n");
+		debug("No valid btrfs found\n");
 		goto out_devices;
 	}
 
-- 
2.33.0.rc1.237.g0d66db33f3-goog

Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem

[Marek Behún]

On Wed, 18 Aug 2021 21:40:26 -0600
Simon Glass <sjg@chromium.org> wrote:

> This message comes up a lot when scanning filesystems. It suggests to the
> user that there is some sort of error, but in fact there is no reason to
> expect that a particular partition has a btrfs filesystem. Other
> filesystems don't print this error.
> 
> Turn it into a debug message.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Marek Behún <marek.behun@nic.cz>

This must have been introduced after btrfs was reimplemented from the
btrfs-progs sources. I remember that I sent a patch fixing this same
issue for the previous implementation (or was it another filesystem?).

Marek

Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem

[Qu Wenruo]

On 2021/8/19 上午11:40, Simon Glass wrote:
> This message comes up a lot when scanning filesystems. It suggests to the
> user that there is some sort of error, but in fact there is no reason to
> expect that a particular partition has a btrfs filesystem. Other
> filesystems don't print this error.
>
> Turn it into a debug message.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>
>   fs/btrfs/disk-io.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 349411c3ccd..1b69346e231 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -886,7 +886,11 @@ static int btrfs_scan_fs_devices(struct blk_desc *desc,
>
>   	ret = btrfs_scan_one_device(desc, part, fs_devices, &total_devs);
>   	if (ret) {
> -		fprintf(stderr, "No valid Btrfs found\n");
> +		/*
> +		 * Avoid showing this when probing for a possible Btrfs
> +		 *
> +		 * fprintf(stderr, "No valid Btrfs found\n");
> +		 */
>   		return ret;
>   	}
>   	return 0;
> @@ -975,7 +979,7 @@ struct btrfs_fs_info *open_ctree_fs_info(struct blk_desc *desc,
>   	disk_super = fs_info->super_copy;
>   	ret = btrfs_read_dev_super(desc, part, disk_super);
>   	if (ret) {
> -		printk("No valid btrfs found\n");
> +		debug("No valid btrfs found\n");
>   		goto out_devices;
>   	}
>
>

Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

On Wed, Aug 18, 2021 at 09:40:26PM -0600, Simon Glass wrote:

> This message comes up a lot when scanning filesystems. It suggests to the
> user that there is some sort of error, but in fact there is no reason to
> expect that a particular partition has a btrfs filesystem. Other
> filesystems don't print this error.
> 
> Turn it into a debug message.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>
> Reviewed-by: Qu Wenruo <wqu@suse.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]