From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 07/13] btrfs: zoned: finish least available block group on data BG allocation
Date: Mon, 4 Jul 2022 13:25:39 +0000 [thread overview]
Message-ID: <20220704132537.7egophhnu7yamlsf@naota-xeon> (raw)
In-Reply-To: <PH0PR04MB74167D03DCDC030A680101A79BBE9@PH0PR04MB7416.namprd04.prod.outlook.com>
On Mon, Jul 04, 2022 at 07:25:14AM +0000, Johannes Thumshirn wrote:
> On 04.07.22 06:59, Naohiro Aota wrote:
> > +
> > + ret = btrfs_zone_finish(min_bg);
> > + btrfs_put_block_group(min_bg);
> > +
> > + return ret == 0;
>
> Why aren't you propagating the error from btrfs_zone_finish()
> back to the caller?
Ah, yeah. We should propagate it. I'll fix in the next version.
Thanks.
next prev parent reply other threads:[~2022-07-04 13:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 4:58 [PATCH 00/13] btrfs: zoned: fix active zone tracking issues Naohiro Aota
2022-07-04 4:58 ` [PATCH 01/13] block: add bdev_max_segments() helper Naohiro Aota
2022-07-04 6:57 ` Johannes Thumshirn
2022-07-04 8:23 ` Christoph Hellwig
2022-07-04 13:27 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 02/13] btrfs: zoned: revive max_zone_append_bytes Naohiro Aota
2022-07-04 7:57 ` Johannes Thumshirn
2022-07-04 8:24 ` Christoph Hellwig
2022-07-04 9:33 ` Johannes Thumshirn
2022-07-04 11:54 ` Christoph Hellwig
2022-07-04 13:24 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 03/13] btrfs: replace BTRFS_MAX_EXTENT_SIZE with fs_info->max_extent_size Naohiro Aota
2022-07-04 7:02 ` Johannes Thumshirn
2022-07-04 7:46 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 04/13] btrfs: convert count_max_extents() to use fs_info->max_extent_size Naohiro Aota
2022-07-04 7:56 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 05/13] btrfs: use fs_info->max_extent_size in get_extent_max_capacity() Naohiro Aota
2022-07-04 7:12 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 06/13] btrfs: let can_allocate_chunk return int Naohiro Aota
2022-07-04 7:11 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 07/13] btrfs: zoned: finish least available block group on data BG allocation Naohiro Aota
2022-07-04 7:25 ` Johannes Thumshirn
2022-07-04 13:25 ` Naohiro Aota [this message]
2022-07-04 4:58 ` [PATCH 08/13] btrfs: zoned: introduce space_info->active_total_bytes Naohiro Aota
2022-07-04 4:58 ` [PATCH 09/13] btrfs: zoned: disable metadata overcommit for zoned Naohiro Aota
2022-07-04 7:52 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 10/13] btrfs: zoned: activate metadata BG on flush_space Naohiro Aota
2022-07-07 14:51 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 11/13] btrfs: zoned: activate necessary block group Naohiro Aota
2022-07-04 4:58 ` [PATCH 12/13] btrfs: zoned: write out partially allocated region Naohiro Aota
2022-07-04 4:58 ` [PATCH 13/13] btrfs: zoned: wait until zone is finished when allocation didn't progress Naohiro Aota
2022-07-08 18:01 ` [PATCH 00/13] btrfs: zoned: fix active zone tracking issues David Sterba
2022-07-08 23:06 ` Naohiro Aota
2022-07-08 23:18 Naohiro Aota
2022-07-08 23:18 ` [PATCH 07/13] btrfs: zoned: finish least available block group on data BG allocation Naohiro Aota
2022-07-11 6:45 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704132537.7egophhnu7yamlsf@naota-xeon \
--to=naohiro.aota@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).