From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 00/13] btrfs: zoned: fix active zone tracking issues
Date: Fri, 8 Jul 2022 20:01:01 +0200 [thread overview]
Message-ID: <20220708180101.GX15169@twin.jikos.cz> (raw)
In-Reply-To: <cover.1656909695.git.naohiro.aota@wdc.com>
On Mon, Jul 04, 2022 at 01:58:04PM +0900, Naohiro Aota wrote:
> This series addresses mainly two issues on zoned btrfs' active zone
> tracking and one issue which is a dependency of the main issue.
>
> * Background
[...]
Thanks for the writeup, this seems to be fixing a serious problem, also
guessing by the length of the series. Some of the patches are marked for
stable 5.12 or 5.16 but I think this would need to be backported
manually and to 5.18 as the other versions have been EOLed.
As most of the changes are in zoned code I can add the whole series to
misc-next rather sooner than later because the code freeze is near.
I did a quick test and it crashes in the self tests so I can't add the
branch to for-next.
[ 13.324894] Btrfs loaded, crc32c=crc32c-generic, debug=on, assert=on, integrity-checker=on, ref-verify=on, zoned=yes, fsverity=yes
[ 13.326507] BTRFS: selftest: sectorsize: 4096 nodesize: 4096
[ 13.327303] BTRFS: selftest: running btrfs free space cache tests
[ 13.328133] BTRFS: selftest: running extent only tests
[ 13.328935] BTRFS: selftest: running bitmap only tests
[ 13.329770] BTRFS: selftest: running bitmap and extent tests
[ 13.330647] BTRFS: selftest: running space stealing from bitmap to extent tests
[ 13.331990] BTRFS: selftest: running bytes index tests
[ 13.332915] BTRFS: selftest: running extent buffer operation tests
[ 13.333924] BTRFS: selftest: running btrfs_split_item tests
[ 13.334922] BTRFS: selftest: running extent I/O tests
[ 13.335733] BTRFS: selftest: running find delalloc tests
[ 13.525595] BUG: unable to handle page fault for address: 0000000000002360
[ 13.526677] #PF: supervisor read access in kernel mode
[ 13.527480] #PF: error_code(0x0000) - not-present page
[ 13.528381] PGD 0 P4D 0
[ 13.528909] Oops: 0000 [#1] PREEMPT SMP
[ 13.529604] CPU: 0 PID: 642 Comm: modprobe Not tainted 5.19.0-rc5-default+ #1809
[ 13.530742] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
[ 13.532475] RIP: 0010:find_lock_delalloc_range+0x41/0x2a0 [btrfs]
[ 13.535137] RSP: 0018:ffffb750c05ebcd8 EFLAGS: 00010296
[ 13.535467] RAX: 0000000000000000 RBX: ffff96b1fe0f3440 RCX: 0000000000000fff
[ 13.535880] RDX: ffffb750c05ebd60 RSI: ffff96b1fe0f3440 RDI: ffff96b1838b8f00
[ 13.536534] RBP: ffff96b1838b8f00 R08: 0000000000000000 R09: 0000000000000001
[ 13.537141] R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000001000
[ 13.537548] R13: ffff96b1838b8ab8 R14: 0000000000000fff R15: ffffb750c05ebd58
[ 13.537956] FS: 00007eff49b43740(0000) GS:ffff96b1fd600000(0000) knlGS:0000000000000000
[ 13.538467] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 13.538808] CR2: 0000000000002360 CR3: 0000000003f1c000 CR4: 00000000000006b0
[ 13.539213] Call Trace:
[ 13.539407] <TASK>
[ 13.539584] test_find_delalloc+0x19b/0x695 [btrfs]
[ 13.539978] btrfs_test_extent_io+0x1e/0x39 [btrfs]
[ 13.540710] btrfs_run_sanity_tests.cold+0x33/0xcd [btrfs]
[ 13.541686] init_btrfs_fs+0xcc/0x12b [btrfs]
[ 13.542328] ? 0xffffffffc060a000
[ 13.542868] do_one_initcall+0x65/0x330
[ 13.543348] ? rcu_read_lock_sched_held+0x3b/0x70
[ 13.543980] ? trace_kmalloc+0x33/0xe0
[ 13.544394] ? kmem_cache_alloc_trace+0x188/0x270
[ 13.544805] do_init_module+0x4a/0x1f0
[ 13.545076] __do_sys_finit_module+0x9e/0xf0
[ 13.545373] do_syscall_64+0x3c/0x80
[ 13.545618] entry_SYSCALL_64_after_hwframe+0x46/0xb0
[ 13.545961] RIP: 0033:0x7eff49c6da8d
[ 13.547264] RSP: 002b:00007ffcb6e6bbc8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[ 13.547724] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007eff49c6da8d
[ 13.548184] RDX: 0000000000000000 RSI: 000055a8143faab2 RDI: 000000000000000d
[ 13.549012] RBP: 000055a81441d460 R08: 0000000000000000 R09: 0000000000000000
[ 13.549550] R10: 000000000000000d R11: 0000000000000246 R12: 000055a8143faab2
[ 13.549958] R13: 000055a814423530 R14: 0000000000000000 R15: 000055a814424ab8
[ 13.550363] </TASK>
[ 13.550541] Modules linked in: btrfs(+) blake2b_generic libcrc32c xor lzo_compress lzo_decompress raid6_pq zstd_decompress zstd_compress xxhash loop
[ 13.551275] CR2: 0000000000002360
[ 13.551525] ---[ end trace 0000000000000000 ]---
[ 13.551819] RIP: 0010:find_lock_delalloc_range+0x41/0x2a0 [btrfs]
[ 13.555923] RSP: 0018:ffffb750c05ebcd8 EFLAGS: 00010296
[ 13.557052] RAX: 0000000000000000 RBX: ffff96b1fe0f3440 RCX: 0000000000000fff
[ 13.558614] RDX: ffffb750c05ebd60 RSI: ffff96b1fe0f3440 RDI: ffff96b1838b8f00
[ 13.559857] RBP: ffff96b1838b8f00 R08: 0000000000000000 R09: 0000000000000001
[ 13.561280] R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000001000
[ 13.562619] R13: ffff96b1838b8ab8 R14: 0000000000000fff R15: ffffb750c05ebd58
[ 13.563522] FS: 00007eff49b43740(0000) GS:ffff96b1fd600000(0000) knlGS:0000000000000000
[ 13.564612] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 13.565356] CR2: 0000000000002360 CR3: 0000000003f1c000 CR4: 00000000000006b0
next prev parent reply other threads:[~2022-07-08 18:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 4:58 [PATCH 00/13] btrfs: zoned: fix active zone tracking issues Naohiro Aota
2022-07-04 4:58 ` [PATCH 01/13] block: add bdev_max_segments() helper Naohiro Aota
2022-07-04 6:57 ` Johannes Thumshirn
2022-07-04 8:23 ` Christoph Hellwig
2022-07-04 13:27 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 02/13] btrfs: zoned: revive max_zone_append_bytes Naohiro Aota
2022-07-04 7:57 ` Johannes Thumshirn
2022-07-04 8:24 ` Christoph Hellwig
2022-07-04 9:33 ` Johannes Thumshirn
2022-07-04 11:54 ` Christoph Hellwig
2022-07-04 13:24 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 03/13] btrfs: replace BTRFS_MAX_EXTENT_SIZE with fs_info->max_extent_size Naohiro Aota
2022-07-04 7:02 ` Johannes Thumshirn
2022-07-04 7:46 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 04/13] btrfs: convert count_max_extents() to use fs_info->max_extent_size Naohiro Aota
2022-07-04 7:56 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 05/13] btrfs: use fs_info->max_extent_size in get_extent_max_capacity() Naohiro Aota
2022-07-04 7:12 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 06/13] btrfs: let can_allocate_chunk return int Naohiro Aota
2022-07-04 7:11 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 07/13] btrfs: zoned: finish least available block group on data BG allocation Naohiro Aota
2022-07-04 7:25 ` Johannes Thumshirn
2022-07-04 13:25 ` Naohiro Aota
2022-07-04 4:58 ` [PATCH 08/13] btrfs: zoned: introduce space_info->active_total_bytes Naohiro Aota
2022-07-04 4:58 ` [PATCH 09/13] btrfs: zoned: disable metadata overcommit for zoned Naohiro Aota
2022-07-04 7:52 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 10/13] btrfs: zoned: activate metadata BG on flush_space Naohiro Aota
2022-07-07 14:51 ` Johannes Thumshirn
2022-07-04 4:58 ` [PATCH 11/13] btrfs: zoned: activate necessary block group Naohiro Aota
2022-07-04 4:58 ` [PATCH 12/13] btrfs: zoned: write out partially allocated region Naohiro Aota
2022-07-04 4:58 ` [PATCH 13/13] btrfs: zoned: wait until zone is finished when allocation didn't progress Naohiro Aota
2022-07-08 18:01 ` David Sterba [this message]
2022-07-08 23:06 ` [PATCH 00/13] btrfs: zoned: fix active zone tracking issues Naohiro Aota
2022-07-08 23:18 Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708180101.GX15169@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).