linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] fix verify_one_dev_extent and btrfs_find_device
Date: Fri, 30 Oct 2020 05:14:06 +0800	[thread overview]
Message-ID: <468a5f49-187a-71ad-b922-eaf091107d65@oracle.com> (raw)
In-Reply-To: <20201029210242.GX6756@twin.jikos.cz>



On 30/10/20 5:02 am, David Sterba wrote:
> On Wed, Oct 21, 2020 at 12:16:07PM +0800, Anand Jain wrote:
>> btrfs_find_device()'s last arg %seed is unused, which the commit
>> 343694eee8d8 (btrfs: switch seed device to list api) ignored purposely
>> or missed.
>>
>> But there isn't any regression due to that. And this series makes
>> it official that btrfs_find_device() doesn't need the last arg.
>>
>> To achieve that patch 1/2 critically reviews the need for the check
>> disk_total_bytes == 0 in the function verify_one_dev_extent() and finds
>> that, the condition is never met and so deletes the same. Which also
>> drops one of the parents of btrfs_find_device() with the last arg false.
>>
>> So only device_list_add() is using btrfs_find_device() with the last arg as
>> false, which the patch 2/2 finds is not required as well. So
>> this patch drops the last arg in btrfs_find_device() altogether.
>>
>> Anand Jain (2):
>>    btrfs: drop never met condition of disk_total_bytes == 0
>>    btrfs: fix btrfs_find_device unused arg seed
> 
> I missed this update because you replied to the original mail and this
> threads under the replies and is so easy to miss that it will inevitably
> lead to delayed reviews. This is not supposed to be hard, if you have
> another iteration, send it as a new mail thread where the 0/N mail has
> other patches as replies. 

ok. For now I am using this option, as..

> You can also use the workflow scripts to
> create or update the issue so we'll notice that. 

I found workflow script can't handle the update? Instead it creates a 
new issue?

> Right now there's stale
> https://github.com/btrfs/linux/issues/65 that is labeled with comments
> so nobody will probably lookd at it again until the next iteration
> arrives.

Should I resend the latest update?

Thanks Anand

  reply	other threads:[~2020-10-29 21:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 10:11 [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-09-24 10:11 ` [PATCH 1/2] btrfs: drop never met condition of disk_total_bytes == 0 Anand Jain
2020-09-24 11:48   ` Nikolay Borisov
2020-09-24 11:58     ` Qu Wenruo
2020-09-24 12:19       ` Qu Wenruo
2020-09-25  4:17     ` Anand Jain
2020-09-25  6:19       ` Nikolay Borisov
2020-09-25  7:33         ` Anand Jain
2020-09-25  7:56           ` Nikolay Borisov
2020-09-25  8:12             ` Anand Jain
2020-10-05 13:22   ` Josef Bacik
2020-10-06 12:53     ` Anand Jain
2020-10-06 12:54   ` [PATCH v2 " Anand Jain
2020-10-21  4:16     ` [PATCH RESEND " Anand Jain
2020-10-21 14:35     ` Josef Bacik
2020-10-22  9:40       ` Anand Jain
2020-10-29 21:30     ` Anand Jain
2020-09-24 10:11 ` [PATCH 2/2] btrfs: fix btrfs_find_device unused arg seed Anand Jain
2020-09-24 10:21   ` Nikolay Borisov
2020-09-25  8:22     ` Nikolay Borisov
2020-09-25  8:42       ` Anand Jain
2020-10-05 13:23   ` Josef Bacik
2020-10-21  4:16   ` [PATCH RESEND " Anand Jain
2020-10-29 21:30   ` [PATCH RESEND v2 " Anand Jain
2020-10-02  3:14 ` [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-10-21  4:16 ` [PATCH RESEND " Anand Jain
2020-10-29 21:02 ` David Sterba
2020-10-29 21:14   ` Anand Jain [this message]
2020-11-11 15:49     ` David Sterba
2020-10-29 21:30 ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468a5f49-187a-71ad-b922-eaf091107d65@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).