From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Nikolay Borisov <nborisov@suse.com>,
Anand Jain <anand.jain@oracle.com>,
linux-btrfs@vger.kernel.org
Cc: wqu@suse.com, dsterba@suse.com
Subject: Re: [PATCH 1/2] btrfs: drop never met condition of disk_total_bytes == 0
Date: Thu, 24 Sep 2020 20:19:02 +0800 [thread overview]
Message-ID: <ffc60c8f-3045-640b-bed9-07001287470a@gmx.com> (raw)
In-Reply-To: <b879f134-5bf9-a28a-885a-750d39f29a63@gmx.com>
On 2020/9/24 下午7:58, Qu Wenruo wrote:
>
>
> On 2020/9/24 下午7:48, Nikolay Borisov wrote:
>>
>>
>> On 24.09.20 г. 13:11 ч., Anand Jain wrote:
>>> btrfs_device::disk_total_bytes is set even for a seed device (the
>>> comment is wrong).
>>>
>>> The function fill_device_from_item() does the job of reading it from the
>>> item and updating btrfs_device::disk_total_bytes. So both the missing
>>> device and the seed devices do have their disk_total_bytes updated.
>>>
>>> So this patch removes the check dev->disk_total_bytes == 0 in the
>>> function verify_one_dev_extent()
>>>
>>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>>> ---
>>> fs/btrfs/volumes.c | 15 ---------------
>>> 1 file changed, 15 deletions(-)
>>>
>>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>>> index 7f43ed88fffc..9be40eece8ed 100644
>>> --- a/fs/btrfs/volumes.c
>>> +++ b/fs/btrfs/volumes.c
>>> @@ -7578,21 +7578,6 @@ static int verify_one_dev_extent(struct btrfs_fs_info *fs_info,
>>> goto out;
>>> }
>>>
>>> - /* It's possible this device is a dummy for seed device */
>>> - if (dev->disk_total_bytes == 0) {
>>> - struct btrfs_fs_devices *devs;
>>> -
>>> - devs = list_first_entry(&fs_info->fs_devices->seed_list,
>>> - struct btrfs_fs_devices, seed_list);
>>> - dev = btrfs_find_device(devs, devid, NULL, NULL, false);
>>> - if (!dev) {
>>> - btrfs_err(fs_info, "failed to find seed devid %llu",
>>> - devid);
>>> - ret = -EUCLEAN;
>>> - goto out;
>>> - }
>>> - }
>>
>> The commit which introduced this check states that the device with a
>> disk_total_bytes = 0 occurs from clone_fs_devices called from open_seed.
>> It seems the check is legit and your changelog doesn't account for that
>> if it's safe you should provide description why is that.
>
> And it would be even better to mention the fragmentation problem in the
> man page for btrfs-convert.
>
> The fragmentation problem is a little too complex to explain in the
> error message nor usage.
Please ignore this, I replied to the wrong thread...
>
> Thanks,
> Qu
>>
>>> -
>>> if (physical_offset + physical_len > dev->disk_total_bytes) {
>>> btrfs_err(fs_info,
>>> "dev extent devid %llu physical offset %llu len %llu is beyond device boundary %llu",
>>>
next prev parent reply other threads:[~2020-09-24 12:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 10:11 [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-09-24 10:11 ` [PATCH 1/2] btrfs: drop never met condition of disk_total_bytes == 0 Anand Jain
2020-09-24 11:48 ` Nikolay Borisov
2020-09-24 11:58 ` Qu Wenruo
2020-09-24 12:19 ` Qu Wenruo [this message]
2020-09-25 4:17 ` Anand Jain
2020-09-25 6:19 ` Nikolay Borisov
2020-09-25 7:33 ` Anand Jain
2020-09-25 7:56 ` Nikolay Borisov
2020-09-25 8:12 ` Anand Jain
2020-10-05 13:22 ` Josef Bacik
2020-10-06 12:53 ` Anand Jain
2020-10-06 12:54 ` [PATCH v2 " Anand Jain
2020-10-21 4:16 ` [PATCH RESEND " Anand Jain
2020-10-21 14:35 ` Josef Bacik
2020-10-22 9:40 ` Anand Jain
2020-10-29 21:30 ` Anand Jain
2020-09-24 10:11 ` [PATCH 2/2] btrfs: fix btrfs_find_device unused arg seed Anand Jain
2020-09-24 10:21 ` Nikolay Borisov
2020-09-25 8:22 ` Nikolay Borisov
2020-09-25 8:42 ` Anand Jain
2020-10-05 13:23 ` Josef Bacik
2020-10-21 4:16 ` [PATCH RESEND " Anand Jain
2020-10-29 21:30 ` [PATCH RESEND v2 " Anand Jain
2020-10-02 3:14 ` [PATCH 0/2] fix verify_one_dev_extent and btrfs_find_device Anand Jain
2020-10-21 4:16 ` [PATCH RESEND " Anand Jain
2020-10-29 21:02 ` David Sterba
2020-10-29 21:14 ` Anand Jain
2020-11-11 15:49 ` David Sterba
2020-10-29 21:30 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffc60c8f-3045-640b-bed9-07001287470a@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).