* [PATCH] btrfs-progs: remove BTRFS_LIST_LAYOUT_RAW
@ 2018-05-15 9:17 Gu Jinxiang
2018-05-16 8:11 ` Nikolay Borisov
0 siblings, 1 reply; 2+ messages in thread
From: Gu Jinxiang @ 2018-05-15 9:17 UTC (permalink / raw)
To: linux-btrfs
Since
commit 9005b603d723 ("btrfs-progs: use libbtrfsutil for subvol show"),
BTRFS_LIST_LAYOUT_RAW has no usage.
So, remove it.
Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
---
btrfs-list.c | 20 --------------------
btrfs-list.h | 3 +--
2 files changed, 1 insertion(+), 22 deletions(-)
diff --git a/btrfs-list.c b/btrfs-list.c
index e01c5899..16be6b2f 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -1374,23 +1374,6 @@ static void print_subvolume_column(struct root_info *subv,
}
}
-static void print_one_subvol_info_raw(struct root_info *subv,
- const char *raw_prefix)
-{
- int i;
-
- for (i = 0; i < BTRFS_LIST_ALL; i++) {
- if (!btrfs_list_columns[i].need_print)
- continue;
-
- if (raw_prefix)
- printf("%s",raw_prefix);
-
- print_subvolume_column(subv, i);
- }
- printf("\n");
-}
-
static void print_one_subvol_info_table(struct root_info *subv)
{
int i;
@@ -1480,9 +1463,6 @@ static void print_all_subvol_info(struct root_lookup *sorted_tree,
case BTRFS_LIST_LAYOUT_TABLE:
print_one_subvol_info_table(entry);
break;
- case BTRFS_LIST_LAYOUT_RAW:
- print_one_subvol_info_raw(entry, raw_prefix);
- break;
}
next:
n = rb_next(n);
diff --git a/btrfs-list.h b/btrfs-list.h
index 6e5fc778..299e3122 100644
--- a/btrfs-list.h
+++ b/btrfs-list.h
@@ -33,8 +33,7 @@
enum btrfs_list_layout {
BTRFS_LIST_LAYOUT_DEFAULT = 0,
- BTRFS_LIST_LAYOUT_TABLE,
- BTRFS_LIST_LAYOUT_RAW
+ BTRFS_LIST_LAYOUT_TABLE
};
/*
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs-progs: remove BTRFS_LIST_LAYOUT_RAW
2018-05-15 9:17 [PATCH] btrfs-progs: remove BTRFS_LIST_LAYOUT_RAW Gu Jinxiang
@ 2018-05-16 8:11 ` Nikolay Borisov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2018-05-16 8:11 UTC (permalink / raw)
To: Gu Jinxiang, linux-btrfs
On 15.05.2018 12:17, Gu Jinxiang wrote:
> Since
> commit 9005b603d723 ("btrfs-progs: use libbtrfsutil for subvol show"),
> BTRFS_LIST_LAYOUT_RAW has no usage.
> So, remove it.
>
> Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> btrfs-list.c | 20 --------------------
> btrfs-list.h | 3 +--
> 2 files changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/btrfs-list.c b/btrfs-list.c
> index e01c5899..16be6b2f 100644
> --- a/btrfs-list.c
> +++ b/btrfs-list.c
> @@ -1374,23 +1374,6 @@ static void print_subvolume_column(struct root_info *subv,
> }
> }
>
> -static void print_one_subvol_info_raw(struct root_info *subv,
> - const char *raw_prefix)
> -{
> - int i;
> -
> - for (i = 0; i < BTRFS_LIST_ALL; i++) {
> - if (!btrfs_list_columns[i].need_print)
> - continue;
> -
> - if (raw_prefix)
> - printf("%s",raw_prefix);
> -
> - print_subvolume_column(subv, i);
> - }
> - printf("\n");
> -}
> -
> static void print_one_subvol_info_table(struct root_info *subv)
> {
> int i;
> @@ -1480,9 +1463,6 @@ static void print_all_subvol_info(struct root_lookup *sorted_tree,
> case BTRFS_LIST_LAYOUT_TABLE:
> print_one_subvol_info_table(entry);
> break;
> - case BTRFS_LIST_LAYOUT_RAW:
> - print_one_subvol_info_raw(entry, raw_prefix);
> - break;
> }
> next:
> n = rb_next(n);
> diff --git a/btrfs-list.h b/btrfs-list.h
> index 6e5fc778..299e3122 100644
> --- a/btrfs-list.h
> +++ b/btrfs-list.h
> @@ -33,8 +33,7 @@
>
> enum btrfs_list_layout {
> BTRFS_LIST_LAYOUT_DEFAULT = 0,
> - BTRFS_LIST_LAYOUT_TABLE,
> - BTRFS_LIST_LAYOUT_RAW
> + BTRFS_LIST_LAYOUT_TABLE
> };
>
> /*
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-16 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 9:17 [PATCH] btrfs-progs: remove BTRFS_LIST_LAYOUT_RAW Gu Jinxiang
2018-05-16 8:11 ` Nikolay Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).