From: Chao Yu <yuchao0@huawei.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, <linux-fsdevel@vger.kernel.org>
Cc: <linux-ext4@vger.kernel.org>, <linux-btrfs@vger.kernel.org>,
<hch@infradead.org>, <andres@anarazel.de>, <david@fromorbit.com>,
<riteshh@linux.ibm.com>, <linux-f2fs-devel@lists.sourceforge.net>,
"Goldwyn Rodrigues" <rgoldwyn@suse.com>
Subject: Re: [PATCH 3/3] f2fs: fix inode rwsem regression
Date: Thu, 12 Sep 2019 14:17:32 +0800 [thread overview]
Message-ID: <77bec57d-2bd1-db40-917e-7dccb58cb3b7@huawei.com> (raw)
In-Reply-To: <20190911164517.16130-4-rgoldwyn@suse.de>
On 2019/9/12 0:45, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression")
> Apparently our current rwsem code doesn't like doing the trylock, then
> lock for real scheme. So change our read/write methods to just do the
> trylock for the RWF_NOWAIT case.
>
> We don't need a check for IOCB_NOWAIT and !direct-IO because it
> is checked in generic_write_checks().
>
> Fixes: b91050a80cec ("f2fs: add nowait aio support")
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> fs/f2fs/file.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 3e58a6f697dd..c6f3ef815c05 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -3134,16 +3134,12 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
> goto out;
> }
>
> - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT)) {
> - ret = -EINVAL;
> - goto out;
> - }
We have removed above redundant check, could you rebase to dev-test branch of
Jaegeuk's git tree?
Otherwise it looks good to me.
Thanks,
> -
> - if (!inode_trylock(inode)) {
> - if (iocb->ki_flags & IOCB_NOWAIT) {
> + if (iocb->ki_flags & IOCB_NOWAIT) {
> + if (!inode_trylock(inode)) {
> ret = -EAGAIN;
> goto out;
> }
> + } else {
> inode_lock(inode);
> }
>
>
next prev parent reply other threads:[~2019-09-12 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190910223327.mnegfoggopwqqy33@alap3.anarazel.de>
[not found] ` <20190911040420.GB27547@dread.disaster.area>
2019-09-11 9:39 ` Odd locking pattern introduced as part of "nowait aio support" Andres Freund
2019-09-11 10:19 ` Christoph Hellwig
2019-09-11 10:31 ` Ritesh Harjani
2019-09-11 10:55 ` Goldwyn Rodrigues
2019-09-11 16:45 ` Fix inode sem regression for nowait Goldwyn Rodrigues
2019-09-11 16:45 ` [PATCH 1/3] btrfs: fix inode rwsem regression Goldwyn Rodrigues
2019-09-11 17:21 ` David Sterba
2019-09-11 16:45 ` [PATCH 2/3] ext4: " Goldwyn Rodrigues
2019-09-12 8:52 ` Ritesh Harjani
2019-09-12 9:26 ` Matthew Bobrowski
2019-09-23 10:10 ` Jan Kara
2019-09-23 13:18 ` Theodore Y. Ts'o
2019-09-11 16:45 ` [PATCH 3/3] f2fs: " Goldwyn Rodrigues
2019-09-12 6:17 ` Chao Yu [this message]
2019-09-13 19:46 ` Jaegeuk Kim
2019-09-16 1:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77bec57d-2bd1-db40-917e-7dccb58cb3b7@huawei.com \
--to=yuchao0@huawei.com \
--cc=andres@anarazel.de \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).