linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] btrfs: print message when tree-log replay starts
@ 2020-02-07 15:16 David Sterba
  2020-02-07 16:01 ` Anand Jain
  2020-02-10  9:44 ` Johannes Thumshirn
  0 siblings, 2 replies; 3+ messages in thread
From: David Sterba @ 2020-02-07 15:16 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Sterba, anand.jain, Chris Murphy, stable

There's no logged information about tree-log replay although this is
something that points to previous unclean unmount. Other filesystems
report that as well.

Suggested-by: Chris Murphy <lists@colorremedies.com>
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: David Sterba <dsterba@suse.com>
---

* add missing fs_info to btrfs_info

 fs/btrfs/disk-io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 8fee95916be4..db16014abd64 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3224,6 +3224,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	/* do not make disk changes in broken FS or nologreplay is given */
 	if (btrfs_super_log_root(disk_super) != 0 &&
 	    !btrfs_test_opt(fs_info, NOLOGREPLAY)) {
+		btrfs_info(fs_info, "start tree-log replay");
 		ret = btrfs_replay_log(fs_info, fs_devices);
 		if (ret) {
 			err = ret;
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] btrfs: print message when tree-log replay starts
  2020-02-07 15:16 [PATCH v2] btrfs: print message when tree-log replay starts David Sterba
@ 2020-02-07 16:01 ` Anand Jain
  2020-02-10  9:44 ` Johannes Thumshirn
  1 sibling, 0 replies; 3+ messages in thread
From: Anand Jain @ 2020-02-07 16:01 UTC (permalink / raw)
  To: David Sterba, linux-btrfs; +Cc: Chris Murphy, stable


Reviewed-by: Anand Jain <anand.jain@oracle.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] btrfs: print message when tree-log replay starts
  2020-02-07 15:16 [PATCH v2] btrfs: print message when tree-log replay starts David Sterba
  2020-02-07 16:01 ` Anand Jain
@ 2020-02-10  9:44 ` Johannes Thumshirn
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2020-02-10  9:44 UTC (permalink / raw)
  To: David Sterba, linux-btrfs; +Cc: anand.jain, Chris Murphy, stable

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-10  9:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 15:16 [PATCH v2] btrfs: print message when tree-log replay starts David Sterba
2020-02-07 16:01 ` Anand Jain
2020-02-10  9:44 ` Johannes Thumshirn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).