[PATCH] btrfs: Remove unused variable

[PATCH] btrfs: Remove unused variable

[Nikolay Borisov]

This fixes fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used [-Wunused-but-set-variable]
  491 |  u64 zone_size;

Which got introduced in 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode")

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 fs/btrfs/zoned.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index c38846659019..41d27fefd306 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -488,7 +488,6 @@ int btrfs_sb_log_location_bdev(struct block_device *bdev, int mirror, int rw,
 	unsigned int zone_sectors;
 	u32 sb_zone;
 	int ret;
-	u64 zone_size;
 	u8 zone_sectors_shift;
 	sector_t nr_sectors;
 	u32 nr_zones;
@@ -503,7 +502,6 @@ int btrfs_sb_log_location_bdev(struct block_device *bdev, int mirror, int rw,
 	zone_sectors = bdev_zone_sectors(bdev);
 	if (!is_power_of_2(zone_sectors))
 		return -EINVAL;
-	zone_size = zone_sectors << SECTOR_SHIFT;
 	zone_sectors_shift = ilog2(zone_sectors);
 	nr_sectors = bdev_nr_sectors(bdev);
 	nr_zones = nr_sectors >> zone_sectors_shift;
-- 
2.25.1

Re: [PATCH] btrfs: Remove unused variable

[Johannes Thumshirn]

On 24/01/2021 17:05, Nikolay Borisov wrote:
> This fixes fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used [-Wunused-but-set-variable]
>   491 |  u64 zone_size;
> 
> Which got introduced in 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode")
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Even with the zoned complete zoned patchset (for-v14) applied 
the compiler is correct about this issue, ergo this patch fixes it.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Re: [PATCH] btrfs: Remove unused variable

[David Sterba]

On Sun, Jan 24, 2021 at 06:03:21PM +0200, Nikolay Borisov wrote:
> This fixes fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used [-Wunused-but-set-variable]
>   491 |  u64 zone_size;
> 
> Which got introduced in 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode")
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

With updated subject and changelog added to misc-next, thanks.