* [PATCH 00/20] drop useless LIST_HEAD
@ 2018-12-23 8:56 Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
0 siblings, 2 replies; 9+ messages in thread
From: Julia Lawall @ 2018-12-23 8:56 UTC (permalink / raw)
To: Andy Shevchenko
Cc: kernel-janitors, dmaengine, linux-arm-kernel, Dan Williams,
linux-scsi, linux-nfs, linux-kernel, netdev, linux-rdma,
linux-xfs, linux-btrfs, Stefano Stabellini, xen-devel,
linux-wireless
Drop LIST_HEAD where the variable it declares is never used.
---
drivers/dma/at_hdmac.c | 5 -----
drivers/dma/dw/core.c | 1 -
drivers/dma/pl330.c | 1 -
drivers/dma/sa11x0-dma.c | 2 --
drivers/dma/st_fdma.c | 3 ---
drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
drivers/net/wireless/st/cw1200/queue.c | 1 -
drivers/scsi/lpfc/lpfc_nvme.c | 2 --
drivers/scsi/lpfc/lpfc_scsi.c | 2 --
drivers/scsi/lpfc/lpfc_sli.c | 1 -
drivers/scsi/qla2xxx/qla_init.c | 1 -
drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
fs/btrfs/relocation.c | 1 -
fs/nfs/nfs4client.c | 1 -
fs/nfsd/nfs4layouts.c | 1 -
fs/xfs/xfs_buf.c | 1 -
fs/xfs/xfs_fsops.c | 1 -
20 files changed, 36 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 11/20] Btrfs: drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
@ 2018-12-23 8:57 ` Julia Lawall
2019-01-02 16:40 ` David Sterba
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
1 sibling, 1 reply; 9+ messages in thread
From: Julia Lawall @ 2018-12-23 8:57 UTC (permalink / raw)
To: Chris Mason
Cc: kernel-janitors, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
Drop LIST_HEAD where the variable it declares is never used.
The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC
handling for balance"), but not the declaration.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
... when != x
// </smpl>
Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Successfully 0-day tested on 151 configurations.
fs/btrfs/relocation.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 272b287f8cf0..de802ba35a34 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -2128,7 +2128,6 @@ static noinline_for_stack int merge_reloc_root(struct reloc_control *rc,
struct btrfs_root *root)
{
struct btrfs_fs_info *fs_info = rc->extent_root->fs_info;
- LIST_HEAD(inode_list);
struct btrfs_key key;
struct btrfs_key next_key;
struct btrfs_trans_handle *trans = NULL;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
@ 2018-12-23 21:49 ` Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
1 sibling, 1 reply; 9+ messages in thread
From: Tom Psyborg @ 2018-12-23 21:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Andy Shevchenko, kernel-janitors, dmaengine, linux-arm-kernel,
Dan Williams, linux-scsi, linux-nfs, linux-kernel, netdev,
linux-rdma, linux-xfs, linux-btrfs, Stefano Stabellini,
xen-devel, linux-wireless
Why do you CC this to so many lists?
On 23/12/2018, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> ---
>
> drivers/dma/at_hdmac.c | 5 -----
> drivers/dma/dw/core.c | 1 -
> drivers/dma/pl330.c | 1 -
> drivers/dma/sa11x0-dma.c | 2 --
> drivers/dma/st_fdma.c | 3 ---
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
> drivers/net/wireless/st/cw1200/queue.c | 1 -
> drivers/scsi/lpfc/lpfc_nvme.c | 2 --
> drivers/scsi/lpfc/lpfc_scsi.c | 2 --
> drivers/scsi/lpfc/lpfc_sli.c | 1 -
> drivers/scsi/qla2xxx/qla_init.c | 1 -
> drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
> fs/btrfs/relocation.c | 1 -
> fs/nfs/nfs4client.c | 1 -
> fs/nfsd/nfs4layouts.c | 1 -
> fs/xfs/xfs_buf.c | 1 -
> fs/xfs/xfs_fsops.c | 1 -
> 20 files changed, 36 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
@ 2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
0 siblings, 1 reply; 9+ messages in thread
From: Julia Lawall @ 2018-12-23 22:06 UTC (permalink / raw)
To: Tom Psyborg
Cc: Julia Lawall, Andy Shevchenko, kernel-janitors, dmaengine,
linux-arm-kernel, Dan Williams, linux-scsi, linux-nfs,
linux-kernel, netdev, linux-rdma, linux-xfs, linux-btrfs,
Stefano Stabellini, xen-devel, linux-wireless
On Sun, 23 Dec 2018, Tom Psyborg wrote:
> Why do you CC this to so many lists?
Because the different files are in different subsystems. The cover letter
goes to a list for each file, or to a person if there is no list. The
patches go to the people and lists associated with the affected files.
julia
>
> On 23/12/2018, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > Drop LIST_HEAD where the variable it declares is never used.
> >
> > ---
> >
> > drivers/dma/at_hdmac.c | 5 -----
> > drivers/dma/dw/core.c | 1 -
> > drivers/dma/pl330.c | 1 -
> > drivers/dma/sa11x0-dma.c | 2 --
> > drivers/dma/st_fdma.c | 3 ---
> > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
> > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
> > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
> > drivers/net/wireless/st/cw1200/queue.c | 1 -
> > drivers/scsi/lpfc/lpfc_nvme.c | 2 --
> > drivers/scsi/lpfc/lpfc_scsi.c | 2 --
> > drivers/scsi/lpfc/lpfc_sli.c | 1 -
> > drivers/scsi/qla2xxx/qla_init.c | 1 -
> > drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
> > fs/btrfs/relocation.c | 1 -
> > fs/nfs/nfs4client.c | 1 -
> > fs/nfsd/nfs4layouts.c | 1 -
> > fs/xfs/xfs_buf.c | 1 -
> > fs/xfs/xfs_fsops.c | 1 -
> > 20 files changed, 36 deletions(-)
> >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-23 22:06 ` Julia Lawall
@ 2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
0 siblings, 1 reply; 9+ messages in thread
From: Tom Psyborg @ 2018-12-25 22:12 UTC (permalink / raw)
To: Julia Lawall
Cc: Andy Shevchenko, kernel-janitors, dmaengine, linux-arm-kernel,
Dan Williams, linux-scsi, linux-nfs, linux-kernel, netdev,
linux-rdma, linux-xfs, linux-btrfs, Stefano Stabellini,
xen-devel, linux-wireless
there was discussion about this just some days ago. CC 4-5 lists is
more than enough
On 23/12/2018, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 23 Dec 2018, Tom Psyborg wrote:
>
>> Why do you CC this to so many lists?
>
> Because the different files are in different subsystems. The cover letter
> goes to a list for each file, or to a person if there is no list. The
> patches go to the people and lists associated with the affected files.
>
> julia
>
>>
>> On 23/12/2018, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>> > Drop LIST_HEAD where the variable it declares is never used.
>> >
>> > ---
>> >
>> > drivers/dma/at_hdmac.c | 5 -----
>> > drivers/dma/dw/core.c | 1 -
>> > drivers/dma/pl330.c | 1 -
>> > drivers/dma/sa11x0-dma.c | 2 --
>> > drivers/dma/st_fdma.c | 3 ---
>> > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 -
>> > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 -----
>> > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
>> > drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
>> > drivers/net/wireless/st/cw1200/queue.c | 1 -
>> > drivers/scsi/lpfc/lpfc_nvme.c | 2 --
>> > drivers/scsi/lpfc/lpfc_scsi.c | 2 --
>> > drivers/scsi/lpfc/lpfc_sli.c | 1 -
>> > drivers/scsi/qla2xxx/qla_init.c | 1 -
>> > drivers/xen/xenbus/xenbus_dev_frontend.c | 2 --
>> > fs/btrfs/relocation.c | 1 -
>> > fs/nfs/nfs4client.c | 1 -
>> > fs/nfsd/nfs4layouts.c | 1 -
>> > fs/xfs/xfs_buf.c | 1 -
>> > fs/xfs/xfs_fsops.c | 1 -
>> > 20 files changed, 36 deletions(-)
>> >
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-25 22:12 ` Tom Psyborg
@ 2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
0 siblings, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2018-12-27 13:40 UTC (permalink / raw)
To: Tom Psyborg
Cc: Julia Lawall, Andy Shevchenko, kernel-janitors, dmaengine,
linux-arm-kernel, Dan Williams, linux-scsi, linux-nfs,
linux-kernel, netdev, linux-rdma, linux-xfs, linux-btrfs,
Stefano Stabellini, xen-devel, linux-wireless
On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> there was discussion about this just some days ago. CC 4-5 lists is
> more than enough
>
I don't know who you were discussing this with...
You should CC the 0th patch to all the mailinglists. That much is a
clear rule.
For the rest, Julia's position is the more conservative one. I was in
a conversation in RL and they were like, "CC everyone for all the
patches". It depends on the context, of course. If the patches are
dependent on each other then you *have* to CC everyone for everything.
If we really have other clear rules, then it should be encoded into
get_maintainer.pl so that it's automatic.
My other question is why do the linux-arm-kernel@lists.infradead.org
people feel like they need to be CC'd about every driver??? I always
remove them from the CC list unless it's an arch/arm issue.
regards,
dan carpenter
PS: Please, no more top posting.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-27 13:40 ` Dan Carpenter
@ 2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
0 siblings, 1 reply; 9+ messages in thread
From: Darrick J. Wong @ 2018-12-29 5:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tom Psyborg, Julia Lawall, Andy Shevchenko, kernel-janitors,
dmaengine, linux-arm-kernel, Dan Williams, linux-scsi, linux-nfs,
linux-kernel, netdev, linux-rdma, linux-xfs, linux-btrfs,
Stefano Stabellini, xen-devel, linux-wireless
On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote:
> On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> > there was discussion about this just some days ago. CC 4-5 lists is
> > more than enough
> >
>
> I don't know who you were discussing this with...
>
> You should CC the 0th patch to all the mailinglists. That much is a
> clear rule.
>
> For the rest, Julia's position is the more conservative one. I was in
> a conversation in RL and they were like, "CC everyone for all the
> patches". It depends on the context, of course. If the patches are
> dependent on each other then you *have* to CC everyone for everything.
Agreed. Ms. Lawall, sending "Cover letter + all relevant XFS patches"
(as you did) was exactly the right thing for us xfs types. :)
For that matter, we prefer to receive through linux-xfs more patches
than necessary (one can send the entire series if one is unsure) than to
go wanting for more context.
--D
> If we really have other clear rules, then it should be encoded into
> get_maintainer.pl so that it's automatic.
>
> My other question is why do the linux-arm-kernel@lists.infradead.org
> people feel like they need to be CC'd about every driver??? I always
> remove them from the CC list unless it's an arch/arm issue.
>
> regards,
> dan carpenter
>
> PS: Please, no more top posting.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] drop useless LIST_HEAD
2018-12-29 5:25 ` Darrick J. Wong
@ 2018-12-29 6:19 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2018-12-29 6:19 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Dan Carpenter, Tom Psyborg, Julia Lawall, Andy Shevchenko,
kernel-janitors, dmaengine, linux-arm-kernel, Dan Williams,
linux-scsi, linux-nfs, linux-kernel, netdev, linux-rdma,
linux-xfs, linux-btrfs, Stefano Stabellini, xen-devel,
linux-wireless
On Fri, 28 Dec 2018, Darrick J. Wong wrote:
> On Thu, Dec 27, 2018 at 04:40:55PM +0300, Dan Carpenter wrote:
> > On Tue, Dec 25, 2018 at 11:12:20PM +0100, Tom Psyborg wrote:
> > > there was discussion about this just some days ago. CC 4-5 lists is
> > > more than enough
> > >
> >
> > I don't know who you were discussing this with...
> >
> > You should CC the 0th patch to all the mailinglists. That much is a
> > clear rule.
> >
> > For the rest, Julia's position is the more conservative one. I was in
> > a conversation in RL and they were like, "CC everyone for all the
> > patches". It depends on the context, of course. If the patches are
> > dependent on each other then you *have* to CC everyone for everything.
>
> Agreed. Ms. Lawall, sending "Cover letter + all relevant XFS patches"
> (as you did) was exactly the right thing for us xfs types. :)
>
> For that matter, we prefer to receive through linux-xfs more patches
> than necessary (one can send the entire series if one is unsure) than to
> go wanting for more context.
Thanks for the confirmation. I was planning to ignore the 4-5 advice,
because there is no way in this case to make a meaningful 4-5 list
suggestion - it's either all or nothing. But 20 patches at once is
perhaps a lot as well. In this case, I just wanted to get rid of the
whole issue at once.
julia
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 11/20] Btrfs: drop useless LIST_HEAD
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
@ 2019-01-02 16:40 ` David Sterba
0 siblings, 0 replies; 9+ messages in thread
From: David Sterba @ 2019-01-02 16:40 UTC (permalink / raw)
To: Julia Lawall
Cc: Chris Mason, kernel-janitors, Josef Bacik, David Sterba,
linux-btrfs, linux-kernel
On Sun, Dec 23, 2018 at 09:57:06AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC
> handling for balance"), but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Added to patch queue, thanks. I've dropepd the Fixes: line as it's not
really a fix that would need to go to stable. The original commit is
mentioned in the changelog which is IMHO sufficient.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-01-02 16:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:57 ` [PATCH 11/20] Btrfs: " Julia Lawall
2019-01-02 16:40 ` David Sterba
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).