From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
Date: Wed, 13 Nov 2019 11:01:00 +0200 [thread overview]
Message-ID: <ed91ef1f-edb4-c5fa-5b0e-7025851e157b@suse.com> (raw)
In-Reply-To: <20191113065716.33948-1-wqu@suse.com>
On 13.11.19 г. 8:57 ч., Qu Wenruo wrote:
> Currently fstests will remove $seqres.dmesg if nothing wrong happened.
> It saves some space, but sometimes it may not provide good enough
> history for developers to check.
> E.g. some unexpected dmesg from fs, but not serious enough to be caught
> by current filter.
>
> So instead of deleting the ordinary $seqres.dmesg, just keep them, so
> we can archive them for later review.
Rather than keeping the seqres dmesg for all tests why not simply extend
the filter?
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> common/rc | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index b988e912..59a339a6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3625,10 +3625,8 @@ _check_dmesg()
> if [ $? -eq 0 ]; then
> _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
> return 1
> - else
> - rm -f $seqres.dmesg
> - return 0
> fi
> + return 0
> }
>
> # capture the kmemleak report
>
next prev parent reply other threads:[~2019-11-13 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 6:57 [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR Qu Wenruo
2019-11-13 9:01 ` Nikolay Borisov [this message]
2019-11-13 9:12 ` Qu Wenruo
2019-11-13 6:59 Qu Wenruo
2019-11-24 16:15 ` Eryu Guan
2019-11-25 4:59 ` Qu WenRuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed91ef1f-edb4-c5fa-5b0e-7025851e157b@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).