* [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
@ 2019-11-13 6:57 Qu Wenruo
2019-11-13 9:01 ` Nikolay Borisov
0 siblings, 1 reply; 6+ messages in thread
From: Qu Wenruo @ 2019-11-13 6:57 UTC (permalink / raw)
To: linux-btrfs
Currently fstests will remove $seqres.dmesg if nothing wrong happened.
It saves some space, but sometimes it may not provide good enough
history for developers to check.
E.g. some unexpected dmesg from fs, but not serious enough to be caught
by current filter.
So instead of deleting the ordinary $seqres.dmesg, just keep them, so
we can archive them for later review.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
common/rc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/common/rc b/common/rc
index b988e912..59a339a6 100644
--- a/common/rc
+++ b/common/rc
@@ -3625,10 +3625,8 @@ _check_dmesg()
if [ $? -eq 0 ]; then
_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
return 1
- else
- rm -f $seqres.dmesg
- return 0
fi
+ return 0
}
# capture the kmemleak report
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
2019-11-13 6:57 [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR Qu Wenruo
@ 2019-11-13 9:01 ` Nikolay Borisov
2019-11-13 9:12 ` Qu Wenruo
0 siblings, 1 reply; 6+ messages in thread
From: Nikolay Borisov @ 2019-11-13 9:01 UTC (permalink / raw)
To: Qu Wenruo, linux-btrfs
On 13.11.19 г. 8:57 ч., Qu Wenruo wrote:
> Currently fstests will remove $seqres.dmesg if nothing wrong happened.
> It saves some space, but sometimes it may not provide good enough
> history for developers to check.
> E.g. some unexpected dmesg from fs, but not serious enough to be caught
> by current filter.
>
> So instead of deleting the ordinary $seqres.dmesg, just keep them, so
> we can archive them for later review.
Rather than keeping the seqres dmesg for all tests why not simply extend
the filter?
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> common/rc | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index b988e912..59a339a6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3625,10 +3625,8 @@ _check_dmesg()
> if [ $? -eq 0 ]; then
> _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
> return 1
> - else
> - rm -f $seqres.dmesg
> - return 0
> fi
> + return 0
> }
>
> # capture the kmemleak report
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
2019-11-13 9:01 ` Nikolay Borisov
@ 2019-11-13 9:12 ` Qu Wenruo
0 siblings, 0 replies; 6+ messages in thread
From: Qu Wenruo @ 2019-11-13 9:12 UTC (permalink / raw)
To: Nikolay Borisov, Qu Wenruo, linux-btrfs
On 2019/11/13 下午5:01, Nikolay Borisov wrote:
>
>
> On 13.11.19 г. 8:57 ч., Qu Wenruo wrote:
>> Currently fstests will remove $seqres.dmesg if nothing wrong happened.
>> It saves some space, but sometimes it may not provide good enough
>> history for developers to check.
>> E.g. some unexpected dmesg from fs, but not serious enough to be caught
>> by current filter.
>>
>> So instead of deleting the ordinary $seqres.dmesg, just keep them, so
>> we can archive them for later review.
>
> Rather than keeping the seqres dmesg for all tests why not simply extend
> the filter?
Because you never know when you need to update the filter.
I don't see any reason by not keeping the dmesg other than to save some
disk space.
It would be just too annoying if some report hits you with only
$seqres.out.bad but some clues like btrfs_info() is completely ignored.
Thanks,
Qu
>
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>> ---
>> common/rc | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/common/rc b/common/rc
>> index b988e912..59a339a6 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -3625,10 +3625,8 @@ _check_dmesg()
>> if [ $? -eq 0 ]; then
>> _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
>> return 1
>> - else
>> - rm -f $seqres.dmesg
>> - return 0
>> fi
>> + return 0
>> }
>>
>> # capture the kmemleak report
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
@ 2019-11-13 6:59 Qu Wenruo
2019-11-24 16:15 ` Eryu Guan
0 siblings, 1 reply; 6+ messages in thread
From: Qu Wenruo @ 2019-11-13 6:59 UTC (permalink / raw)
To: fstests, linux-btrfs
Currently fstests will remove $seqres.dmesg if nothing wrong happened.
It saves some space, but sometimes it may not provide good enough
history for developers to check.
E.g. some unexpected dmesg from fs, but not serious enough to be caught
by current filter.
So instead of deleting the ordinary $seqres.dmesg, just keep them, so
we can archive them for later review.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
common/rc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/common/rc b/common/rc
index b988e912..59a339a6 100644
--- a/common/rc
+++ b/common/rc
@@ -3625,10 +3625,8 @@ _check_dmesg()
if [ $? -eq 0 ]; then
_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
return 1
- else
- rm -f $seqres.dmesg
- return 0
fi
+ return 0
}
# capture the kmemleak report
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
2019-11-13 6:59 Qu Wenruo
@ 2019-11-24 16:15 ` Eryu Guan
2019-11-25 4:59 ` Qu WenRuo
0 siblings, 1 reply; 6+ messages in thread
From: Eryu Guan @ 2019-11-24 16:15 UTC (permalink / raw)
To: Qu Wenruo; +Cc: fstests, linux-btrfs
On Wed, Nov 13, 2019 at 02:59:38PM +0800, Qu Wenruo wrote:
> Currently fstests will remove $seqres.dmesg if nothing wrong happened.
> It saves some space, but sometimes it may not provide good enough
> history for developers to check.
> E.g. some unexpected dmesg from fs, but not serious enough to be caught
> by current filter.
>
> So instead of deleting the ordinary $seqres.dmesg, just keep them, so
> we can archive them for later review.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
This looks fine to me, but it causes more disk space consumption and may
eat all rootfs space quickly and unexpectedly.
I suggest we add an option to control the behavior, and default behavior
is to delete the dmesg file.
Thanks,
Eryu
> ---
> common/rc | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index b988e912..59a339a6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3625,10 +3625,8 @@ _check_dmesg()
> if [ $? -eq 0 ]; then
> _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
> return 1
> - else
> - rm -f $seqres.dmesg
> - return 0
> fi
> + return 0
> }
>
> # capture the kmemleak report
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR
2019-11-24 16:15 ` Eryu Guan
@ 2019-11-25 4:59 ` Qu WenRuo
0 siblings, 0 replies; 6+ messages in thread
From: Qu WenRuo @ 2019-11-25 4:59 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, linux-btrfs
On 2019/11/25 上午12:15, Eryu Guan wrote:
> On Wed, Nov 13, 2019 at 02:59:38PM +0800, Qu Wenruo wrote:
>> Currently fstests will remove $seqres.dmesg if nothing wrong happened.
>> It saves some space, but sometimes it may not provide good enough
>> history for developers to check.
>> E.g. some unexpected dmesg from fs, but not serious enough to be caught
>> by current filter.
>>
>> So instead of deleting the ordinary $seqres.dmesg, just keep them, so
>> we can archive them for later review.
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>
> This looks fine to me, but it causes more disk space consumption and may
> eat all rootfs space quickly and unexpectedly.
>
> I suggest we add an option to control the behavior, and default behavior
> is to delete the dmesg file.
Sure, I'll add an option to change the behavior in next version.
Thanks,
Qu
>
> Thanks,
> Eryu
>
>> ---
>> common/rc | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/common/rc b/common/rc
>> index b988e912..59a339a6 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -3625,10 +3625,8 @@ _check_dmesg()
>> if [ $? -eq 0 ]; then
>> _dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
>> return 1
>> - else
>> - rm -f $seqres.dmesg
>> - return 0
>> fi
>> + return 0
>> }
>>
>> # capture the kmemleak report
>> --
>> 2.23.0
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-25 5:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 6:57 [PATCH] fstests: common: Keep $seqres.dmesg in $RESULT_DIR Qu Wenruo
2019-11-13 9:01 ` Nikolay Borisov
2019-11-13 9:12 ` Qu Wenruo
2019-11-13 6:59 Qu Wenruo
2019-11-24 16:15 ` Eryu Guan
2019-11-25 4:59 ` Qu WenRuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).