bugs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Kernel.org Bugbot" <bugbot@kernel.org>
To: linux-rockchip@lists.infradead.org, heiko@sntech.de,
	 bugs@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: rockchip: rk3328: rk3328_mux_recalced_data: fix bit alignment
Date: Fri, 19 May 2023 07:10:44 +0000	[thread overview]
Message-ID: <20230519-b217334c6-f82053afb53a@bugzilla.kernel.org> (raw)
In-Reply-To: <20230419-b217334c0-3101f9f4b426@bugzilla.kernel.org>

antwain.schneider writes via Kernel.org Bugzilla:

*** PROOF OF CONCEPT ALERT ***

here is a fun and easy way to prove how broken the current calculation is using both of the bug reports i have made combined together

using a unmodified kernel with an unmodified dtb, take note of the grf iomux gpio2b registers, it should look like this

00000200 00000001

then modifiy the device tree, change the mode of the otp-out pin from 1 to 2 and then reboot and check the registers again, they will look like this

00000200 00000002

now if you've been playing along, you will be aware that the second 32 bit chunk represents the high-side of gpio2b, which is only pin 7, but otp-out is pin 5, which resides in the first 32 bit chunk which represents the low-side of gpio2b

you can try this on any rk3328 based device

*** PROOF OF CONCEPT ALERT ***

View: https://bugzilla.kernel.org/show_bug.cgi?id=217334#c6
You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)


  parent reply	other threads:[~2023-05-19  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 16:12 rockchip rk3328 pinctrl unable to change gpio function of pins defined in rk3328_mux_recalced_data Kernel.org Bugbot
2023-04-19 16:12 ` Kernel.org Bugbot
2023-04-21 10:32 ` Kernel.org Bugbot
2023-04-21 10:43 ` Kernel.org Bugbot
2023-04-22 21:08 ` rockchip rk3328 pinctrl overflow Kernel.org Bugbot
2023-05-04 11:01 ` [PATCH] pinctrl: rockchip: rk3328: rk3328_mux_recalced_data: fix bit alignment Kernel.org Bugbot
2023-05-19  7:10 ` Kernel.org Bugbot [this message]
2023-06-07 11:55 ` https://bugzilla.kernel.org/show_bug.cgi?id=217334 arm arm64 aarch64 pinctrl rockchip rk3328 rk3328_mux_recalced_data bits overflowing Kernel.org Bugbot
2023-06-28  9:20 ` rk3328_mux_recalced_data OVERFLOW noncontiguous CARRIED bits Kernel.org Bugbot
2023-08-27 14:52 ` linux rockchip gpio2b4 (gpio2b5) gpio2b7 broken GRF_GPIO2BL_IOMUX GRF_GPIO2BH_IOMUX 2bits 3bits pinctrl rk3328_mux_recalced_data (a fix exists, for a commiter brave enough to commit it) Kernel.org Bugbot
2024-01-29 14:15 ` Kernel.org Bugbot
2024-01-30 18:55 ` Kernel.org Bugbot
2024-01-31 21:05 ` inux ockchip pio2b4 (pio2b5) pio2b7 roken GRF_PIO2BL_IOMUX GRF_PIO2BH_IOMUX 2bits 3bits pinctrl rk332_mux_ecalced_data Kernel.org Bugbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230519-b217334c6-f82053afb53a@bugzilla.kernel.org \
    --to=bugbot@kernel.org \
    --cc=bugs@lists.linux.dev \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).