bugs.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Kernel.org Bugbot" <bugbot@kernel.org>
To: linux-rockchip@lists.infradead.org, heiko@sntech.de,
	 bugs@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: linux rockchip gpio2b4 (gpio2b5) gpio2b7 broken GRF_GPIO2BL_IOMUX GRF_GPIO2BH_IOMUX 2bits 3bits pinctrl rk3328_mux_recalced_data (a fix exists, for a commiter brave enough to commit it)
Date: Tue, 30 Jan 2024 18:55:19 +0000	[thread overview]
Message-ID: <20240130-b217334c11-7182e5f921f4@bugzilla.kernel.org> (raw)
In-Reply-To: <20230419-b217334c0-3101f9f4b426@bugzilla.kernel.org>

antwain.schneider added an attachment on Kernel.org Bugzilla:

Created attachment 305795
a program written in c that can be compiled and ran on a rk3328-based device to illustrate the problem which is bad

this program dumps the bits set in the grf for 2bl and 2bh

in comment 7, the otp-out thing is still vital to prove this point without extensive dtb modification

i've got it down to this
fdtput -t x /boot/efi/rockchip/rk3328-roc-cc.dtb /pinctrl/tsadc/otp-out rockchip,pins 02 0d 02 5a
what's being changed in this line is the mode (from 1 to 2) of gpio2b5

otp-out in the rk3328.dtsi is
                                rockchip,pins = <2 RK_PB5 1 &pcfg_pull_none>;
which when dumped by dtc is
                                rockchip,pins = <0x02 0x0d 0x01 0x5a>;
0x5a is the phandle for pcfg_pull_none for me currently, your value may vary
notice that it's using gpio2b5 which exists but doesn't have a listing in chapter 3 of the trm but is described elsewhere in the document


1 run the program and save output
2 fdtput the dtb and reboot
3 run the program again and compare outputs, and notice how the completely wrong register changed

File: poc.c (text/x-csrc)
Size: 1.53 KiB
Link: https://bugzilla.kernel.org/attachment.cgi?id=305795
---
a program written in c that can be compiled and ran on a rk3328-based device to illustrate the problem which is bad

You can reply to this message to join the discussion.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)


  parent reply	other threads:[~2024-01-30 18:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 16:12 rockchip rk3328 pinctrl unable to change gpio function of pins defined in rk3328_mux_recalced_data Kernel.org Bugbot
2023-04-19 16:12 ` Kernel.org Bugbot
2023-04-21 10:32 ` Kernel.org Bugbot
2023-04-21 10:43 ` Kernel.org Bugbot
2023-04-22 21:08 ` rockchip rk3328 pinctrl overflow Kernel.org Bugbot
2023-05-04 11:01 ` [PATCH] pinctrl: rockchip: rk3328: rk3328_mux_recalced_data: fix bit alignment Kernel.org Bugbot
2023-05-19  7:10 ` Kernel.org Bugbot
2023-06-07 11:55 ` https://bugzilla.kernel.org/show_bug.cgi?id=217334 arm arm64 aarch64 pinctrl rockchip rk3328 rk3328_mux_recalced_data bits overflowing Kernel.org Bugbot
2023-06-28  9:20 ` rk3328_mux_recalced_data OVERFLOW noncontiguous CARRIED bits Kernel.org Bugbot
2023-08-27 14:52 ` linux rockchip gpio2b4 (gpio2b5) gpio2b7 broken GRF_GPIO2BL_IOMUX GRF_GPIO2BH_IOMUX 2bits 3bits pinctrl rk3328_mux_recalced_data (a fix exists, for a commiter brave enough to commit it) Kernel.org Bugbot
2024-01-29 14:15 ` Kernel.org Bugbot
2024-01-30 18:55 ` Kernel.org Bugbot [this message]
2024-01-31 21:05 ` inux ockchip pio2b4 (pio2b5) pio2b7 roken GRF_PIO2BL_IOMUX GRF_PIO2BH_IOMUX 2bits 3bits pinctrl rk332_mux_ecalced_data Kernel.org Bugbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130-b217334c11-7182e5f921f4@bugzilla.kernel.org \
    --to=bugbot@kernel.org \
    --cc=bugs@lists.linux.dev \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).