From: "Stefan Mätje" <Stefan.Maetje@esd.eu>
To: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>,
"mkl@pengutronix.de" <mkl@pengutronix.de>
Subject: Re: [RFC PATCH v4 3/4] iplink_can: print brp and dbrp bittiming variables
Date: Wed, 7 Jul 2021 16:33:58 +0000 [thread overview]
Message-ID: <0f23c1e5e4bcfcc7d8077c859788031b0e7214b4.camel@esd.eu> (raw)
In-Reply-To: <20210628154402.1176099-4-mailhol.vincent@wanadoo.fr>
Am Dienstag, den 29.06.2021, 00:44 +0900 schrieb Vincent Mailhol:
> Report the value of the bit-rate prescaler (brp) for both the nominal
> and the data bittiming.
>
> Currently, only the constant brp values (brp_{min,max,inc}) are being
> reported. Also, brp is the only member of struct can_bittiming not
> being reported.
>
> Although brp is not used as an input for bittiming calculation, it
> makes sense to output it.
>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
I think it is a good idea to display both brp and dbrp values because it makes
the displayed bitrate settings complete. Even if it could be calculated from the
displayed clock and tq values.
> ---
> ip/iplink_can.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ip/iplink_can.c b/ip/iplink_can.c
> index 9dbe6afd..00f585c6 100644
> --- a/ip/iplink_can.c
> +++ b/ip/iplink_can.c
> @@ -347,6 +347,7 @@ static void can_print_opt(struct link_util *lu, FILE *f,
> struct rtattr *tb[])
> print_uint(PRINT_ANY, "phase_seg2", "phase-seg2 %u ",
> bt->phase_seg2);
> print_uint(PRINT_ANY, "sjw", " sjw %u", bt->sjw);
> + print_uint(PRINT_ANY, "brp", " brp %u", bt->brp);
> close_json_object();
> }
>
> @@ -421,6 +422,7 @@ static void can_print_opt(struct link_util *lu, FILE *f,
> struct rtattr *tb[])
> print_uint(PRINT_ANY, "phase_seg2", " dphase-seg2 %u",
> dbt->phase_seg2);
> print_uint(PRINT_ANY, "sjw", " dsjw %u", dbt->sjw);
> + print_uint(PRINT_ANY, "brp", " dbrp %u", dbt->brp);
> close_json_object();
> }
>
next prev parent reply other threads:[~2021-07-07 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:43 [RFC PATCH v4 0/4] iplink_can: cleaning, fixes and adding TDC support Vincent Mailhol
2021-06-28 15:43 ` [RFC PATCH v4 1/4] iplink_can: fix configuration ranges in print_usage() Vincent Mailhol
2021-06-28 15:44 ` [RFC PATCH v4 2/4] iplink_can: use PRINT_ANY to factorize code and fix signedness Vincent Mailhol
2021-06-28 15:44 ` [RFC PATCH v4 3/4] iplink_can: print brp and dbrp bittiming variables Vincent Mailhol
2021-07-07 16:33 ` Stefan Mätje [this message]
2021-07-09 12:17 ` Vincent MAILHOL
2021-08-09 12:27 ` Stefan Mätje
2021-06-28 15:44 ` [RFC PATCH v4 4/4] iplink_can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-07-07 16:21 ` Stefan Mätje
2021-07-09 13:32 ` Vincent MAILHOL
2021-08-09 14:44 ` Stefan Mätje
2021-08-14 9:51 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f23c1e5e4bcfcc7d8077c859788031b0e7214b4.camel@esd.eu \
--to=stefan.maetje@esd.eu \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).