From: Rob Herring <robh@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-can@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] dt-bindings: clock: imx5: fix example
Date: Wed, 11 Nov 2020 17:09:55 -0600 [thread overview]
Message-ID: <20201111230955.GA2214526@bogus> (raw)
In-Reply-To: <20201111213548.1621094-1-mkl@pengutronix.de>
On Wed, Nov 11, 2020 at 10:35:48PM +0100, Marc Kleine-Budde wrote:
> Since commit:
>
> 0e030a373df3 ("can: flexcan: fix endianess detection")
>
> the fsl,imx53-flexcan isn't compatible with the fsl,p1010-flexcan any more. As
> the former accesses the IP core in Little Endian mode and the latter uses Big
> Endian mode.
>
> With the conversion of the flexcan DT bindings to yaml, the dt_binding_check
> this throws the following error:
>
> Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['fsl,imx53-flexcan', 'fsl,imx25-flexcan'] is too long
> Additional items are not allowed ('fsl,imx25-flexcan' was unexpected)
> 'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
> 'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
> 'fsl,imx6q-flexcan' was expected
> 'fsl,lx2160ar1-flexcan' was expected
> From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
>
> The error is fixed by removing the "fsl,p1010-flexcan" compatible (which turned
> out the be incompatible) from the binding example.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: devicetree@vger.kernel.org
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Documentation/devicetree/bindings/clock/imx5-clock.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx5-clock.yaml b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> index 4d9e7c73dce9..155379c3c41e 100644
> --- a/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx5-clock.yaml
> @@ -57,7 +57,7 @@ examples:
> };
>
> can@53fc8000 {
> - compatible = "fsl,imx53-flexcan", "fsl,p1010-flexcan";
> + compatible = "fsl,imx53-flexcan";
But you just added that "fsl,imx53-flexcan" has a fallback of
'fsl,imx25-flexcan'.
Looks like "fsl,imx53-flexcan" alone needs to be dropped. Decide the one
way that is valid please. I've dropped the schema change until sorted
out.
Rob
next prev parent reply other threads:[~2020-11-12 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 21:35 [PATCH] dt-bindings: clock: imx5: fix example Marc Kleine-Budde
2020-11-11 23:09 ` Rob Herring [this message]
2020-11-13 15:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111230955.GA2214526@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).