From: Rob Herring <robh@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Aswath Govindraju <a-govindraju@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Sriram Dash <sriram.dash@samsung.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
Date: Mon, 12 Apr 2021 12:49:56 -0500 [thread overview]
Message-ID: <20210412174956.GA4049952@robh.at.kernel.org> (raw)
In-Reply-To: <f9b04d93-c249-970e-3721-50eb268a948f@pengutronix.de>
On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote:
> On 4/9/21 3:40 PM, Aswath Govindraju wrote:
> > Add binding documentation for TI TCAN104x CAN transceivers.
> >
> > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> > ---
> > .../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > new file mode 100644
> > index 000000000000..4abfc30a97d0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/phy/ti,tcan104x-can.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: TCAN104x CAN TRANSCEIVER PHY
> > +
> > +maintainers:
> > + - Aswath Govindraju <a-govindraju@ti.com>
> > +
> > +properties:
> > + $nodename:
> > + pattern: "^tcan104x-phy"
> > +
> > + compatible:
> > + enum:
> > + - ti,tcan1042
> > + - ti,tcan1043
>
> Can you create a generic standby only and a generic standby and enable transceiver?
As a fallback compatible fine, but no generic binding please. A generic
binding can't describe any timing requirements between the 2 GPIO as
well as supplies when someone wants to add those (and they will).
>
> > +
> > + '#phy-cells':
> > + const: 0
> > +
> > + standby-gpios:
> > + description:
> > + gpio node to toggle standby signal on transceiver
> > + maxItems: 1
> > +
> > + enable-gpios:
> > + description:
> > + gpio node to toggle enable signal on transceiver
> > + maxItems: 1
> > +
> > + max-bitrate:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + max bit rate supported in bps
We already have 'max-speed' for serial devices, use that.
> > + minimum: 1
> > +
> > +required:
> > + - compatible
> > + - '#phy-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + transceiver1: tcan104x-phy {
> > + compatible = "ti,tcan1043";
> > + #phy-cells = <0>;
> > + max-bitrate = <5000000>;
> > + standby-gpios = <&wakeup_gpio1 16 GPIO_ACTIVE_LOW>;
> > + enable-gpios = <&main_gpio1 67 GPIO_ACTIVE_LOW>;
> > + };
> >
>
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
next prev parent reply other threads:[~2021-04-12 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 13:40 [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers Aswath Govindraju
2021-04-09 13:40 ` [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x " Aswath Govindraju
2021-04-12 10:19 ` Marc Kleine-Budde
2021-04-12 17:49 ` Rob Herring [this message]
2021-04-13 7:41 ` Marc Kleine-Budde
2021-04-13 13:15 ` Rob Herring
2021-04-14 12:53 ` Aswath Govindraju
2021-04-09 13:40 ` [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju
2021-04-12 10:18 ` Marc Kleine-Budde
2021-04-14 6:24 ` Aswath Govindraju
2021-04-14 6:57 ` Marc Kleine-Budde
2021-04-09 13:40 ` [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy Aswath Govindraju
2021-04-12 17:51 ` Rob Herring
2021-04-14 6:49 ` Aswath Govindraju
2021-04-14 13:24 ` Rob Herring
2021-04-09 13:40 ` [PATCH 4/4] can: m_can_platform: Add support for transceiver " Aswath Govindraju
2021-04-12 10:22 ` Marc Kleine-Budde
2021-04-14 6:59 ` [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412174956.GA4049952@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a-govindraju@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=sriram.dash@samsung.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).