linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Menschel <menschel.p@posteo.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/3] can-isotp: Add symbolic error message to isotp_module_init()
Date: Tue, 27 Apr 2021 05:21:48 +0000	[thread overview]
Message-ID: <20210427052150.2308-3-menschel.p@posteo.de> (raw)
In-Reply-To: <20210427052150.2308-1-menschel.p@posteo.de>

This patch adds the value of err with format %pe
to the already existing error message.

Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
---
 net/can/isotp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/can/isotp.c b/net/can/isotp.c
index 2c4f84fac..2075d8d9e 100644
--- a/net/can/isotp.c
+++ b/net/can/isotp.c
@@ -1433,7 +1433,7 @@ static __init int isotp_module_init(void)
 
 	err = can_proto_register(&isotp_can_proto);
 	if (err < 0)
-		pr_err("can: registration of isotp protocol failed\n");
+		pr_err("can: registration of isotp protocol failed %pe\n", ERR_PTR(err));
 
 	return err;
 }
-- 
2.17.1


  parent reply	other threads:[~2021-04-27  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  5:21 [PATCH v2 0/3] can-isotp: Add more comprehensive error messages Patrick Menschel
2021-04-27  5:21 ` [PATCH v2 1/3] can-isotp: Change error format from decimal to symbolic error names Patrick Menschel
2021-04-27  5:21 ` Patrick Menschel [this message]
2021-04-27  5:21 ` [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too small Patrick Menschel
2021-04-27  7:16   ` Marc Kleine-Budde
2021-04-27 13:13     ` Patrick Menschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427052150.2308-3-menschel.p@posteo.de \
    --to=menschel.p@posteo.de \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).