From: Aswath Govindraju <a-govindraju@ti.com>
To: unlisted-recipients:; (no To-header on input)
Cc: <linux-can@vger.kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v6 0/3] CAN TRANSCEIVER: Add support for CAN transceivers
Date: Mon, 10 May 2021 10:40:02 +0530 [thread overview]
Message-ID: <20210510051006.11393-1-a-govindraju@ti.com> (raw)
The following series of patches add support for CAN transceivers.
TCAN1042 has a standby signal that needs to be pulled high for
sending/receiving messages[1]. TCAN1043 has a enable signal along with
standby signal that needs to be pulled up for sending/receiving
messages[2], and other combinations of the two lines can be used to put the
transceiver in different states to reduce power consumption. On boards
like the AM654-idk and J721e-evm these signals are controlled using gpios.
Patch 1 rewords the comment that restricts max_link_rate attribute to have
units of Mbps.
Patch 2 models the transceiver as a phy device tree node with properties
for max bit rate supported, gpio properties for indicating gpio pin numbers
to which standby and enable signals are connected.
Patch 2 adds a generic driver to support CAN transceivers.
changes since v5:
- Updated copyright year to 2021 in patch 3
- Rebased the series on top of latest linux next
- picked-up Marc Kleine-Budde's acked-by
changes since v4:
- In patch 3 made the correction from mcan to CAN, in Kconfig help
changes since v3:
- dropped patch 2(in v3)
- changed the node name property in patch 3(in v3)
- picked up Rob Herring's reviewed-by for patch 3(in v3)
changes since v2:
- dropped 5 and 6 patches and to be sent via linux-can-next
- added static keyword for can_transceiver_phy_probe()
- changed enable gpio example to active high in patch 3
- Rearranged the file names in alphabetical order in Makefile
and MAINTAINERS file
changes since v1:
- Added patch 1 (in v2) that rewords the comment that restrict
max_link_rate attribute to have units of Mbps.
- Added patch 2 (in v2) that adds an API for
devm_of_phy_optional_get_by_index
- Patch 1 (in v1)
- updated MAINTAINERS file
- Patch 2 (in v1)
- replaced m_can with CAN to make the driver independent of CAN driver
- Added prefix CAN_TRANSCEIVER for EN_PRESENT and STB_PRESENT
- Added new line before return statements in power_on() and power_off
- Added error handling patch for devm_kzalloc()
- used the max_link_rate attribute directly instead of dividing it by
1000000
- removed the spaces before GPIOD_OUT_LOW in devm_gpiod_get()
- Corrected requested value for standby-gpios to GPIOD_OUT_HIGH
- Updated MAINTAINERS file
- Patch 3 (in v1)
- replaced minItems with maxItems
- Removed phy-names property as there is only one phy
- Patch 4 (in v1)
- replaced dev_warn with dev_info when no transceiver is found
- Added struct phy * field in m_can_classdev struct
- moved phy_power_on and phy_power_off to m_can_open and m_can_close
respectively
- Moved the check for max_bit_rate to generice transceiver driver
[1] - https://www.ti.com/lit/ds/symlink/tcan1042h.pdf
[2] - https://www.ti.com/lit/ds/symlink/tcan1043-q1.pdf
Aswath Govindraju (3):
phy: core: Reword the comment specifying the units of max_link_rate to
be Mbps
dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers
phy: phy-can-transceiver: Add support for generic CAN transceiver
driver
.../bindings/phy/ti,tcan104x-can.yaml | 56 +++++++
MAINTAINERS | 2 +
drivers/phy/Kconfig | 9 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-can-transceiver.c | 146 ++++++++++++++++++
include/linux/phy/phy.h | 2 +-
6 files changed, 215 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
create mode 100644 drivers/phy/phy-can-transceiver.c
--
2.17.1
next reply other threads:[~2021-05-10 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 5:10 Aswath Govindraju [this message]
2021-05-10 5:10 ` [PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps Aswath Govindraju
2021-05-31 7:18 ` Vinod Koul
2021-05-31 8:34 ` Aswath Govindraju
2021-06-11 12:42 ` Aswath Govindraju
2021-06-11 13:01 ` Kishon Vijay Abraham I
2021-06-14 5:50 ` Vinod Koul
2021-05-10 5:10 ` [PATCH v6 2/3] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers Aswath Govindraju
2021-05-10 5:10 ` [PATCH v6 3/3] phy: phy-can-transceiver: Add support for generic CAN transceiver driver Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510051006.11393-1-a-govindraju@ti.com \
--to=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=mkl@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).