From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: wg@grandegger.com, davem@davemloft.net,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+57281c762a3922e14dfe@syzkaller.appspotmail.com
Subject: Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb
Date: Tue, 15 Jun 2021 09:33:19 +0200 [thread overview]
Message-ID: <20210615073319.fvwilowhsztr5hd6@pengutronix.de> (raw)
In-Reply-To: <20210609215833.30393-1-paskripkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On 10.06.2021 00:58:33, Pavel Skripkin wrote:
> Syzbot reported memory leak in SocketCAN driver
> for Microchip CAN BUS Analyzer Tool. The problem
> was in unfreed usb_coherent.
>
> In mcba_usb_start() 20 coherent buffers are allocated
> and there is nothing, that frees them:
>
> 1) In callback function the urb is resubmitted and that's all
> 2) In disconnect function urbs are simply killed, but
> URB_FREE_BUFFER is not set (see mcba_usb_start)
> and this flag cannot be used with coherent buffers.
>
> Fail log:
> [ 1354.053291][ T8413] mcba_usb 1-1:0.0 can0: device disconnected
> [ 1367.059384][ T8420] kmemleak: 20 new suspected memory leaks (see /sys/kernel/debug/kmem)
>
> So, all allocated buffers should be freed with usb_free_coherent()
> explicitly
>
> NOTE:
> The same pattern for allocating and freeing coherent buffers
> is used in drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
>
> Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
> Reported-and-tested-by: syzbot+57281c762a3922e14dfe@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied to linux-can/testing.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-15 7:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 21:58 [PATCH] can: mcba_usb: fix memory leak in mcba_usb Pavel Skripkin
2021-06-15 7:33 ` Marc Kleine-Budde [this message]
2021-07-25 7:42 Yasushi SHOJI
2021-07-25 8:12 ` Pavel Skripkin
2021-07-25 9:42 ` Marc Kleine-Budde
2021-07-25 10:18 ` Pavel Skripkin
2021-07-25 10:44 ` Yasushi SHOJI
2021-07-25 16:27 ` Marc Kleine-Budde
2021-07-25 16:35 ` Yasushi SHOJI
2021-07-26 9:31 ` Marc Kleine-Budde
2021-07-26 9:34 ` Marc Kleine-Budde
2021-07-26 10:43 ` Yasushi SHOJI
2021-07-26 10:42 ` Yasushi SHOJI
2021-07-26 11:17 ` Marc Kleine-Budde
2021-07-27 2:19 ` Yasushi SHOJI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615073319.fvwilowhsztr5hd6@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+57281c762a3922e14dfe@syzkaller.appspotmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).