From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
wg@grandegger.com, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] net: can: add missing urb->transfer_dma initialization
Date: Sun, 25 Jul 2021 18:30:39 +0200 [thread overview]
Message-ID: <20210725163039.kyugkdmyn5p3o5r2@pengutronix.de> (raw)
In-Reply-To: <CAELBRWKfyOBanMBteO=LpL9R1QMp97zTYtKY689jeR2gDOa_Gw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On 25.07.2021 22:27:37, Yasushi SHOJI wrote:
> Hi Pavel,
>
> I've tested this patch on top of v5.14-rc2. All good.
>
> Tested-by: Yasushi SHOJI <yashi@spacecubics.com>
>
> Some nitpicks.
>
> On Sun, Jul 25, 2021 at 7:36 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> >
> > Yasushi reported, that his Microchip CAN Analyzer stopped working since
> > commit 91c02557174b ("can: mcba_usb: fix memory leak in mcba_usb").
> > The problem was in missing urb->transfer_dma initialization.
> >
> > In my previous patch to this driver I refactored mcba_usb_start() code to
> > avoid leaking usb coherent buffers. To achive it, I passed local stack
>
> achieve
>
> > variable to usb_alloc_coherent() and then saved it to private array to
> > correctly free all coherent buffers on ->close() call. But I forgot to
> > inialize urb->transfer_dma with variable passed to usb_alloc_coherent().
>
> initialize
Fixed while applying.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-25 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 7:42 [PATCH] can: mcba_usb: fix memory leak in mcba_usb Yasushi SHOJI
2021-07-25 8:12 ` Pavel Skripkin
2021-07-25 9:42 ` Marc Kleine-Budde
2021-07-25 10:18 ` Pavel Skripkin
2021-07-25 10:36 ` [PATCH] net: can: add missing urb->transfer_dma initialization Pavel Skripkin
2021-07-25 13:27 ` Yasushi SHOJI
2021-07-25 16:30 ` Marc Kleine-Budde [this message]
2021-07-25 10:44 ` [PATCH] can: mcba_usb: fix memory leak in mcba_usb Yasushi SHOJI
2021-07-25 16:27 ` Marc Kleine-Budde
2021-07-25 16:35 ` Yasushi SHOJI
2021-07-26 9:31 ` Marc Kleine-Budde
2021-07-26 9:34 ` Marc Kleine-Budde
2021-07-26 10:43 ` Yasushi SHOJI
2021-07-26 10:42 ` Yasushi SHOJI
2021-07-26 11:17 ` Marc Kleine-Budde
2021-07-27 2:19 ` Yasushi SHOJI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725163039.kyugkdmyn5p3o5r2@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=wg@grandegger.com \
--cc=yashi@spacecubics.com \
--cc=yasushi.shoji@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).