From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: Angelo Dureghello <angelo@kernel-space.org>
Subject: Re: [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization
Date: Wed, 28 Jul 2021 09:56:59 +0200 [thread overview]
Message-ID: <20210728075659.6npegwljokksjtjy@pengutronix.de> (raw)
In-Reply-To: <20210728075428.1493568-1-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
The subject is obviously wrong, fixed to "flexcan_clks_enable()".
Marc
On 28.07.2021 09:54:28, Marc Kleine-Budde wrote:
> This patch adds the missing initialization of the "err" variable in
> the flexcan_clks_enable() function.
>
> Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Angelo Dureghello <angelo@kernel-space.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/flexcan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 54ffb796a320..7734229aa078 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
>
> static int flexcan_clks_enable(const struct flexcan_priv *priv)
> {
> - int err;
> + int err = 0;
>
> if (priv->clk_ipg) {
> err = clk_prepare_enable(priv->clk_ipg);
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-28 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 7:54 [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization Marc Kleine-Budde
2021-07-28 7:56 ` Marc Kleine-Budde [this message]
2021-07-28 8:02 ` Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728075659.6npegwljokksjtjy@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=angelo@kernel-space.org \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).