From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Angelo Dureghello <angelo@kernel-space.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [linux-next:master 2764/5318] drivers/net/can/flexcan.c:666 flexcan_clks_enable() error: uninitialized symbol 'err'.
Date: Thu, 5 Aug 2021 14:22:24 +0300 [thread overview]
Message-ID: <202108050850.IaTFXHsB-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 2f73937c9aa561e2082839bc1a8efaac75d6e244
commit: d9cead75b1c66b4660b4f87ff339234042d7c6a5 [2764/5318] can: flexcan: add mcf5441x support
config: h8300-randconfig-m031-20210804 (attached as .config)
compiler: h8300-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/flexcan.c:666 flexcan_clks_enable() error: uninitialized symbol 'err'.
vim +/err +666 drivers/net/can/flexcan.c
ca10989632d882 Aisheng Dong 2018-11-30 650 static int flexcan_clks_enable(const struct flexcan_priv *priv)
ca10989632d882 Aisheng Dong 2018-11-30 651 {
ca10989632d882 Aisheng Dong 2018-11-30 652 int err;
ca10989632d882 Aisheng Dong 2018-11-30 653
d9cead75b1c66b Angelo Dureghello 2021-07-02 654 if (priv->clk_ipg) {
ca10989632d882 Aisheng Dong 2018-11-30 655 err = clk_prepare_enable(priv->clk_ipg);
ca10989632d882 Aisheng Dong 2018-11-30 656 if (err)
ca10989632d882 Aisheng Dong 2018-11-30 657 return err;
d9cead75b1c66b Angelo Dureghello 2021-07-02 658 }
ca10989632d882 Aisheng Dong 2018-11-30 659
d9cead75b1c66b Angelo Dureghello 2021-07-02 660 if (priv->clk_per) {
ca10989632d882 Aisheng Dong 2018-11-30 661 err = clk_prepare_enable(priv->clk_per);
ca10989632d882 Aisheng Dong 2018-11-30 662 if (err)
ca10989632d882 Aisheng Dong 2018-11-30 663 clk_disable_unprepare(priv->clk_ipg);
d9cead75b1c66b Angelo Dureghello 2021-07-02 664 }
Smatch is complaining that both priv->clk_ipg and priv->clk_per can be
false... Probably impossible in real life.
ca10989632d882 Aisheng Dong 2018-11-30 665
ca10989632d882 Aisheng Dong 2018-11-30 @666 return err;
ca10989632d882 Aisheng Dong 2018-11-30 667 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2021-08-05 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 11:22 Dan Carpenter [this message]
2021-08-05 11:45 ` [linux-next:master 2764/5318] drivers/net/can/flexcan.c:666 flexcan_clks_enable() error: uninitialized symbol 'err' Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108050850.IaTFXHsB-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=angelo@kernel-space.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).