From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
linux-can@vger.kernel.org, "Stefan Mätje" <stefan.maetje@esd.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] iplink_can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)
Date: Mon, 16 Aug 2021 10:12:05 +0200 [thread overview]
Message-ID: <20210816081205.7rjdskaui35f3jml@pengutronix.de> (raw)
In-Reply-To: <20210814101728.75334-5-mailhol.vincent@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]
On 14.08.2021 19:17:28, Vincent Mailhol wrote:
> At high bit rates, the propagation delay from the TX pin to the RX pin
> of the transceiver causes measurement errors: the sample point on the
> RX pin might occur on the previous bit.
>
> This issue is addressed in ISO 11898-1 section 11.3.3 "Transmitter
> delay compensation" (TDC).
>
> This patch brings command line support to nine TDC parameters which
> were recently added to the kernel's CAN netlink interface in order to
> implement TDC:
> - IFLA_CAN_TDC_TDCV_MIN: Transmitter Delay Compensation Value
> minimum value
> - IFLA_CAN_TDC_TDCV_MAX: Transmitter Delay Compensation Value
> maximum value
> - IFLA_CAN_TDC_TDCO_MIN: Transmitter Delay Compensation Offset
> minimum value
> - IFLA_CAN_TDC_TDCO_MAX: Transmitter Delay Compensation Offset
> maximum value
> - IFLA_CAN_TDC_TDCF_MIN: Transmitter Delay Compensation Filter
> window minimum value
> - IFLA_CAN_TDC_TDCF_MAX: Transmitter Delay Compensation Filter
> window maximum value
> - IFLA_CAN_TDC_TDCV: Transmitter Delay Compensation Value
> - IFLA_CAN_TDC_TDCO: Transmitter Delay Compensation Offset
> - IFLA_CAN_TDC_TDCF: Transmitter Delay Compensation Filter window
>
> All those new parameters are nested together into the attribute
> IFLA_CAN_TDC.
>
> A tdc-mode parameter allow to specify how to operate. Valid options
> are:
>
> * auto: the transmitter automatically measures TDCV. As such, TDCV
> values can not be manually provided. In this mode, the user must
> specify TDCO and may also specify TDCF if supported.
>
> * manual: Use the TDCV value provided by the user are used. In this
^^^^^ ^^^
singular plural
> mode, the user must specify both TDCV and TDCO and may also
> specify TDCF if supported.
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-16 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 10:17 [PATCH v5 0/4] iplink_can: cleaning, fixes and adding TDC support Vincent Mailhol
2021-08-14 10:17 ` [PATCH v5 1/4] iplink_can: fix configuration ranges in print_usage() and add unit Vincent Mailhol
2021-08-14 10:17 ` [PATCH v5 2/4] iplink_can: use PRINT_ANY to factorize code and fix signedness Vincent Mailhol
2021-08-14 10:17 ` [PATCH v5 3/4] iplink_can: print brp and dbrp bittiming variables Vincent Mailhol
2021-08-14 10:17 ` [PATCH v5 4/4] iplink_can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-08-14 11:14 ` Marc Kleine-Budde
2021-08-16 11:02 ` Vincent MAILHOL
2021-08-16 8:12 ` Marc Kleine-Budde [this message]
2021-08-16 10:40 ` Vincent MAILHOL
2021-08-16 13:51 ` Marc Kleine-Budde
2021-08-16 16:24 ` Vincent MAILHOL
2021-08-16 23:59 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816081205.7rjdskaui35f3jml@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=stefan.maetje@esd.eu \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).