From: Cai Huoqing <caihuoqing@baidu.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <linux-renesas-soc@vger.kernel.org>, <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: rcar_canfd: add __maybe_unused annotation to silence warning
Date: Mon, 6 Sep 2021 09:42:31 +0800 [thread overview]
Message-ID: <20210906014231.GA471@LAPTOP-UKSR4ENP.internal.baidu.com> (raw)
In-Reply-To: <20210904130701.641078-1-mkl@pengutronix.de>
+Cc: linux-renesas-soc@vger.kernel.org
On 04 Sep 21 15:07:01, Marc Kleine-Budde wrote:
> Since commit
>
> | dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver")
>
> the rcar_canfd driver can be compile tested on all architectures. On
> non OF enabled archs, or archs where OF is optional (and disabled in
> the .config) the compilation throws the following warning:
>
> | drivers/net/can/rcar/rcar_canfd.c:2020:34: warning: unused variable 'rcar_canfd_of_table' [-Wunused-const-variable]
> | static const struct of_device_id rcar_canfd_of_table[] = {
> | ^
>
> This patch fixes the warning by marking the variable
> rcar_canfd_of_table as __maybe_unused.
>
> Fixes: ac4224087312 ("can: rcar: Kconfig: Add helper dependency on COMPILE_TEST")
> Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver")
> Cc: Cai Huoqing <caihuoqing@baidu.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/rcar/rcar_canfd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
> index c47988d3674e..c05a7f60c0a8 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -2017,7 +2017,7 @@ static int __maybe_unused rcar_canfd_resume(struct device *dev)
> static SIMPLE_DEV_PM_OPS(rcar_canfd_pm_ops, rcar_canfd_suspend,
> rcar_canfd_resume);
>
> -static const struct of_device_id rcar_canfd_of_table[] = {
> +static const struct of_device_id rcar_canfd_of_table[] __maybe_unused = {
> { .compatible = "renesas,rcar-gen3-canfd", .data = (void *)RENESAS_RCAR_GEN3 },
> { .compatible = "renesas,rzg2l-canfd", .data = (void *)RENESAS_RZG2L },
> { }
> --
> 2.33.0
>
>
prev parent reply other threads:[~2021-09-06 1:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 13:07 [PATCH] can: rcar_canfd: add __maybe_unused annotation to silence warning Marc Kleine-Budde
2021-09-06 1:42 ` Cai Huoqing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906014231.GA471@LAPTOP-UKSR4ENP.internal.baidu.com \
--to=caihuoqing@baidu.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).