From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: peak_pci: Fix UAF in peak_pci_remove
Date: Sun, 17 Oct 2021 14:29:43 +0200 [thread overview]
Message-ID: <20211017122943.q4ic472sigcrk4l2@pengutronix.de> (raw)
In-Reply-To: <1634192913-15639-1-git-send-email-zheyuma97@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On 14.10.2021 06:28:33, Zheyu Ma wrote:
> When remove the module peek_pci, referencing 'chan' again after
> releasing 'dev' will cause UAF.
>
> Fix this by releasing 'dev' later.
>
> The following log reveals it:
>
> [ 35.961814 ] BUG: KASAN: use-after-free in peak_pci_remove+0x16f/0x270 [peak_pci]
> [ 35.963414 ] Read of size 8 at addr ffff888136998ee8 by task modprobe/5537
> [ 35.965513 ] Call Trace:
> [ 35.965718 ] dump_stack_lvl+0xa8/0xd1
> [ 35.966028 ] print_address_description+0x87/0x3b0
> [ 35.966420 ] kasan_report+0x172/0x1c0
> [ 35.966725 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
> [ 35.967137 ] ? trace_irq_enable_rcuidle+0x10/0x170
> [ 35.967529 ] ? peak_pci_remove+0x16f/0x270 [peak_pci]
> [ 35.967945 ] __asan_report_load8_noabort+0x14/0x20
> [ 35.968346 ] peak_pci_remove+0x16f/0x270 [peak_pci]
> [ 35.968752 ] pci_device_remove+0xa9/0x250
>
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Applied to linux-can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-10-17 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 6:28 [PATCH] can: peak_pci: Fix UAF in peak_pci_remove Zheyu Ma
2021-10-17 12:29 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017122943.q4ic472sigcrk4l2@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).