From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Matej Vasilevski <matej.vasilevski@seznam.cz>
Cc: devicetree@vger.kernel.org, linux-can@vger.kernel.org,
pisa@cmp.felk.cvut.cz, ondrej.ille@gmail.com,
netdev@vger.kernel.org, martin.jerabek01@gmail.com
Subject: Re: [RFC PATCH 1/3] can: ctucanfd: add HW timestamps to RX and error CAN frames
Date: Sat, 14 May 2022 22:13:31 +0200 [thread overview]
Message-ID: <20220514201331.xv5ofxbzrv5ti3bi@pengutronix.de> (raw)
In-Reply-To: <20220514091741.GA203806@hopium>
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
On 14.05.2022 11:18:08, Matej Vasilevski wrote:
> > > + timecounter_init(&priv->tc, &priv->cc, 0);
> >
> > You here set the offset of the HW clock to 1.1.1970. The mcp driver sets
> > the offset to current time. I think it's convenient to have the current
> > time here....What do you think.
>
> I actually searched in the mailing list and read your conversation with
> Vincent on timestamps starting from 0 or synced to current time.
> https://lore.kernel.org/linux-can/CAMZ6RqL+n4tRy-B-W+fzW5B3QV6Bedrko57pU_0TE023Oxw_5w@mail.gmail.com/
Thanks for looking up that discussion. Back than I was arguing for the
start from 0, but in the mean time I added TS support for the mcp251xfd,
which starts with the current time :)
> Then I discussed it with Pavel Pisa and he requested to start from 0.
> Reasons are that system time can change (NTP, daylight saving time,
> user settings etc.), so when it starts from 0 it is clear that it is
> "timestamp time".
>
> Are there a lot of CAN drivers synced to system time? I think this would
> be a good argument for syncing, to keep things nice and cohesive in
> the CAN subsystem.
>
> Overall I wouldn't want to block this patch over such a minutiae.
ACK
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-14 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 23:27 [RFC] can: ctucanfd: RX timestamping implementation Matej Vasilevski
2022-05-12 23:27 ` [RFC PATCH 1/3] can: ctucanfd: add HW timestamps to RX and error CAN frames Matej Vasilevski
2022-05-13 11:41 ` Marc Kleine-Budde
2022-05-13 19:02 ` Pavel Pisa
2022-05-14 19:36 ` Marc Kleine-Budde
2022-05-14 9:18 ` Matej Vasilevski
2022-05-14 20:13 ` Marc Kleine-Budde [this message]
2022-05-14 20:31 ` Marc Kleine-Budde
2022-05-12 23:27 ` [RFC PATCH 2/3] dt-bindings: can: ctucanfd: add properties for HW timestamping Matej Vasilevski
2022-05-16 16:02 ` Rob Herring
2022-05-16 16:34 ` Marc Kleine-Budde
2022-05-16 19:21 ` Pavel Pisa
2022-05-12 23:27 ` [RFC PATCH 3/3] doc: ctucanfd: RX frames timestamping for platform devices Matej Vasilevski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514201331.xv5ofxbzrv5ti3bi@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=martin.jerabek01@gmail.com \
--cc=matej.vasilevski@seznam.cz \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).