From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>
Subject: [PATCH net-next 1/9] can: raw: raw_sendmsg(): remove not needed setting of skb->sk
Date: Mon, 16 May 2022 22:26:17 +0200 [thread overview]
Message-ID: <20220516202625.1129281-2-mkl@pengutronix.de> (raw)
In-Reply-To: <20220516202625.1129281-1-mkl@pengutronix.de>
The skb in raw_sendmsg() is allocated with sock_alloc_send_skb(),
which subsequently calls sock_alloc_send_pskb() -> skb_set_owner_w(),
which assigns "skb->sk = sk".
This patch removes the not needed setting of skb->sk.
Link: https://lore.kernel.org/all/20220502091946.1916211-2-mkl@pengutronix.de
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
net/can/raw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/can/raw.c b/net/can/raw.c
index b7dbb57557f3..1a68efae43c2 100644
--- a/net/can/raw.c
+++ b/net/can/raw.c
@@ -820,7 +820,6 @@ static int raw_sendmsg(struct socket *sock, struct msghdr *msg, size_t size)
skb_setup_tx_timestamp(skb, sk->sk_tsflags);
skb->dev = dev;
- skb->sk = sk;
skb->priority = sk->sk_priority;
err = can_send(skb, ro->loopback);
base-commit: d887ae3247e022183f244cb325dca1dfbd0a9ed0
--
2.35.1
next prev parent reply other threads:[~2022-05-16 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 20:26 [PATCH net-next 0/9] pull-request: can-next 2022-05-16 Marc Kleine-Budde
2022-05-16 20:26 ` Marc Kleine-Budde [this message]
2022-05-17 0:10 ` [PATCH net-next 1/9] can: raw: raw_sendmsg(): remove not needed setting of skb->sk patchwork-bot+netdevbpf
2022-05-16 20:26 ` [PATCH net-next 2/9] can: raw: add support for SO_TXTIME/SCM_TXTIME Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 3/9] can: isotp: add support for transmission without flow control Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 4/9] can: isotp: isotp_bind(): return -EINVAL on incorrect CAN ID formatting Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 5/9] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 6/9] can: slcan: slc_xmit(): use can_dropped_invalid_skb() instead of manual check Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 7/9] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 8/9] dt-bindings: can: ctucanfd: include common CAN controller bindings Marc Kleine-Budde
2022-05-16 20:26 ` [PATCH net-next 9/9] docs: ctucanfd: Use 'kernel-figure' directive instead of 'figure' Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516202625.1129281-2-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).