From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Max Staudt <max@enpas.org>
Cc: Vincent Mailhol <vincent.mailhol@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Sat, 11 Jun 2022 15:31:32 +0200 [thread overview]
Message-ID: <20220611133132.bqxlnqwp53qq6qor@pengutronix.de> (raw)
In-Reply-To: <20220611151649.5a9c5676.max@enpas.org>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On 11.06.2022 15:16:49, Max Staudt wrote:
> On Sat, 4 Jun 2022 00:47:10 +0900
> Vincent Mailhol <vincent.mailhol@gmail.com> wrote:
>
> > > > +#define ELM327_CAN_CONFIG_SEND_SFF 0x8000
> > > > +#define ELM327_CAN_CONFIG_VARIABLE_DLC 0x4000
> > > > +#define ELM327_CAN_CONFIG_RECV_BOTH_SFF_EFF 0x2000
> > > > +#define ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7 0x1000
> >
> > This ELM327_CAN_CONFIG_BAUDRATE_MULT_8_7 macro is not used.
>
> True. It does document a flag in the ELM327 configuration registers
> though, and it was originally meant for adding 7/8 bitrates (e.g. 87500
> as a companion to 100000). I never got around to implementing those
> bitrates, though.
>
> I find opportunistic documentation helpful for future reference and
> to give casual readers hints - can I leave it in there anyway, or is it
> deemed an eyesore?
IMHO leave it in the driver.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-11 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 21:35 [PATCH v7] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-06-03 15:12 ` Vincent Mailhol
2022-06-03 15:47 ` Vincent Mailhol
2022-06-11 13:16 ` Max Staudt
2022-06-11 13:31 ` Marc Kleine-Budde [this message]
2022-06-11 13:15 ` Max Staudt
2022-06-11 13:36 ` Marc Kleine-Budde
2022-06-11 14:17 ` Max Staudt
2022-06-11 14:20 ` Marc Kleine-Budde
2022-06-11 14:42 ` Vincent Mailhol
2022-06-11 15:28 ` Marc Kleine-Budde
2022-06-11 16:41 ` Max Staudt
2022-06-12 1:33 ` Vincent Mailhol
2022-06-12 12:03 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220611133132.bqxlnqwp53qq6qor@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@enpas.org \
--cc=oneukum@suse.com \
--cc=vincent.mailhol@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).