From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jimmy Assarsson <extja@kvaser.com>
Cc: linux-can@vger.kernel.org,
Jimmy Assarsson <jimmyassarsson@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression
Date: Mon, 4 Jul 2022 15:07:42 +0200 [thread overview]
Message-ID: <20220704130742.aeczqfbfnwemb7ax@pengutronix.de> (raw)
In-Reply-To: <20220603083820.800246-1-extja@kvaser.com>
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On 03.06.2022 10:38:17, Jimmy Assarsson wrote:
> When fixing the CAN clock frequency,
> fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"),
> I introduced a regression.
>
> For Leaf devices based on M32C, the firmware expects bittiming parameters
> calculated for 16MHz clock. Regardless of the actual clock frequency.
>
> This regression affects M32C based Leaf devices with non-16MHz clock.
>
> Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits
> are different depending on which firmware/device being used.
>
> Once merged to mainline, I'll backport these fixes for the stable kernels.
Added to linux-can/testing. I had to move the kvaser_usb_driver_info
into kvaser_usb_core.c and the keep struct can_bittiming_const
kvaser_usb_flexc_bittiming_const in kvaser_usb_hydra.c as structs in
header files cause defined but not used warnings on some platforms.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-04 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 8:38 [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression Jimmy Assarsson
2022-06-03 8:38 ` [PATCH v2 1/3] can: kvaser_usb: Replace run-time checks with struct kvaser_usb_driver_info Jimmy Assarsson
2022-06-03 8:38 ` [PATCH v2 2/3] can: kvaser_usb: kvaser_usb_leaf: Fix CAN clock frequency regression Jimmy Assarsson
2022-06-03 8:38 ` [PATCH v2 3/3] can: kvaser_usb: kvaser_usb_leaf: Fix bittiming limits Jimmy Assarsson
2022-07-04 13:07 ` Marc Kleine-Budde [this message]
2022-07-04 15:07 ` [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression Jimmy Assarsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704130742.aeczqfbfnwemb7ax@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).