From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Frank Jungclaus <Frank.Jungclaus@esd.eu>
Cc: "Stefan Mätje" <Stefan.Maetje@esd.eu>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"wg@grandegger.com" <wg@grandegger.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH RESEND 1/1] can: esd_usb: Allow REC and TEC to return to zero
Date: Wed, 30 Nov 2022 11:21:57 +0100 [thread overview]
Message-ID: <20221130102157.ip7w35ufc6xepb5w@pengutronix.de> (raw)
In-Reply-To: <567bb7208c29388eb5a4fe7a270f2c3192a87e0e.camel@esd.eu>
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
On 29.11.2022 17:15:56, Frank Jungclaus wrote:
> Hello Marc,
> thanks for commenting.
>
> On Fri, 2022-11-25 at 16:56 +0100, Marc Kleine-Budde wrote:
> > On 24.11.2022 21:38:06, Frank Jungclaus wrote:
> > > We don't get any further EVENT from an esd CAN USB device for changes
> > > on REC or TEC while those counters converge to 0 (with ecc == 0).
> > > So when handling the "Back to Error Active"-event force
> > > txerr = rxerr = 0, otherwise the berr-counters might stay on
> > > values like 95 forever ...
> > >
> > > Also, to make life easier during the ongoing development a
> > > netdev_dbg() has been introduced to allow dumping error events send by
> > > an esd CAN USB device.
> > >
> > > Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>
> >
> > Please add a Fixes tag.
> >
> > https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/handling-regressions.rst#L107
> >
> From my point of view this is not a regression, it's a sort of
> imperfection existing since the initial add of esd_usb(2).c to the
> kernel. So should I add a "Fixes:" referring to the initial commit?
> (Currently) I'm slow on the uptake ;)
Please add a fixes tag that refers to the code that this patch fixes.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-11-30 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 20:38 [PATCH RESEND 0/1] can: esd_usb: Some preparation for supporting esd CAN-USB/3 Frank Jungclaus
2022-11-24 20:38 ` [PATCH RESEND 1/1] can: esd_usb: Allow REC and TEC to return to zero Frank Jungclaus
2022-11-25 15:56 ` Marc Kleine-Budde
2022-11-29 17:15 ` Frank Jungclaus
2022-11-30 10:21 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130102157.ip7w35ufc6xepb5w@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Frank.Jungclaus@esd.eu \
--cc=Stefan.Maetje@esd.eu \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).