From: Markus Schneider-Pargmann <msp@baylibre.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/15] can: m_can: Optimizations for tcan and peripheral chips
Date: Mon, 5 Dec 2022 10:09:32 +0100 [thread overview]
Message-ID: <20221205090932.zdoqxifsf6aty4k6@blmsp> (raw)
In-Reply-To: <20221202140306.n3iy74ru5f6bxmco@pengutronix.de>
Good Morning Marc,
On Fri, Dec 02, 2022 at 03:03:06PM +0100, Marc Kleine-Budde wrote:
> On 16.11.2022 21:52:53, Markus Schneider-Pargmann wrote:
> > Hi,
> >
> > this series is aimed at optimizing the driver code for tcan chips and
> > more generally for peripheral m_can chips.
> >
> > I did different things to improve the performance:
> > - Reduce the number of SPI transfers.
> > - Reduce the number of interrupts.
> > - Enable use of FIFOs.
> >
> > I am working with a tcan4550 in loopback mode attached to a beaglebone
> > black. I am currently working on optimizing the receive path as well
> > which will be submitted in another series once it is done.
>
> The patches I've not commented on look fine. If you re-spin the series
> only containing those, I'll include them in my next pull request, which
> I'll send out soonish.
Ok, thank you, I will send a subset of the patches today.
>
> regards,
> Marc
>
> > Best,
> > Markus
> >
> > Markus Schneider-Pargmann (15):
> > can: m_can: Eliminate double read of TXFQS in tx_handler
> > can: m_can: Wakeup net queue once tx was issued
> > can: m_can: Cache tx putidx and transmits in flight
> > can: m_can: Use transmit event FIFO watermark level interrupt
> > can: m_can: Disable unused interrupts
> > can: m_can: Avoid reading irqstatus twice
> > can: m_can: Read register PSR only on error
> > can: m_can: Count TXE FIFO getidx in the driver
> > can: m_can: Count read getindex in the driver
> > can: m_can: Batch acknowledge rx fifo
> > can: m_can: Batch acknowledge transmit events
> > can: tcan4x5x: Remove invalid write in clear_interrupts
> > can: tcan4x5x: Fix use of register error status mask
> > can: tcan4x5x: Fix register range of first block
> > can: tcan4x5x: Specify separate read/write ranges
> >
> > drivers/net/can/m_can/m_can.c | 140 +++++++++++++++---------
> > drivers/net/can/m_can/m_can.h | 5 +
> > drivers/net/can/m_can/tcan4x5x-core.c | 19 ++--
> > drivers/net/can/m_can/tcan4x5x-regmap.c | 45 ++++++--
> > 4 files changed, 141 insertions(+), 68 deletions(-)
> >
> >
> > base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
> > prerequisite-patch-id: e9df6751d43bb0d1e3b8938d7e93bc1cfa22cef2
> > prerequisite-patch-id: dad9ec37af766bcafe54cb156f896267a0f47fe1
> > prerequisite-patch-id: f4e6f1a213a31df2741a5fa3baa87aa45ef6707a
>
> BTW: I don't have access to these prerequisite-patch-id.
I think I messed up here. I have three patches, SPI fixes and devicetree
snippet that this series is based on. I guess I shouldn't have used
--base then or rebase on something without these patches first.
Thanks,
Markus
prev parent reply other threads:[~2022-12-05 9:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 20:52 [PATCH 00/15] can: m_can: Optimizations for tcan and peripheral chips Markus Schneider-Pargmann
2022-11-16 20:52 ` [PATCH 01/15] can: m_can: Eliminate double read of TXFQS in tx_handler Markus Schneider-Pargmann
2022-11-16 20:52 ` [PATCH 02/15] can: m_can: Wakeup net queue once tx was issued Markus Schneider-Pargmann
2022-11-30 17:21 ` Marc Kleine-Budde
2022-12-01 8:43 ` Markus Schneider-Pargmann
2022-12-01 9:16 ` Marc Kleine-Budde
2022-12-01 16:49 ` Markus Schneider-Pargmann
2022-12-02 9:16 ` Marc Kleine-Budde
2022-12-14 9:14 ` Markus Schneider-Pargmann
2022-12-14 9:18 ` Marc Kleine-Budde
2022-12-14 9:22 ` Marc Kleine-Budde
2022-12-14 10:15 ` Vincent MAILHOL
2022-12-14 10:35 ` Markus Schneider-Pargmann
2022-12-15 9:31 ` Markus Schneider-Pargmann
2022-12-16 4:40 ` Vincent MAILHOL
2022-12-14 10:18 ` Markus Schneider-Pargmann
2022-12-02 13:53 ` Marc Kleine-Budde
2022-11-16 20:52 ` [PATCH 03/15] can: m_can: Cache tx putidx and transmits in flight Markus Schneider-Pargmann
2022-12-01 11:14 ` Marc Kleine-Budde
2022-12-02 8:37 ` Markus Schneider-Pargmann
2022-12-02 14:46 ` Marc Kleine-Budde
2022-12-13 17:13 ` Markus Schneider-Pargmann
2022-12-13 19:17 ` Marc Kleine-Budde
2022-12-14 8:32 ` Markus Schneider-Pargmann
2022-11-16 20:52 ` [PATCH 04/15] can: m_can: Use transmit event FIFO watermark level interrupt Markus Schneider-Pargmann
2022-11-30 17:17 ` Marc Kleine-Budde
2022-12-01 8:25 ` Markus Schneider-Pargmann
2022-12-01 9:05 ` Marc Kleine-Budde
2022-12-01 10:12 ` Markus Schneider-Pargmann
2022-12-01 11:00 ` Marc Kleine-Budde
2022-12-01 16:59 ` Markus Schneider-Pargmann
2022-12-02 9:23 ` Marc Kleine-Budde
2022-12-02 9:43 ` Markus Schneider-Pargmann
2022-12-02 14:03 ` Marc Kleine-Budde
2022-12-13 17:19 ` Markus Schneider-Pargmann
2022-12-13 19:18 ` Marc Kleine-Budde
2022-11-16 20:52 ` [PATCH 05/15] can: m_can: Disable unused interrupts Markus Schneider-Pargmann
2022-11-16 20:52 ` [PATCH 06/15] can: m_can: Avoid reading irqstatus twice Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 07/15] can: m_can: Read register PSR only on error Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 08/15] can: m_can: Count TXE FIFO getidx in the driver Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 09/15] can: m_can: Count read getindex " Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 10/15] can: m_can: Batch acknowledge rx fifo Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 11/15] can: m_can: Batch acknowledge transmit events Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 12/15] can: tcan4x5x: Remove invalid write in clear_interrupts Markus Schneider-Pargmann
2022-12-02 14:17 ` Marc Kleine-Budde
2022-11-16 20:53 ` [PATCH 13/15] can: tcan4x5x: Fix use of register error status mask Markus Schneider-Pargmann
2022-12-02 14:19 ` Marc Kleine-Budde
2022-11-16 20:53 ` [PATCH 14/15] can: tcan4x5x: Fix register range of first block Markus Schneider-Pargmann
2022-12-02 14:28 ` Marc Kleine-Budde
2022-12-05 9:30 ` Markus Schneider-Pargmann
2022-12-05 9:44 ` Marc Kleine-Budde
2022-12-05 9:55 ` Markus Schneider-Pargmann
2022-11-16 20:53 ` [PATCH 15/15] can: tcan4x5x: Specify separate read/write ranges Markus Schneider-Pargmann
2022-12-02 14:03 ` [PATCH 00/15] can: m_can: Optimizations for tcan and peripheral chips Marc Kleine-Budde
2022-12-05 9:09 ` Markus Schneider-Pargmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205090932.zdoqxifsf6aty4k6@blmsp \
--to=msp@baylibre.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).