From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: "Frank Jungclaus" <frank.jungclaus@esd.eu>,
linux-can@vger.kernel.org,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] can: esd_usb: Improved decoding for ESD_EV_CAN_ERROR_EXT messages
Date: Tue, 20 Dec 2022 10:05:25 +0100 [thread overview]
Message-ID: <20221220090525.tvmgmtffmy7ruyi3@pengutronix.de> (raw)
In-Reply-To: <CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]
On 20.12.2022 17:53:28, Vincent MAILHOL wrote:
> > > struct tx_msg {
> > > @@ -229,10 +237,10 @@ static void esd_usb_rx_event(struct esd_usb_net_priv *priv,
> > > u32 id = le32_to_cpu(msg->msg.rx.id) & ESD_IDMASK;
> > >
> > > if (id == ESD_EV_CAN_ERROR_EXT) {
> > > - u8 state = msg->msg.rx.data[0];
> > > - u8 ecc = msg->msg.rx.data[1];
> > > - u8 rxerr = msg->msg.rx.data[2];
> > > - u8 txerr = msg->msg.rx.data[3];
> > > + u8 state = msg->msg.rx.ev_can_err_ext.status;
> > > + u8 ecc = msg->msg.rx.ev_can_err_ext.ecc;
> > > + u8 rxerr = msg->msg.rx.ev_can_err_ext.rec;
> > > + u8 txerr = msg->msg.rx.ev_can_err_ext.tec;
> >
> > I do not like how you have to write msg->msg.rx.something. I think it
> > would be better to make the union within struct esd_usb_msg anonymous:
> >
> > https://elixir.bootlin.com/linux/latest/source/drivers/net/can/usb/esd_usb.c#L169
>
> Or maybe just declare esd_usb_msg as an union instead of a struct:
+1
> union esd_usb_msg {
> struct header_msg hdr;
> struct version_msg version;
> struct version_reply_msg version_reply;
> struct rx_msg rx;
> struct tx_msg tx;
> struct tx_done_msg txdone;
> struct set_baudrate_msg setbaud;
> struct id_filter_msg filter;
> };
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-20 9:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 21:27 [PATCH 2/3] can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (2) Frank Jungclaus
2022-12-19 21:27 ` [PATCH 3/3] can: esd_usb: Improved decoding for ESD_EV_CAN_ERROR_EXT messages Frank Jungclaus
2022-12-20 5:27 ` Vincent MAILHOL
2022-12-20 8:53 ` Vincent MAILHOL
2022-12-20 9:05 ` Marc Kleine-Budde [this message]
2023-01-23 15:51 ` Frank Jungclaus
2022-12-21 18:01 ` Frank Jungclaus
2022-12-20 5:49 ` [PATCH 2/3] can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (2) Vincent MAILHOL
2022-12-21 18:29 ` Frank Jungclaus
2022-12-22 2:21 ` Vincent MAILHOL
2023-01-23 15:47 ` Frank Jungclaus
2023-02-02 15:22 ` Marc Kleine-Budde
2023-02-09 19:00 ` Frank Jungclaus
2023-02-09 19:30 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220090525.tvmgmtffmy7ruyi3@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=frank.jungclaus@esd.eu \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=stefan.maetje@esd.eu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).