From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] can: isotp: handle wait_event_interruptible() return values
Date: Fri, 6 Jan 2023 12:37:31 +0100 [thread overview]
Message-ID: <20230106113731.irqfxdpn5ygae44e@pengutronix.de> (raw)
In-Reply-To: <20bef3ed-47ef-8042-6b98-1f498b81962f@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
On 05.01.2023 13:58:30, Oliver Hartkopp wrote:
>
>
> On 05.01.23 10:32, Marc Kleine-Budde wrote:
> > On 04.01.2023 17:46:05, Oliver Hartkopp wrote:
> > > When wait_event_interruptible() has been interrupted by a signal the
> > > tx.state value might not be ISOTP_IDLE. Force the state machines
> > > into idle state to inhibit the timer handlers to continue working.
> > >
> > > Cc: stable@vger.kernel.org # >= v5.15
> > > Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> >
> > Can you add a Fixes: tag?
>
> Yes. Sent out a V3.
>
> In fact I was not sure if it makes sense to apply the patch down to Linux
> 5.10 as it might increase the possibility to trigger a WARN(1) in the
> isotp_tx_timer_handler().
>
> The patch is definitely helpful for the latest code including commit
> 4b7fe92c0690 ("can: isotp: add local echo tx processing for consecutive
> frames") introduced in Linux 5.18 and its fixes.
>
> I did some testing with very long ISOTP PDUs and killed the waiting
> isotp_release() with a Crtl-C.
>
> To prevent the WARN(1) we might also stick this patch to
>
> Fixes: 866337865f37 ("can: isotp: fix tx state handling for echo tx
> processing")
>
> What do you think about the WARN(1)?
If this short patch avoids potential WARN()s it's stable material.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-06 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 16:46 [PATCH v2] can: isotp: handle wait_event_interruptible() return values Oliver Hartkopp
2023-01-05 9:32 ` Marc Kleine-Budde
2023-01-05 12:58 ` Oliver Hartkopp
2023-01-06 11:37 ` Marc Kleine-Budde [this message]
2023-01-06 12:59 ` Oliver Hartkopp
2023-01-12 19:31 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106113731.irqfxdpn5ygae44e@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).