From: Fedor Pchelkin <pchelkin@ispras.ru>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Fedor Pchelkin <pchelkin@ispras.ru>,
Ziyang Xuan <william.xuanziyang@huawei.com>,
robin@protonic.nl, linux@rempel-privat.de,
Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH net] can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate
Date: Sat, 14 Jan 2023 20:35:46 +0300 [thread overview]
Message-ID: <20230114173546.38340-1-pchelkin@ispras.ru> (raw)
In-Reply-To: <20210910124005.GJ26100@pengutronix.de>
Hello,
On Fri, 10 Sep 2021 14:40:05 +0200, Oleksij Rempel wrote:
> Ok, I see, this warning makes sense only if session will actually be
> deactivated.
>
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> Thank you!
As Ziyang Xuan stated, the patch was not applied to upstream.
Usage of WARN_ON_ONCE in this case is actually discouraged: it erroneusly
complains in a valid situation.
So the macro should be removed with the aforementioned patch. If it makes
some sense for debugging purposes, WARN_ON_ONCE can be replaced with
netdev_warn/netdev_notice but anyway discard of WARN_ON_ONCE.
--
Regards,
Fedor
prev parent reply other threads:[~2023-01-14 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:42 [PATCH net] can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate Ziyang Xuan
2021-09-08 3:46 ` Oleksij Rempel
2021-09-10 12:40 ` Oleksij Rempel
2021-11-10 2:00 ` Ziyang Xuan (William)
2023-01-14 17:35 ` Fedor Pchelkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114173546.38340-1-pchelkin@ispras.ru \
--to=pchelkin@ispras.ru \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lvc-project@linuxtesting.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).