From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>,
Simon Horman <simon.horman@corigine.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net-next 06/22] can: bxcan: Remove unnecessary print function dev_err()
Date: Mon, 15 May 2023 22:57:43 +0200 [thread overview]
Message-ID: <20230515205759.1003118-7-mkl@pengutronix.de> (raw)
In-Reply-To: <20230515205759.1003118-1-mkl@pengutronix.de>
From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
./drivers/net/can/bxcan.c:970:2-9: line 970 is redundant because platform_get_irq() already prints an error.
./drivers/net/can/bxcan.c:964:2-9: line 964 is redundant because platform_get_irq() already prints an error.
./drivers/net/can/bxcan.c:958:2-9: line 958 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4878
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/all/20230506080725.68401-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/bxcan.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/can/bxcan.c b/drivers/net/can/bxcan.c
index e26ccd41e3cb..7b285eeb08a1 100644
--- a/drivers/net/can/bxcan.c
+++ b/drivers/net/can/bxcan.c
@@ -954,22 +954,16 @@ static int bxcan_probe(struct platform_device *pdev)
}
rx_irq = platform_get_irq_byname(pdev, "rx0");
- if (rx_irq < 0) {
- dev_err(dev, "failed to get rx0 irq\n");
+ if (rx_irq < 0)
return rx_irq;
- }
tx_irq = platform_get_irq_byname(pdev, "tx");
- if (tx_irq < 0) {
- dev_err(dev, "failed to get tx irq\n");
+ if (tx_irq < 0)
return tx_irq;
- }
sce_irq = platform_get_irq_byname(pdev, "sce");
- if (sce_irq < 0) {
- dev_err(dev, "failed to get sce irq\n");
+ if (sce_irq < 0)
return sce_irq;
- }
ndev = alloc_candev(sizeof(struct bxcan_priv), BXCAN_TX_MB_NUM);
if (!ndev) {
--
2.39.2
next prev parent reply other threads:[~2023-05-15 20:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 20:57 [PATCH net-next 0/22] pull-request: can-next 2023-05-15 Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 01/22] can: at91_can: Convert to platform remove callback returning void Marc Kleine-Budde
2023-05-17 4:10 ` patchwork-bot+netdevbpf
2023-05-15 20:57 ` [PATCH net-next 02/22] can: bxcan: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 03/22] can: c_can: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 04/22] can: usb: f81604: add Fintek F81604 support Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 05/22] can: cc770_isa: Convert to platform remove callback returning void Marc Kleine-Budde
2023-05-15 20:57 ` Marc Kleine-Budde [this message]
2023-05-15 20:57 ` [PATCH net-next 07/22] can: cc770_platform: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 08/22] can: length: make header self contained Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 09/22] can: ctucanfd: Convert to platform remove callback returning void Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 10/22] can: flexcan: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 11/22] can: grcan: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 12/22] can: ifi_canfd: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 13/22] can: janz-ican3: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 14/22] can: m_can: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 15/22] can: mscan: mpc5xxx_can: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 16/22] can: rcar: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 17/22] can: sja1000_isa: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 18/22] can: sja1000_platform: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 19/22] can: softing: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 20/22] can: sun4i_can: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 21/22] can: ti_hecc: " Marc Kleine-Budde
2023-05-15 20:57 ` [PATCH net-next 22/22] can: xilinx: " Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515205759.1003118-7-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).