From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Jimmy Assarsson <extja@kvaser.com>,
stable@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net 2/7] can: kvaser_pciefd: Clear listen-only bit if not explicitly requested
Date: Thu, 18 May 2023 09:32:36 +0200 [thread overview]
Message-ID: <20230518073241.1110453-3-mkl@pengutronix.de> (raw)
In-Reply-To: <20230518073241.1110453-1-mkl@pengutronix.de>
From: Jimmy Assarsson <extja@kvaser.com>
The listen-only bit was never cleared, causing the controller to
always use listen-only mode, if previously set.
Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Cc: stable@vger.kernel.org
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
Link: https://lore.kernel.org/r/20230516134318.104279-3-extja@kvaser.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/kvaser_pciefd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index 867b421b9506..cdc894d12885 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -554,6 +554,8 @@ static void kvaser_pciefd_setup_controller(struct kvaser_pciefd_can *can)
if (can->can.ctrlmode & CAN_CTRLMODE_LISTENONLY)
mode |= KVASER_PCIEFD_KCAN_MODE_LOM;
+ else
+ mode &= ~KVASER_PCIEFD_KCAN_MODE_LOM;
mode |= KVASER_PCIEFD_KCAN_MODE_EEN;
mode |= KVASER_PCIEFD_KCAN_MODE_EPEN;
--
2.39.2
next prev parent reply other threads:[~2023-05-18 7:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 7:32 [PATCH net 0/7] pull-request: can 2023-05-18 Marc Kleine-Budde
2023-05-18 7:32 ` [PATCH net 1/7] can: kvaser_pciefd: Set CAN_STATE_STOPPED in kvaser_pciefd_stop() Marc Kleine-Budde
2023-05-18 9:50 ` patchwork-bot+netdevbpf
2023-05-18 7:32 ` Marc Kleine-Budde [this message]
2023-05-18 7:32 ` [PATCH net 3/7] can: kvaser_pciefd: Call request_irq() before enabling interrupts Marc Kleine-Budde
2023-05-18 7:32 ` [PATCH net 4/7] can: kvaser_pciefd: Empty SRB buffer in probe Marc Kleine-Budde
2023-05-18 7:32 ` [PATCH net 5/7] can: kvaser_pciefd: Do not send EFLUSH command on TFD interrupt Marc Kleine-Budde
2023-05-18 7:32 ` [PATCH net 6/7] can: kvaser_pciefd: Disable interrupts in probe error path Marc Kleine-Budde
2023-05-18 7:32 ` [PATCH net 7/7] Revert "ARM: dts: stm32: add CAN support on stm32f746" Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518073241.1110453-3-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=extja@kvaser.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).