From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Judith Mendez <jm@ti.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Vignesh Raghavendra <vigneshr@ti.com>, Andrew Davis <afd@ti.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Schuyler Patton <spatton@ti.com>
Subject: Re: [RFC PATCH 4/5] arm64: dts: ti: Enable multiple MCAN for AM62x in MCU MCAN overlay
Date: Fri, 14 Apr 2023 22:44:00 +0200 [thread overview]
Message-ID: <342dd9b0-35cd-1715-ee67-6a6628a3a9a6@linaro.org> (raw)
In-Reply-To: <20230414182925.ya3fe2n6mtyuqotb@detached>
On 14/04/2023 20:29, Nishanth Menon wrote:
>>> +
>>> +&cbass_mcu {
>>> + mcu_mcan1: can@4e00000 {
>>> + compatible = "bosch,m_can";
>>> + reg = <0x00 0x4e00000 0x00 0x8000>,
>>> + <0x00 0x4e08000 0x00 0x200>;
>>> + reg-names = "message_ram", "m_can";
>>> + power-domains = <&k3_pds 188 TI_SCI_PD_EXCLUSIVE>;
>>> + clocks = <&k3_clks 188 6>, <&k3_clks 188 1>;
>>> + clock-names = "hclk", "cclk";
>>> + bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&mcu_mcan1_pins_default>;
>>> + phys = <&transceiver2>;
>>> + status = "okay";
>>
>> okay is by default. Why do you need it?
>
> mcan is not functional without pinmux, so it has been disabled by
> default in SoC. this overlay is supposed to enable it. But this is done
> entirely wrongly.
Ah, so this is override of existing node? Why not overriding by
label/phandle?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-14 20:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 22:30 [RFC PATCH 0/5] Enable multiple MCAN on AM62x Judith Mendez
2023-04-13 22:30 ` [RFC PATCH 1/5] arm64: dts: ti: Add AM62x MCAN MAIN domain transceiver overlay Judith Mendez
2023-04-13 22:30 ` [RFC PATCH 2/5] arm64: defconfig: Enable MCAN driver Judith Mendez
2023-04-13 22:30 ` [RFC PATCH 3/5] dt-binding: can: m_can: Remove required interrupt attributes Judith Mendez
2023-04-14 8:00 ` Krzysztof Kozlowski
2023-04-13 22:30 ` [RFC PATCH 4/5] arm64: dts: ti: Enable multiple MCAN for AM62x in MCU MCAN overlay Judith Mendez
2023-04-14 8:01 ` Krzysztof Kozlowski
2023-04-14 18:29 ` Nishanth Menon
2023-04-14 20:44 ` Krzysztof Kozlowski [this message]
2023-04-14 22:11 ` Nishanth Menon
2023-04-19 15:54 ` Mendez, Judith
2023-04-13 22:30 ` [RFC PATCH 5/5] can: m_can: Add hrtimer to generate software interrupt Judith Mendez
2023-04-14 18:20 ` Marc Kleine-Budde
2023-04-16 12:33 ` Oliver Hartkopp
2023-04-16 15:35 ` Marc Kleine-Budde
2023-04-16 19:46 ` Oliver Hartkopp
2023-04-17 7:26 ` Marc Kleine-Budde
2023-04-17 17:34 ` Oliver Hartkopp
2023-04-17 19:26 ` Marc Kleine-Budde
2023-04-18 20:59 ` Mendez, Judith
2023-04-19 6:13 ` Marc Kleine-Budde
2023-04-19 14:38 ` Mendez, Judith
2023-04-19 19:06 ` Mendez, Judith
2023-04-14 6:12 ` [RFC PATCH 0/5] Enable multiple MCAN on AM62x Vignesh Raghavendra
2023-04-19 15:12 ` Mendez, Judith
2023-04-14 17:49 ` Marc Kleine-Budde
2023-04-18 16:15 ` Mendez, Judith
2023-04-19 6:10 ` Marc Kleine-Budde
2023-04-19 20:40 ` Mendez, Judith
2023-04-20 9:36 ` Marc Kleine-Budde
2023-04-20 15:17 ` Mendez, Judith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=342dd9b0-35cd-1715-ee67-6a6628a3a9a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=spatton@ti.com \
--cc=vigneshr@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).