linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Zefan Li <lizefan@huawei.com>, Ben Hutchings <ben@decadent.org.uk>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: dev: fix crtlmode_supported check
Date: Wed, 28 Jan 2015 16:38:05 +0100	[thread overview]
Message-ID: <54C9025D.9040702@hartkopp.net> (raw)
In-Reply-To: <54C89CFA.7080606@pengutronix.de>

Hello all,

just in the case you are interested to pick these patches up for 3.2 and 3.4 
stable:

The backported patch for Linux 3.2 ... 3.14 has been queued by GregKH for the 
3.10 kernel here:

http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.10/can-dev-fix-crtlmode_supported-check.patch?id=332373aa9a50a1c18027be7352d6138fa74263d0

Best regards,
Oliver

On 28.01.2015 09:25, Marc Kleine-Budde wrote:
> On 01/27/2015 08:12 PM, Oliver Hartkopp wrote:
>> When changing flags in the CAN drivers ctrlmode the provided new content has to
>> be checked whether the bits are allowed to be changed. The bits that are to be
>> changed are given as a bitfield in cm->mask. Therefore checking against
>> cm->flags is wrong as the content can hold any kind of values.
>>
>> The iproute2 tool sets the bits in cm->mask and cm->flags depending on the
>> detected command line options. To be robust against bogus user space
>> applications additionally sanitize the provided flags with the provided mask.
>>
>> (Backport of upstream commit 9b1087aa5e86448fe6ad40a58964e35f3ba423d5 for
>> Linux 3.2 .. Linux 3.14)
>
> Zefan Li <lizefan@huawei.com> is taking care of v3.4
>
> Marc
>

  parent reply	other threads:[~2015-01-28 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1422385920-29763-1-git-send-email-socketcan@hartkopp.net>
2015-01-28  8:25 ` [PATCH] can: dev: fix crtlmode_supported check Marc Kleine-Budde
2015-01-28 15:26   ` Oliver Hartkopp
2015-01-28 15:38   ` Oliver Hartkopp [this message]
2015-02-17  0:41     ` Ben Hutchings
2015-04-09  1:01     ` Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C9025D.9040702@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=ben@decadent.org.uk \
    --cc=linux-can@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).