From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Aaron Wu <Aaron.wu@analog.com>,
wg@grandegger.com, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-devel@analog.com
Subject: Re: [PATCH V5 3/3] bfin_can: move/merge the contents of header file into driver code
Date: Thu, 05 Feb 2015 12:06:55 +0100 [thread overview]
Message-ID: <54D34ECF.1060209@pengutronix.de> (raw)
In-Reply-To: <1423133067-17289-3-git-send-email-Aaron.wu@analog.com>
[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]
On 02/05/2015 11:44 AM, Aaron Wu wrote:
> Rewrite the blackfin CAN driver into more common style in three ways:
> part 1/3: rewrite blackfin style of read/write into common readw/writew
> part 2/3: introduce ioremap to be compitable with MMU enabled arch
> part 3/3: merge the header file from the blackfin arch dependent
> location to driver code directly, note the original copy of more completed
> bfin_can.h in arch depentdent location is reserved for reg test purpose
>
> V5 changes: merge contents of header file into drivere code in patch 3/3
> V4 changes: remove unused variable in patch 2/3
> V3 changes: remove redundant cast in patch 2/3
> V2 changes: split patch into two parts
> V1 changes: rewrite code into common style
>
> Signed-off-by: Aaron Wu <Aaron.wu@analog.com>
> ---
> drivers/net/can/bfin_can.c | 119 +++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 118 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c
> index 0209c14..a676624 100644
> --- a/drivers/net/can/bfin_can.c
> +++ b/drivers/net/can/bfin_can.c
> @@ -20,7 +20,6 @@
> #include <linux/can/dev.h>
> #include <linux/can/error.h>
>
> -#include <asm/bfin_can.h>
> #include <asm/portmux.h>
>
> #define DRV_NAME "bfin_can"
> @@ -28,6 +27,124 @@
> #define TX_ECHO_SKB_MAX 1
>
> /*
> + * transmit and receive channels
> + */
> +#define TRANSMIT_CHL 24
> +#define RECEIVE_STD_CHL 0
> +#define RECEIVE_EXT_CHL 4
> +#define RECEIVE_RTR_CHL 8
> +#define RECEIVE_EXT_RTR_CHL 12
> +#define MAX_CHL_NUMBER 32
^^^^^^^^^
Please use a common indention sheme, I suggest to use on space only.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-05 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 10:44 [PATCH V5 1/3] bfin_can: rewrite the blackfin style of read/write to common ones Aaron Wu
2015-02-05 10:44 ` [PATCH V5 2/3] bfin_can: rewrite the driver into common style with MMU Aaron Wu
2015-02-05 11:05 ` Marc Kleine-Budde
2015-02-06 6:54 ` Wu, Aaron
2015-02-05 10:44 ` [PATCH V5 3/3] bfin_can: move/merge the contents of header file into driver code Aaron Wu
2015-02-05 11:06 ` Marc Kleine-Budde [this message]
2015-02-05 11:03 ` [PATCH V5 1/3] bfin_can: rewrite the blackfin style of read/write to common ones Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D34ECF.1060209@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Aaron.wu@analog.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-devel@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).