From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Subject: Re: [PATCH] can: add missing initialisations in CAN related skbuffs
Date: Tue, 24 Feb 2015 09:31:34 +0100 [thread overview]
Message-ID: <54EC36E6.10502@pengutronix.de> (raw)
In-Reply-To: <1424720274-3831-1-git-send-email-socketcan@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On 02/23/2015 08:37 PM, Oliver Hartkopp wrote:
> When accessing CAN network interfaces with AF_PACKET sockets e.g. by dhclient
> this can lead to a skb_under_panic due to missing skb initialisations.
>
> Add the missing initialisations at the CAN skbuff creation times on driver
> level (rx path) and in the network layer (tx path).
>
> Reported-by: Austin Schuh <austin@peloton-tech.com>
> Reported-by: Daniel Steer <daniel.steer@mclaren.com>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks, applied to can/master, added stable on Cc.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-02-24 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 19:37 [PATCH] can: add missing initialisations in CAN related skbuffs Oliver Hartkopp
2015-02-24 8:31 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EC36E6.10502@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).