AW: [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card

["Thomas Körper" <Thomas.Koerper@esd.eu>]

Hi,

already was afraid the module param should be removed :)
May I print all these infos unconditionally?  ...If someone has
trouble with the card we really like to see that stuff first.

And about the commit message: maybe
"This patch adds support for the CAN PCIe/402 card from esd electronic
system design gmbh. FPGA based CAN controller, supporting up to 4
nets, MSI and bus mastering, see http://esd.eu/en/products/can-pcie402
for details."?, or something specific you're missing?

Regards,
    Thomas


-----Ursprüngliche Nachricht-----
Von: Marc Kleine-Budde [mailto:mkl@pengutronix.de] 
Gesendet: Dienstag, 4. November 2014 14:26
An: Oliver Hartkopp; Thomas Körper
Cc: linux-can@vger.kernel.org
Betreff: Re: [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card

On 11/04/2014 02:24 PM, Oliver Hartkopp wrote:
> Hello Thomas,
> 
> looks far better to me now. Thanks.
> 
> @Marc: The only two questions I would have is this pretty short commit 
> message and the module parameter.
> What do you think about it (and the rest)?

Yes, the commit message should be a bit more verbose. And the module parameter should probably be removed.

I'm currently reviewing Stefano Babic's SPI driver, which has been waiting for review a bit longer.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |