From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Frank Jungclaus <Frank.Jungclaus@esd.eu>
Cc: "Stefan Mätje" <Stefan.Maetje@esd.eu>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"wg@grandegger.com" <wg@grandegger.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (1)
Date: Thu, 22 Dec 2022 09:46:48 +0900 [thread overview]
Message-ID: <CAMZ6RqL+7zLLkL_bXAR0iwk6XH_7F_-t472vnq_-jMgT4XC6UA@mail.gmail.com> (raw)
In-Reply-To: <f9c68625149673fec635d64a21608f3b53866cd7.camel@esd.eu>
On Tue. 22 Dec. 2022 at 02:55, Frank Jungclaus <Frank.Jungclaus@esd.eu> wrote:
> On Tue, 2022-12-20 at 14:16 +0900, Vincent MAILHOL wrote:
> > On Tue. 20 Dec. 2022 at 06:25, Frank Jungclaus <frank.jungclaus@esd.eu> wrote:
> > >
> > > Moved the supply for cf->data[3] (bit stream position of CAN error)
> > > outside of the "switch (ecc & SJA1000_ECC_MASK){}"-statement, because
> > > this position is independent of the error type.
> > >
> > > Fixes: 96d8e90382dc ("can: Add driver for esd CAN-USB/2 device")
> > > Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>
> > > ---
> > > drivers/net/can/usb/esd_usb.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_usb.c
> > > index 42323f5e6f3a..5e182fadd875 100644
> > > --- a/drivers/net/can/usb/esd_usb.c
> > > +++ b/drivers/net/can/usb/esd_usb.c
> > > @@ -286,7 +286,6 @@ static void esd_usb_rx_event(struct esd_usb_net_priv *priv,
> > > cf->data[2] |= CAN_ERR_PROT_STUFF;
> > > break;
> > > default:
> > > - cf->data[3] = ecc & SJA1000_ECC_SEG;
> > > break;
> > > }
> > >
> > > @@ -294,6 +293,9 @@ static void esd_usb_rx_event(struct esd_usb_net_priv *priv,
> > > if (!(ecc & SJA1000_ECC_DIR))
> > > cf->data[2] |= CAN_ERR_PROT_TX;
> > >
> > > + /* Bit stream position in CAN frame as the error was detected */
> > > + cf->data[3] = ecc & SJA1000_ECC_SEG;
> >
> > Can you confirm that the value returned by the device matches the
> > specifications from linux/can/error.h?
>
> The value returned is supposed to be compatible to the SJA1000 ECC
> register.
>
> See
> https://esd.eu/fileadmin/esd/docs/manuals/NTCAN_Part1_Function_API_Manual_en_56.pdf
>
> Chapter "6.2.10 EV_CAN_ERROR_EXT" (page 185)
> and
> "Annex B: Bus Error Code" table 37 and 38 (page 272 and following).
>
> So this should be compliant with the values given in linux/can/error.h.
Thanks for the link. It is indeed compliant.
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/can/error.h#L90
> >
> > > if (priv->can.state == CAN_STATE_ERROR_WARNING ||
> > > priv->can.state == CAN_STATE_ERROR_PASSIVE) {
> > > cf->data[1] = (txerr > rxerr) ?
> > > --
> > > 2.25.1
> > >
>
prev parent reply other threads:[~2022-12-22 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 21:20 [PATCH 0/3] can: esd_usb: Some more preparation for supporting esd CAN-USB/3 Frank Jungclaus
2022-12-19 21:20 ` [PATCH 1/3] can: esd_usb: Improved behavior on esd CAN_ERROR_EXT event (1) Frank Jungclaus
2022-12-20 5:16 ` Vincent MAILHOL
2022-12-21 17:55 ` Frank Jungclaus
2022-12-22 0:46 ` Vincent MAILHOL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZ6RqL+7zLLkL_bXAR0iwk6XH_7F_-t472vnq_-jMgT4XC6UA@mail.gmail.com \
--to=mailhol.vincent@wanadoo.fr \
--cc=Frank.Jungclaus@esd.eu \
--cc=Stefan.Maetje@esd.eu \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).