linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Cai Huoqing <caihuoqing@baidu.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] can: rcar_canfd: add __maybe_unused annotation to silence warning
Date: Tue, 7 Sep 2021 09:09:58 +0200	[thread overview]
Message-ID: <CAMuHMdV-4JM17XPzte5JPN6LfanCugQzVDC-yk2vKhr95zAO4A@mail.gmail.com> (raw)
In-Reply-To: <20210907064537.1054268-1-mkl@pengutronix.de>

On Tue, Sep 7, 2021 at 8:48 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> Since commit
>
> | dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver")
>
> the rcar_canfd driver can be compile tested on all architectures. On
> non OF enabled archs, or archs where OF is optional (and disabled in
> the .config) the compilation throws the following warning:
>
> | drivers/net/can/rcar/rcar_canfd.c:2020:34: warning: unused variable 'rcar_canfd_of_table' [-Wunused-const-variable]
> | static const struct of_device_id rcar_canfd_of_table[] = {
> |                                  ^
>
> This patch fixes the warning by marking the variable
> rcar_canfd_of_table as __maybe_unused.
>
> Fixes: ac4224087312 ("can: rcar: Kconfig: Add helper dependency on COMPILE_TEST")
> Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver")
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: Cai Huoqing <caihuoqing@baidu.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2021-09-07  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  6:45 [PATCH v2] can: rcar_canfd: add __maybe_unused annotation to silence warning Marc Kleine-Budde
2021-09-07  7:09 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdV-4JM17XPzte5JPN6LfanCugQzVDC-yk2vKhr95zAO4A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=caihuoqing@baidu.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).