RE: [PATCH] m_can: fixed typo in m_can_set_bittiming() causing corrupt DBTP register content

[Hussein Alasadi <alasadi@arecs.eu>]

Hello Marc,

I hope it's in the correct format now.

Fixed M_CAN_DBTP corrupt register contents:
* NBTP_xxx defines were being used instead of DBTP_xxx.
* reg_btp was not getting ORed with the possibly-existing DBTP_TDC flag.

Signed-off-by: Hussein Alasadi <alasadi@arecs.eu>

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 0cffaad905c2..f3809f4cfc7b 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1168,10 +1168,10 @@ static int m_can_set_bittiming(struct net_device *dev)
                                    FIELD_PREP(TDCR_TDCO_MASK, tdco));
                }

-               reg_btp = FIELD_PREP(NBTP_NBRP_MASK, brp) |
-                         FIELD_PREP(NBTP_NSJW_MASK, sjw) |
-                         FIELD_PREP(NBTP_NTSEG1_MASK, tseg1) |
-                         FIELD_PREP(NBTP_NTSEG2_MASK, tseg2);
+               reg_btp |= FIELD_PREP(DBTP_DBRP_MASK, brp) |
+                         FIELD_PREP(DBTP_DSJW_MASK, sjw) |
+                         FIELD_PREP(DBTP_DTSEG1_MASK, tseg1) |
+                         FIELD_PREP(DBTP_DTSEG2_MASK, tseg2);

                m_can_write(cdev, M_CAN_DBTP, reg_btp);
        }


Mit freundlichen Grüßen,

H. Alasadi
Projektleiter Entwicklung
ARECS GmbH
Lindberghstr. 5
82178 Puchheim, Germany
 
ARECS Advanced Research, Engineering & Consulting Services GmbH
Amtsgericht München HRB 174075, Sitz der Gesellschaft: Puchheim bei München

-----Original Message-----
From: Marc Kleine-Budde <mkl@pengutronix.de> 
Sent: Monday, 9 August 2021 8:11 PM
To: Hussein Alasadi <alasadi@arecs.eu>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] m_can: fixed typo in m_can_set_bittiming() causing corrupt DBTP register content

Hey Hussein Alasadi,

On 09.08.2021 17:36:52, Hussein Alasadi wrote:
> Fixed M_CAN_DBTP corrupt register contents:
> * NBTP_xxx defines were being used instead of DBTP_xxx.
> * reg_btp was not getting ORed with the possibly-existing DBTP_TDC flag.

Thanks for your patch!

Can you please re-send the patch with your "Signed-off-by:". For details
see:

https://elixir.bootlin.com/linux/v5.12/source/Documentation/process/submitting-patches.rst#L356

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |