linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de, David Jander <david@protonic.nl>
Subject: Re: [PATCH v2 1/3] dt-bindings: can-controller: add support for termination-gpios
Date: Tue, 17 Aug 2021 20:18:54 -0500	[thread overview]
Message-ID: <YRxf/gKvS3o+hq1/@robh.at.kernel.org> (raw)
In-Reply-To: <20210817041306.25185-2-o.rempel@pengutronix.de>

On Tue, Aug 17, 2021 at 06:13:04AM +0200, Oleksij Rempel wrote:
> Some boards provide GPIO controllable termination resistor. Provide
> binding to make use of it.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/net/can/can-controller.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/can-controller.yaml b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> index 9cf2ae097156..298ce69a8208 100644
> --- a/Documentation/devicetree/bindings/net/can/can-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> @@ -13,6 +13,15 @@ properties:
>    $nodename:
>      pattern: "^can(@.*)?$"
>  
> +  termination-gpios:
> +    description: GPIO pin to enable CAN bus termination.

maxItems: 1

> +
> +  termination-ohms:
> +    description: The resistance value of the CAN bus termination resistor.
> +    $ref: /schemas/types.yaml#/definitions/uint16-array

Standard unit properties already have a type and are uint32.

> +    minimum: 1
> +    maximum: 65535
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.30.2
> 
> 

  reply	other threads:[~2021-08-18  1:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  4:13 [PATCH v2 0/3] can: provide GPIO based termination Oleksij Rempel
2021-08-17  4:13 ` [PATCH v2 1/3] dt-bindings: can-controller: add support for termination-gpios Oleksij Rempel
2021-08-18  1:18   ` Rob Herring [this message]
2021-08-17  4:13 ` [PATCH v2 2/3] dt-bindings: can: fsl,flexcan: enable termination-* bindings Oleksij Rempel
2021-08-17  4:13 ` [PATCH v2 3/3] can: dev: provide optional GPIO based termination support Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRxf/gKvS3o+hq1/@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).