From: David Howells <dhowells@redhat.com> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: Jeffrey Altman <jaltman@auristor.com>, linux-afs@lists.infradead.org, dhowells@redhat.com, Jeff Layton <jlayton@kernel.org>, Ilya Dryomov <idryomov@gmail.com>, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position Date: Tue, 24 Aug 2021 14:24:47 +0100 [thread overview] Message-ID: <162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk> Fix afs_launder_page() to set the starting position of the StoreData RPC at the offset into the page at which the modified data starts instead of at the beginning of the page (the iov_iter is correctly offset). The offset got lost during the conversion to passing an iov_iter into afs_store_data(). Fixes: bd80d8a80e12 ("afs: Use ITER_XARRAY for writing") Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeffrey Altman <jaltman@auristor.com> cc: linux-afs@lists.infradead.org Link: https://lore.kernel.org/r/162880783179.3421678.7795105718190440134.stgit@warthog.procyon.org.uk/ --- fs/afs/write.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/write.c b/fs/afs/write.c index fb7d5c1cabde..fff4c7d88e0d 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -950,8 +950,8 @@ int afs_launder_page(struct page *page) iov_iter_bvec(&iter, WRITE, bv, 1, bv[0].bv_len); trace_afs_page_dirty(vnode, tracepoint_string("launder"), page); - ret = afs_store_data(vnode, &iter, (loff_t)page->index * PAGE_SIZE, - true); + ret = afs_store_data(vnode, &iter, + (loff_t)page->index * PAGE_SIZE + f, true); } trace_afs_page_dirty(vnode, tracepoint_string("laundered"), page);
next prev parent reply other threads:[~2021-08-24 13:25 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-24 13:24 [PATCH 0/6] netfs, afs, ceph: Support folios, at least partially David Howells 2021-08-24 13:24 ` David Howells [this message] 2021-08-24 14:18 ` [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position Christoph Hellwig 2021-08-24 14:18 ` Matthew Wilcox 2021-08-24 14:38 ` David Howells 2021-08-24 13:24 ` [PATCH 2/6] folio: Add a function to change the private data attached to a folio David Howells 2021-08-24 13:25 ` [PATCH 3/6] folio: Add a function to get the host inode for " David Howells 2021-08-24 14:03 ` Matthew Wilcox 2021-08-24 14:11 ` David Howells 2021-08-24 13:25 ` [PATCH 4/6] afs: Sort out symlink reading David Howells 2021-08-24 13:25 ` [PATCH 5/6] netfs, afs, ceph: Use folios David Howells 2021-08-24 13:25 ` [PATCH 6/6] afs: Use folios in directory handling David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk \ --to=dhowells@redhat.com \ --cc=ceph-devel@vger.kernel.org \ --cc=devel@lists.orangefs.org \ --cc=idryomov@gmail.com \ --cc=jaltman@auristor.com \ --cc=jlayton@kernel.org \ --cc=linux-afs@lists.infradead.org \ --cc=linux-cachefs@redhat.com \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nfs@vger.kernel.org \ --cc=v9fs-developer@lists.sourceforge.net \ --cc=willy@infradead.org \ --subject='Re: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).