[GIT PULL] smb3 client fixes

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes:
- one for DFS reconnect
- one to begin creating common headers for server and client
- the other two to rename the cifs_common directory to smbfs_common to
be more consistent ie change use of the name cifs to smb (smb3 or
smbfs is more accurate, as theThe following changes since commit
9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating
common headers for server and client and the other two to rename the
cifs_common directory to smbfs_common to be more consistent ie change
use of the name cifs to smb which is more accurate

----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)
The following changes since commit 9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating
common headers for server and client and the other two to rename the
cifs_common directory to smbfs_common to be more consistent ie change
use of the name cifs to smb which is more accurate

----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)
The following changes since commit 9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating
common headers for server and client and the other two to rename the
cifs_common directory to smbfs_common to be more consistent ie change
use of the name cifs to smb which is more accurate

----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/The following changes since
commit 9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating
common headers for server and client and the other two to rename the
cifs_common directory to smbfs_common to be more consistent ie change
use of the name cifs to smb which is more accurate

----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code
The following changes since commit 9c849ce86e0fa93a218614eac562ace44053d7ce:

  Merge tag '5.15-rc-smb3-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2021-08-31 09:22:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

for you to fetch changes up to 9351590f51cdda49d0265932a37f099950998504:

  cifs: properly invalidate cached root handle when closing it
(2021-09-09 17:34:38 -0500)

----------------------------------------------------------------
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating
common headers for server and client and the other two to rename the
cifs_common directory to smbfs_common to be more consistent ie change
use of the name cifs to smb which is more accurate

----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)
Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)
very old cifs dialect has long been superseded by smb3 dialects).

In the future we can rename the fs/cifs directory to fs/smbfs.

This pull request does not include the set of multichannel fixes nor
the two deferred close fixes (they are still being reviewed and
tested).
----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: properly invalidate cached root handle when closing it

Steve French (3):
      cifs: update FSCTL definitions
      cifs: rename cifs_common to smbfs_common
      cifs: move SMB FSCTL definitions to common code

 fs/Kconfig                                   |  2 +-
 fs/Makefile                                  |  2 +-
 fs/cifs/cifsencrypt.c                        |  2 +-
 fs/cifs/cifspdu.h                            |  2 +-
 fs/cifs/smb2ops.c                            | 20 +++++++++++++-------
 fs/cifs/smbencrypt.c                         |  2 +-
 fs/{cifs_common => smbfs_common}/Makefile    |  4 ++--
 fs/{cifs_common => smbfs_common}/arc4.h      |  0
 fs/{cifs_common => smbfs_common}/cifs_arc4.c |  8 ++++----
 fs/{cifs_common => smbfs_common}/cifs_md4.c  |  0
 fs/{cifs_common => smbfs_common}/md4.h       |  0
 fs/{cifs => smbfs_common}/smbfsctl.h         | 16 +++++++++++++---
 12 files changed, 37 insertions(+), 21 deletions(-)
 rename fs/{cifs_common => smbfs_common}/Makefile (59%)
 rename fs/{cifs_common => smbfs_common}/arc4.h (100%)
 rename fs/{cifs_common => smbfs_common}/cifs_arc4.c (91%)
 rename fs/{cifs_common => smbfs_common}/cifs_md4.c (100%)
 rename fs/{cifs_common => smbfs_common}/md4.h (100%)
 rename fs/{cifs => smbfs_common}/smbfsctl.h (92%)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[Linus Torvalds]

On Sat, Sep 11, 2021 at 10:24 AM Steve French <smfrench@gmail.com> wrote:
>
>   git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

Your pull request message was a mess - you'd done some odd
cut-and-paste with the automated output being mixed in six(!) times in
between some of your manual edits.

I tried to make a sensible merge message of it all.

           Linus

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 11 Sep 2021 12:23:54 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.15-rc-cifs-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8d4a0b5d0813c990637fa9f3c9bea5dab1fedb8f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 23 Sep 2023 12:28:05 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8565bdf8cd30cf5bf98efeb9fb53c39bf387e30c

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
ce9ecca0238b140b88f43859b211c9fdfd8e5b70:

  Linux 6.6-rc2 (2023-09-17 14:40:24 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc2-smb3-client-fixes

for you to fetch changes up to c8ebf077fbebda3a24335660ded7cff4b90331b8:

  smb3: fix confusing debug message (2023-09-20 19:50:05 -0500)

----------------------------------------------------------------
Six smb3 client fixes, including three for stable, from the SMB plugfest
(testing event) this week

- Reparse point handling fix (found when investigating dir enumeration
when fifo in dir)
- Fix excessive thread creation for dir lease cleanup
- UAF fix in negotiate path
- remove duplicate error message mapping and fix confusing warning message
- add dynamic trace point to improve debugging RDMA connection attempts

----------------------------------------------------------------
Paulo Alcantara (1):
      smb: client: handle STATUS_IO_REPARSE_TAG_NOT_HANDLED

Steve French (4):
      smb3: Add dynamic trace points for RDMA (smbdirect) reconnect
      smb3: do not start laundromat thread when dir leases  disabled
      smb3: remove duplicate error mapping
      smb3: fix confusing debug message

Zhang Xiaoxu (1):
      cifs: Fix UAF in cifs_demultiplex_thread()

 fs/smb/client/cached_dir.c   |  6 ++++++
 fs/smb/client/cifsglob.h     |  3 ++-
 fs/smb/client/cifsproto.h    |  2 +-
 fs/smb/client/connect.c      |  8 ++++++--
 fs/smb/client/misc.c         | 14 +++++++++-----
 fs/smb/client/smb2inode.c    |  3 +++
 fs/smb/client/smb2maperror.c |  2 --
 fs/smb/client/smb2pdu.c      |  4 ++--
 fs/smb/client/smbdirect.c    |  9 ++++++---
 fs/smb/client/trace.h        |  2 ++
 fs/smb/client/transport.c    | 34 +++++++++++++++++++++++-----------
 11 files changed, 60 insertions(+), 27 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 17 Sep 2023 00:42:07 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc1-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/45c3c627222f061a12e2f40612b80c17e915faf8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
0bb80ecc33a8fb5a682236443c1e740d5c917d1d:

  Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc1-smb3-client-fixes

for you to fetch changes up to 2c75426c1fea591bb338ba072068f83d2f6be088:

  smb3: fix some minor typos and repeated words (2023-09-15 01:37:33 -0500)

----------------------------------------------------------------
Three small SMB3 client fixes: one for a null check when assembling SMB3 headers
and two minor cleanup.

----------------------------------------------------------------
Steve French (3):
      smb3: move server check earlier when setting channel sequence number
      smb3: correct places where ENOTSUPP is used instead of preferred
EOPNOTSUPP
      smb3: fix some minor typos and repeated words

 fs/smb/client/inode.c     |  2 +-
 fs/smb/client/smb2ops.c   |  6 +++---
 fs/smb/client/smb2pdu.c   | 31 +++++++++++++++++++------------
 fs/smb/client/transport.c |  2 +-
 4 files changed, 24 insertions(+), 17 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 9 Sep 2023 20:36:18 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fd3a5940e66d059d375bdb9e2d7d06c56f630d7e

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
b97d64c722598ffed42ece814a2cb791336c6679:

  Merge tag '6.6-rc-smb3-client-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2023-08-30 21:01:40 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc-smb3-client-fixes-part2

for you to fetch changes up to 5d153cd128251aaedc8e9657f0a949ec94952055:

  spnego: add missing OID to oid registry (2023-09-09 08:18:16 -0500)

----------------------------------------------------------------
- six smb3 client fixes including ones to allow controlling smb3
directory caching timeout and limits, and one debugging improvement
- one fix for nls Kconfig (don't need to expose NLS_UCS2_UTILS option)
- one minor spnego registry update

----------------------------------------------------------------
Dr. David Alan Gilbert (1):
      nls: Hide new NLS_UCS2_UTILS

Katya Orlova (1):
      smb: propagate error code of extract_sharename()

Steve French (6):
      smb3: allow controlling length of time directory entries are
cached with dir leases
      smb3: add trace point for queryfs (statfs)
      smb3: allow controlling maximum number of cached directories
      cifs: update internal module version number for cifs.ko
      smb3: fix minor typo in SMB2_GLOBAL_CAP_LARGE_MTU
      spnego: add missing OID to oid registry

 fs/nls/Kconfig               |  7 +------
 fs/smb/client/cached_dir.c   | 11 ++++++-----
 fs/smb/client/cached_dir.h   |  2 +-
 fs/smb/client/cifsfs.c       | 12 ++++++++++++
 fs/smb/client/cifsfs.h       |  4 ++--
 fs/smb/client/cifsglob.h     |  2 ++
 fs/smb/client/connect.c      |  1 +
 fs/smb/client/fs_context.c   | 11 ++++++++++-
 fs/smb/client/fs_context.h   |  4 +++-
 fs/smb/client/fscache.c      |  2 +-
 fs/smb/client/smb2ops.c      |  1 +
 fs/smb/client/trace.h        |  2 +-
 fs/smb/common/smb2pdu.h      |  2 +-
 include/linux/oid_registry.h |  1 +
 14 files changed, 43 insertions(+), 19 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[Dr. David Alan Gilbert]

* Linus Torvalds (torvalds@linux-foundation.org) wrote:
> On Wed, 30 Aug 2023 at 13:48, Steve French <smfrench@gmail.com> wrote:
> >
> > - move UCS-2 conversion code to fs/nls and update cifs.ko and jfs.ko to use them
> 
> I've pulled this, but I think the new NLS_UCS2_UTILS config option
> shouldn't be something that is asked about. The filesystems that want
> it already select it, and users shouldn't be asked about a module with
> no use.
> 
> The way to do that is to simply not have a user query string for it,
> ie instead of
> 
>   config NLS_UCS2_UTILS
>           tristate "NLS UCS-2 UTILS"
> 
> it could be (an dI think should be) just
> 
>   config NLS_UCS2_UTILS
>           tristate
> 
> which tells the config system not to ask users about it.
>
> Because users really shouldn't be asked questions that there is no point in.

Agreed.
I'll check it today and send a patch.

Thanks,

Dave

> 
> And then, on a purely visual commentary about your pull request -
> lines like these are just noise:
> 
> >  fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
> > +++++-------------------------------------
> >  fs/nls/nls_ucs2_utils.h                          | 285
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> and the problem seems to be that you generate the diffstat in a very
> wide terminal (where git tries to be helpful and give you lots of
> detail), and then you cut-and-paste the result.
> 
> If you pipe it to a tool instead (xsel, perhaps), git will limit the
> width of the diffstat to something sane.
> 
> Or, if you really want to use a terminal and cut-and-paste it
> manually, you could try to tell git to use '--stat=72' to limit the
> stat to 72 characters (which is the canonical "width for email", as
> the Lord spake unto us all in rfc822, even if the Lord was confused
> and also mentioned the number 65).
> 
>                          Linus
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [GIT PULL] smb3 client fixes

[Steve French]

On Wed, Aug 30, 2023 at 11:21 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> I've pulled this, but I think the new NLS_UCS2_UTILS config option
> shouldn't be something that is asked about. The filesystems that want
> it already select it, and users shouldn't be asked about a module with
> no use.
>
> The way to do that is to simply not have a user query string for it,
> ie instead of
>
>   config NLS_UCS2_UTILS
>           tristate "NLS UCS-2 UTILS"
>
> it could be (an dI think should be) just
>
>   config NLS_UCS2_UTILS
>           tristate
>
> which tells the config system not to ask users about it.
>
> Because users really shouldn't be asked questions that there is no point in.

Agree.  Will fix

> And then, on a purely visual commentary about your pull request -
> lines like these are just noise:
>
> >  fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
> > +++++-------------------------------------
> >  fs/nls/nls_ucs2_utils.h                          | 285
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> and the problem seems to be that you generate the diffstat in a very
> wide terminal (where git tries to be helpful and give you lots of
> detail), and then you cut-and-paste the result.
>
> If you pipe it to a tool instead (xsel, perhaps), git will limit the
> width of the diffstat to something sane.

Yes - today my terminal was set at about 180 character width.  Just
tried an experiment and piping to xsel did fix the output.  Will
update my scripts.


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Wed, 30 Aug 2023 15:48:32 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b97d64c722598ffed42ece814a2cb791336c6679

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] smb3 client fixes

[Linus Torvalds]

On Wed, 30 Aug 2023 at 13:48, Steve French <smfrench@gmail.com> wrote:
>
> - move UCS-2 conversion code to fs/nls and update cifs.ko and jfs.ko to use them

I've pulled this, but I think the new NLS_UCS2_UTILS config option
shouldn't be something that is asked about. The filesystems that want
it already select it, and users shouldn't be asked about a module with
no use.

The way to do that is to simply not have a user query string for it,
ie instead of

  config NLS_UCS2_UTILS
          tristate "NLS UCS-2 UTILS"

it could be (an dI think should be) just

  config NLS_UCS2_UTILS
          tristate

which tells the config system not to ask users about it.

Because users really shouldn't be asked questions that there is no point in.

And then, on a purely visual commentary about your pull request -
lines like these are just noise:

>  fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
> +++++-------------------------------------
>  fs/nls/nls_ucs2_utils.h                          | 285
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

and the problem seems to be that you generate the diffstat in a very
wide terminal (where git tries to be helpful and give you lots of
detail), and then you cut-and-paste the result.

If you pipe it to a tool instead (xsel, perhaps), git will limit the
width of the diffstat to something sane.

Or, if you really want to use a terminal and cut-and-paste it
manually, you could try to tell git to use '--stat=72' to limit the
stat to 72 characters (which is the canonical "width for email", as
the Lord spake unto us all in rfc822, even if the Lord was confused
and also mentioned the number 65).

                         Linus

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
706a741595047797872e669b3101429ab8d378ef:

  Linux 6.5-rc7 (2023-08-20 15:02:52 +0200)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.6-rc-smb3-client-fixes-part1

for you to fetch changes up to f3a9b3758e0b6d40183929aba599a7da52313a3e:

  fs/jfs: Use common ucs2 upper case table (2023-08-30 08:55:52 -0500)

----------------------------------------------------------------
22 smb3/cifs client fixes and two related changes (cleaning up some
common code for unicode mapping)
- six fixes for excessive stack usage
- multichannel reconnect improvements
- DFS fix and four DFS cleanup patches
- move UCS-2 conversion code to fs/nls and update cifs.ko and jfs.ko to use them
- Cleanup patch for compounding, one to fix confusing function name
- inode number collision fix
- three reparse point fixes (including avoiding an extra unneeded
query on symlinks) and one minor cleanup
- directory lease (caching) improvement

----------------------------------------------------------------
Bharath SM (1):
      cifs: update desired access while requesting for directory lease

Dr. David Alan Gilbert (4):
      fs/smb: Remove unicode 'lower' tables
      fs/smb: Swing unicode common code from smb->NLS
      fs/smb/client: Use common code in client
      fs/jfs: Use common ucs2 upper case table

Paulo Alcantara (17):
      smb: client: introduce DFS_CACHE_TGT_LIST()
      smb: client: ensure to try all targets when finding nested links
      smb: client: move some params to cifs_open_info_data
      smb: client: make smb2_compound_op() return resp buffer on success
      smb: client: rename cifs_dfs_ref.c to namespace.c
      smb: client: get rid of dfs naming in automount code
      smb: client: get rid of dfs code dep in namespace.c
      smb: client: parse reparse point flag in create response
      smb: client: do not query reparse points twice on symlinks
      smb: client: query reparse points in older dialects
      smb: cilent: set reparse mount points as automounts
      smb: client: reduce stack usage in cifs_try_adding_channels()
      smb: client: reduce stack usage in cifs_demultiplex_thread()
      smb: client: reduce stack usage in smb_send_rqst()
      smb: client: reduce stack usage in smb2_set_ea()
      smb: client: reduce stack usage in smb2_query_info_compound()
      smb: client: reduce stack usage in smb2_query_reparse_point()

Steve French (2):
      [SMB3] send channel sequence number in SMB3 requests after reconnects
      SMB3: rename macro CIFS_SERVER_IS_CHAN to avoid confusion

 fs/jfs/Kconfig                                   |   1 +
 fs/jfs/Makefile                                  |   2 +-
 fs/jfs/jfs_unicode.h                             |  17 ++---
 fs/jfs/jfs_uniupr.c                              | 121
---------------------------------
 fs/nls/Kconfig                                   |   8 +++
 fs/nls/Makefile                                  |   1 +
 fs/nls/nls_ucs2_data.h                           |  15 ++++
 fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
+++++-------------------------------------
 fs/nls/nls_ucs2_utils.h                          | 285
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/smb/client/Kconfig                            |   1 +
 fs/smb/client/Makefile                           |   5 +-
 fs/smb/client/cached_dir.c                       |   2 +-
 fs/smb/client/cifs_debug.c                       |   2 +-
 fs/smb/client/cifs_unicode.c                     |   1 -
 fs/smb/client/cifs_unicode.h                     | 330
+---------------------------------------------------------------------------------------
 fs/smb/client/cifs_uniupr.h                      | 239
----------------------------------------------------------------
 fs/smb/client/cifsfs.c                           |   2 +-
 fs/smb/client/cifsfs.h                           |  11 +--
 fs/smb/client/cifsglob.h                         |  72 ++++++++++++++++----
 fs/smb/client/cifsproto.h                        |   9 ++-
 fs/smb/client/connect.c                          |  21 +++---
 fs/smb/client/dfs.c                              | 271
+++++++++++++++++++++++++++++++++++++++---------------------------------
 fs/smb/client/dfs.h                              | 141
++++++++++++++++++++++++++++----------
 fs/smb/client/dfs_cache.c                        |  10 ++-
 fs/smb/client/dfs_cache.h                        |  12 ++--
 fs/smb/client/dir.c                              |   4 +-
 fs/smb/client/inode.c                            | 498
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------
 fs/smb/client/misc.c                             |   2 +-
 fs/smb/client/{cifs_dfs_ref.c => namespace.c}    | 113
++++++++++++++++--------------
 fs/smb/client/readdir.c                          |  23 ++-----
 fs/smb/client/sess.c                             |  72 ++++++++++++--------
 fs/smb/client/smb1ops.c                          |  26 ++++---
 fs/smb/client/smb2inode.c                        | 203
++++++++++++++++++++++++++++++------------------------
 fs/smb/client/smb2misc.c                         |   6 +-
 fs/smb/client/smb2ops.c                          | 298
+++++++++++++++++++++++++------------------------------------------------------
 fs/smb/client/smb2pdu.c                          |  19 ++++--
 fs/smb/client/smb2proto.h                        |  17 +++--
 fs/smb/client/smb2transport.c                    |   4 +-
 fs/smb/client/transport.c                        |  29 ++++----
 fs/smb/common/smb2pdu.h                          |  22 ++++++
 fs/smb/server/Kconfig                            |   1 +
 fs/smb/server/unicode.c                          |   1 -
 fs/smb/server/unicode.h                          | 325
++-------------------------------------------------------------------------------------
 43 files changed, 1377 insertions(+), 2021 deletions(-)
 delete mode 100644 fs/jfs/jfs_uniupr.c
 create mode 100644 fs/nls/nls_ucs2_data.h
 rename fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} (50%)
 create mode 100644 fs/nls/nls_ucs2_utils.h
 delete mode 100644 fs/smb/client/cifs_uniupr.h
 rename fs/smb/client/{cifs_dfs_ref.c => namespace.c} (62%)

-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[pr-tracker-bot]

The pull request you sent on Tue, 15 Aug 2023 14:59:27 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc6-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/2d7b8c6b90e4054a35eb59cd6d7c66e903e8ae4b

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
f6a691685962637e53371788fe2a72b171aedc68:

  Merge tag '6.5-rc4-smb3-client-fix' of
git://git.samba.org/sfrench/cifs-2.6 (2023-08-05 13:44:06 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc6-smb3-client-fixes

for you to fetch changes up to 7b38f6ddc97bf572c3422d3175e8678dd95502fa:

  smb3: display network namespace in debug information (2023-08-14
08:41:29 -0500)

----------------------------------------------------------------
Three smb client fixes, all for stable
- fix for oops in unmount race with lease break of deferred close
- debugging improvement for reconnect
- fix for fscache deadlock (folio_wait_bit_common hang)
----------------------------------------------------------------
Russell Harmon via samba-technical (1):
      cifs: Release folio lock on fscache read hit.

Steve French (2):
      cifs: fix potential oops in cifs_oplock_break
      smb3: display network namespace in debug information

 fs/smb/client/cifs_debug.c | 10 ++++++++++
 fs/smb/client/file.c       | 25 +++++++++++++++++--------
 2 files changed, 27 insertions(+), 8 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 29 Jul 2023 14:07:53 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc3-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d31e3792919e5c97d572c8a27a5a7c1eb9de5aca

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
6eaae198076080886b9e7d57f4ae06fa782f90ef:

  Linux 6.5-rc3 (2023-07-23 15:24:10 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc3-smb3-client-fixes

for you to fetch changes up to a171eb5cac427fa8d084eaf5e47fbe4c0f1e279f:

  cifs: add missing return value check for cifs_sb_tlink (2023-07-26
15:41:27 -0500)

----------------------------------------------------------------
Four small SMB3 client fixes
- two reconnect fixes (to address the case where non-default iocharset
gets incorrectly overridden at reconnect with the default charset)
- fix for NTLMSSP_AUTH request setting a flag incorrectly)
- Add missing check for invalid tlink (tree connection) in ioctl

----------------------------------------------------------------
Shyam Prasad N (1):
      cifs: add missing return value check for cifs_sb_tlink

Steve French (1):
      smb3: do not set NTLMSSP_VERSION flag for negotiate not auth request

Winston Wen (2):
      fs/nls: make load_nls() take a const parameter
      cifs: fix charset issue in reconnection

 fs/nls/nls_base.c        | 4 ++--
 fs/smb/client/cifsglob.h | 1 +
 fs/smb/client/cifssmb.c  | 3 +--
 fs/smb/client/connect.c  | 5 +++++
 fs/smb/client/ioctl.c    | 5 +++++
 fs/smb/client/misc.c     | 1 +
 fs/smb/client/sess.c     | 4 +++-
 fs/smb/client/smb2pdu.c  | 3 +--
 include/linux/nls.h      | 2 +-
 9 files changed, 20 insertions(+), 8 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 16 Jul 2023 09:59:59 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc1-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fe756ad0214619ac01503c37f43ca5b912d760d4

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5:

  Linux 6.5-rc1 (2023-07-09 13:53:13 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc1-smb3-fixes

for you to fetch changes up to 69cba9d3c1284e0838ae408830a02c4a063104bc:

  cifs: fix mid leak during reconnection after timeout threshold
(2023-07-14 11:25:08 -0500)

----------------------------------------------------------------
Five SMB3 client fixes
- Two reconnect fixes: important fix to address inFlight count to leak
(which can leak credits), and fix for better handling a deleted share
- DFS fix
- SMB1 cleanup fix
- deferred close fix
----------------------------------------------------------------
Bharath SM (1):
      cifs: if deferred close is disabled then close files immediately

Gustavo A. R. Silva (1):
      smb: client: Fix -Wstringop-overflow issues

Paulo Alcantara (1):
      smb: client: fix missed ses refcounting

Shyam Prasad N (2):
      cifs: is_network_name_deleted should return a bool
      cifs: fix mid leak during reconnection after timeout threshold

 fs/smb/client/cifsglob.h      |  2 +-
 fs/smb/client/cifssmb.c       |  2 +-
 fs/smb/client/connect.c       | 30 +++++++++++++++++++++++-------
 fs/smb/client/dfs.c           | 26 ++++++++++----------------
 fs/smb/client/file.c          |  4 ++--
 fs/smb/client/smb2ops.c       |  8 +++++---
 fs/smb/client/smb2transport.c |  2 +-
 7 files changed, 43 insertions(+), 31 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 8 Jul 2023 23:39:10 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4770353b660abc8b1a5d2afc233b6061d48e7d80

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
a507db1d8fdc39802415e4d2ef6d1aecd67927fa:

  Merge tag '6.5-rc-smb3-client-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2023-06-30 22:00:28 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc-smb3-client-fixes-part2

for you to fetch changes up to d14de8067e3f9653cdef5a094176d00f3260ab20:

  cifs: Add a laundromat thread for cached directories (2023-07-05
22:36:07 -0500)

----------------------------------------------------------------
3 smb3 client fixes;
- fix potential use after free in unmount
- minor cleanup fix
- add worker to cleanup stale directory leases

Not included in this P/R is the follow on patch to allow this timeout
to be configurable at mount (is being tested), as are a pair of fixes
for some cases where stale metadata can be incorrectly used, and a fix
for O_DIRECT is also not included (still being tested).

----------------------------------------------------------------
Colin Ian King (1):
      smb: client: remove redundant pointer 'server'

Ronnie Sahlberg (1):
      cifs: Add a laundromat thread for cached directories

Winston Wen (1):
      cifs: fix session state transition to avoid use-after-free issue

 fs/smb/client/cached_dir.c | 67
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/smb/client/cached_dir.h |  1 +
 fs/smb/client/connect.c    |  7 ++++---
 fs/smb/client/dfs.c        |  2 --
 4 files changed, 72 insertions(+), 5 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 30 Jun 2023 23:20:39 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a507db1d8fdc39802415e4d2ef6d1aecd67927fa

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
45a3e24f65e90a047bef86f927ebdc4c710edaa1:

  Linux 6.4-rc7 (2023-06-18 14:06:27 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc-smb3-client-fixes-part1

for you to fetch changes up to 61986a58bc6abbb1aea26e52bd269f49e5bacf19:

  cifs: new dynamic tracepoint to track ses not found errors
(2023-06-29 09:58:09 -0500)

----------------------------------------------------------------
 20 cifs/smb3 fixes, 8 for stable
- Deferred close fix
- Debugging improvements: display missing mount option, dump rc on
invalidate inode failures, print client_guid in DebugData, log session
id when matching session not found in reconnect, new dynamic
tracepoint for session not found
- Mount fixes including: potential null dereference, and possible
memory leak and path name parsing when double slashes
- Fix potential use after free in compounding
- Two crediting (flow control) fixes: fix for crediting leak (stress
scenario with excess lease credits) and better locking around updating
credits
- Three cleanups from issues pointed out by the kernel test robot
- Session state check improvements (including for potential use after free)
- DFS fixes: Fix for getattr on link when DFS disabled, fix for DFS
mounts to same share with different prefix paths, DFS mount error
checking improvement

This does not include some caching fixes/improvements and reconnect
fixes that are still being reviewed/tested.
----------------------------------------------------------------
Bharath SM (1):
      SMB3: Do not send lease break acknowledgment if all file handles
have been closed

Paulo Alcantara (9):
      smb: client: fix warning in cifs_match_super()
      smb: client: fix warning in cifs_smb3_do_mount()
      smb: client: fix warning in CIFSFindFirst()
      smb: client: fix warning in CIFSFindNext()
      smb: client: fix warning in generic_ip_connect()
      smb: client: fix broken file attrs with nodfs mounts
      smb: client: fix parsing of source mount option
      smb: client: fix shared DFS root mounts with different prefixes
      smb: client: improve DFS mount check

Shyam Prasad N (6):
      cifs: print nosharesock value while dumping mount options
      cifs: prevent use-after-free by freeing the cfile later
      cifs: do all necessary checks for credits within or before locking
      cifs: print client_guid in DebugData
      cifs: log session id when a matching ses is not found
      cifs: new dynamic tracepoint to track ses not found errors

Steve French (2):
      cifs: print more detail when invalidate_inode_mapping fails
      smb3: do not reserve too many oplock credits

Winston Wen (2):
      cifs: fix session state check in reconnect to avoid use-after-free issue
      cifs: fix session state check in smb2_find_smb_ses

 fs/smb/client/cifs_debug.c    |  17 ++++---
 fs/smb/client/cifs_dfs_ref.c  |  20 +++++---
 fs/smb/client/cifsfs.c        |  30 +++++-------
 fs/smb/client/cifsglob.h      |  10 ++--
 fs/smb/client/cifsproto.h     |   4 +-
 fs/smb/client/cifssmb.c       | 211
++++++++++++++++++++++++++++++++++++--------------------------------------------
 fs/smb/client/connect.c       |  92 ++++++++++++++++++++---------------
 fs/smb/client/dfs.c           |  96 ++++++++++--------------------------
 fs/smb/client/dfs.h           |  19 ++++----
 fs/smb/client/dfs_cache.c     |   8 +--
 fs/smb/client/file.c          |  25 +++++-----
 fs/smb/client/fs_context.c    |  59 +++++++++++++++++++----
 fs/smb/client/inode.c         |   4 +-
 fs/smb/client/misc.c          |  55 +++++++++++++++------
 fs/smb/client/smb2inode.c     |   9 ++--
 fs/smb/client/smb2ops.c       |  31 +++++++-----
 fs/smb/client/smb2pdu.c       |   6 +++
 fs/smb/client/smb2transport.c |  12 ++++-
 fs/smb/client/trace.h         |  20 ++++++++
 fs/smb/client/transport.c     |  20 ++++----
 20 files changed, 403 insertions(+), 345 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Wed, 14 Jun 2023 23:36:08 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc6-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7a043feb6cc02c9273c34392c41d17e08804a323

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
858fd168a95c5b9669aac8db6c14a9aeab446375:

  Linux 6.4-rc6 (2023-06-11 14:35:30 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc6-smb3-client-fixes

for you to fetch changes up to e4645cc2f1e2d6f268bb8dcfac40997c52432aed:

  cifs: add a warning when the in-flight count goes negative
(2023-06-14 10:15:05 -0500)

----------------------------------------------------------------
Eight smb3 client fixes
- important fix for deferred close oops (race with unmount) found with
xfstest generic/098 to some servers
- important reconnect fix
- fix problem with max_credits mount option
- two multichannel (interface related) fixes
- one trivial removal of confusing comment
- two small debugging improvements (to better spot crediting problems)

----------------------------------------------------------------
Enzo Matsumiya (1):
      smb/client: print "Unknown" instead of bogus link speed value

Shyam Prasad N (5):
      cifs: fix status checks in cifs_tree_connect
      cifs: print all credit counters in DebugData
      cifs: fix sockaddr comparison in iface_cmp
      cifs: fix max_credits implementation
      cifs: add a warning when the in-flight count goes negative

Steve French (1):
      cifs: fix lease break oops in xfstest generic/098

鑫华 (1):
      smb: remove obsolete comment

 fs/smb/client/cifs_debug.c | 58
++++++++++++++++++++++++++++++++++++++++++++++++++++++----
 fs/smb/client/cifsglob.h   | 37 -------------------------------------
 fs/smb/client/cifsproto.h  |  1 +
 fs/smb/client/connect.c    | 59
+++++++++++++++++++++++++++++++++++++++++++++++++++++++----
 fs/smb/client/dfs.c        |  9 +++++----
 fs/smb/client/file.c       |  8 ++++++--
 fs/smb/client/smb2ops.c    | 40 ++++++++++++++++++++++++++++++++++++++++
 fs/smb/client/smb2pdu.c    | 32 ++++++++++++++++++++++++++++----
 fs/smb/client/transport.c  |  2 +-
 9 files changed, 190 insertions(+), 56 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 20 May 2023 23:52:37 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/0c9dcf128ef99c257dcde5dbb8683605009906bf

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6:

  Linux 6.4-rc2 (2023-05-14 12:51:40 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc2-smb3-client-fixes

for you to fetch changes up to 59a556aebc43dded08535fe97d94ca3f657915e4:

  SMB3: drop reference to cfile before sending oplock break
(2023-05-17 12:04:41 -0500)

----------------------------------------------------------------
2 smb3 client fixes, both related to deferred close (also for stable)

- send close for deferred handles before not after lease break
response to avoid possible sharing violations
- check all opens on an inode (looking for deferred handles) when
lease break is returned not just the handle the lease break came in
on.

----------------------------------------------------------------
Bharath SM (2):
      SMB3: Close all deferred handles of inode in case of handle lease break
      SMB3: drop reference to cfile before sending oplock break

 fs/cifs/cifsglob.h |  4 ++--
 fs/cifs/file.c     | 26 +++++++++++++-------------
 fs/cifs/smb1ops.c  |  9 ++++-----
 fs/cifs/smb2ops.c  |  7 +++----
 4 files changed, 22 insertions(+), 24 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 12 May 2023 14:21:05 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc1-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fd88f147cb121c9c748ca0d4c5155a96e9d81e58

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
ac9a78681b921877518763ba0e89202254349d1b:

  Linux 6.4-rc1 (2023-05-07 13:34:35 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc1-smb3-client-fixes

for you to fetch changes up to d39fc592ef8ae9a89c5e85c8d9f760937a57d5ba:

  cifs: release leases for deferred close handles when freezing
(2023-05-10 17:48:30 -0500)

----------------------------------------------------------------
6 smb3 client fixes, most also for stable
- fix for copy_file_range bug for very large files that are multiples of rsize
- do not ignore "isolated transport" flag if set on share
- set rasize default better
- three fixes related to shutdown and freezing (fixes 4 xfstests, and
closes deferred handles faster in some places that were missed)
----------------------------------------------------------------
Pawel Witek (1):
      cifs: fix pcchunk length type in smb2_copychunk_range

Steve French (5):
      do not reuse connection if share marked as isolated
      smb3: improve parallel reads of large files
      SMB3: force unmount was failing to close deferred close files
      smb3: fix problem remounting a share after shutdown
      cifs: release leases for deferred close handles when freezing

 fs/cifs/cifsfs.c  | 18 +++++++++++++++++-
 fs/cifs/connect.c |  7 +++++++
 fs/cifs/smb2ops.c |  2 +-
 fs/cifs/smb2pdu.c |  3 +++
 4 files changed, 28 insertions(+), 2 deletions(-)

--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 6 May 2023 15:45:24 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/63342b1dd5f884d97b41b0cd04fae01a69e0a762

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
26c009dffca89b0f8fe7facc41d1ccf88a66825a:

  Merge tag '6.4-rc-smb3-client-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2023-05-01 10:43:44 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc-smb3-client-fixes-part2

for you to fetch changes up to 9ee04875ae73412f5071f6ec1af01788ec271e7c:

  cifs: Remove unneeded semicolon (2023-05-05 04:29:58 -0500)

----------------------------------------------------------------
9 smb3 client fixes, mostly DFS or reconnect related (six also for stable)
- Two DFS connection sharing fixes
- DFS refresh fix
- Reconnect fix
- Two potential use after free fixes
- Also print prefix patch in mount debug msg
- Two small cleanup fixes
----------------------------------------------------------------
Paulo Alcantara (7):
      cifs: protect session status check in smb2_reconnect()
      cifs: print smb3_fs_context::source when mounting
      cifs: fix potential use-after-free bugs in TCP_Server_Info::hostname
      cifs: fix potential race when tree connecting ipc
      cifs: protect access of TCP_Server_Info::{origin,leaf}_fullpath
      cifs: avoid potential races when handling multiple dfs tcons
      cifs: fix sharing of DFS connections

Steve French (1):
      SMB3.1.1: correct definition for app_instance_id create contexts

Yang Li (1):
      cifs: Remove unneeded semicolon

 fs/cifs/cifs_debug.c      |   7 +++-
 fs/cifs/cifs_debug.h      |  12 +++---
 fs/cifs/cifsfs.c          |  14 +++----
 fs/cifs/cifsglob.h        |  23 ++++++-----
 fs/cifs/cifsproto.h       |  44 ++++++++++++++++++++-
 fs/cifs/connect.c         | 141
+++++++++++++++++++++++++++++++++++++------------------------------
 fs/cifs/dfs.c             | 137
++++++++++++++++++++++++++++++++++++++++++++++++++---------------
 fs/cifs/dfs.h             |  13 ++++++-
 fs/cifs/dfs_cache.c       | 133
+++++++++++++++++++++++++++++----------------------------------
 fs/cifs/dfs_cache.h       |   9 +++++
 fs/cifs/ioctl.c           |   2 +-
 fs/cifs/sess.c            |   7 ++--
 fs/cifs/smb2pdu.c         |  21 ++++++----
 fs/ksmbd/smb2pdu.h        |  16 --------
 fs/smbfs_common/smb2pdu.h |  20 ++++++++++
 15 files changed, 376 insertions(+), 223 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 30 Apr 2023 10:35:04 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/26c009dffca89b0f8fe7facc41d1ccf88a66825a

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
457391b0380335d5e9a5babdec90ac53928b23b4:

  Linux 6.3 (2023-04-23 12:02:52 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.4-rc-smb3-client-fixes-part1

for you to fetch changes up to 9be11a69315e26363a4de8930bc50d0901a96775:

  cifs: update internal module version number for cifs.ko (2023-04-28
22:50:42 -0500)

----------------------------------------------------------------
11 smb3 client fixes, mostly cleanup
- deferred close fixe for an important case when cached file should be
closed immediately)
- two fixes for missing locks
- eight minor cleanup

Am still working on testing some additional patches, and also
expecting a set of fixes from Paulo and Bharath later in the week.
----------------------------------------------------------------
Bharath SM (2):
      SMB3: Add missing locks to protect deferred close file list
      SMB3: Close deferred file handles in case of handle lease break

Steve French (5):
      cifs: missing lock when updating session status
      SMB3.1.1: add new tree connect ShareFlags
      smb3: make query_on_disk_id open context consistent and move to
common code
      smb3: move some common open context structs to smbfs_common
      cifs: update internal module version number for cifs.ko

Volker Lendecke (4):
      cifs: Simplify SMB2_open_init()
      cifs: Simplify SMB2_open_init()
      cifs: Simplify SMB2_open_init()
      cifs: Avoid a cast in add_lease_context()

 fs/cifs/cifsfs.h          |   4 ++--
 fs/cifs/connect.c         |   8 ++++++--
 fs/cifs/file.c            |  16 ++++++++++++++++
 fs/cifs/misc.c            |   8 +++++++-
 fs/cifs/smb2pdu.c         | 115
++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------
 fs/cifs/smb2pdu.h         |  20 --------------------
 fs/ksmbd/smb2pdu.h        |  33 ---------------------------------
 fs/smbfs_common/smb2pdu.h |  56
++++++++++++++++++++++++++++++++++++++++++++++++--------
 8 files changed, 109 insertions(+), 151 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 21 Apr 2023 21:43:50 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc7-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/84ebdb8e0d9ca261d73677f345814505af172ae0

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
6a8f57ae2eb07ab39a6f0ccad60c760743051026:

  Linux 6.3-rc7 (2023-04-16 15:23:53 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc7-smb3-client-fixes

for you to fetch changes up to 023fc150a39ffe656da3e459ad801eb1c7fdfad9:

  cifs: Reapply lost fix from commit 30b2b2196d6e (2023-04-18 21:26:09 -0500)

----------------------------------------------------------------
Three small smb3 client fixes
- two important fixes for unbuffered read regression with the iov_iter
changes (e.g. read soon after mount in some multichannel scenarios)
- DFS prefix path fix (also for stable)
----------------------------------------------------------------
David Howells (2):
      cifs: Fix unbuffered read
      cifs: Reapply lost fix from commit 30b2b2196d6e

Paulo Alcantara (1):
      cifs: avoid dup prefix path in dfs_get_automount_devname()

 fs/cifs/cifs_dfs_ref.c |  2 --
 fs/cifs/dfs.h          | 22 ++++++++++++++++++----
 fs/cifs/file.c         |  4 ----
 fs/cifs/smb2pdu.c      | 10 ++++++----
 4 files changed, 24 insertions(+), 14 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 8 Apr 2023 18:34:20 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc5-smb3-cifs-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/cdc9718d5e590d6905361800b938b93f2b66818e

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull The following changes since commit
7e364e56293bb98cae1b55fd835f5991c4e96e7d:

  Linux 6.3-rc5 (2023-04-02 14:29:29 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc5-smb3-cifs-client-fixes

for you to fetch changes up to 4f5d5b33fc400911d6e1f49095522b361d9cbe13:

  cifs: double lock in cifs_reconnect_tcon() (2023-04-06 22:45:41 -0500)

----------------------------------------------------------------
two small cifs/smb3 client fixes, one for stable
- double lock fix for a cifs/smb1 reconnect path
- DFS prefixpath fix for reconnect when server moved
----------------------------------------------------------------
Dan Carpenter (1):
      cifs: double lock in cifs_reconnect_tcon()

Thiago Rafael Becker (1):
      cifs: sanitize paths in cifs_update_super_prepath.

 fs/cifs/cifssmb.c    |  2 +-
 fs/cifs/fs_context.c | 13 +++++++------
 fs/cifs/fs_context.h |  3 +++
 fs/cifs/misc.c       |  2 +-
 4 files changed, 12 insertions(+), 8 deletions(-)



-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 1 Apr 2023 16:32:58 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc4-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f7772da66255ab2b478a33df404a335fab55cc25

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
197b6b60ae7bc51dd0814953c562833143b292aa:

  Linux 6.3-rc4 (2023-03-26 14:40:20 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc4-smb3-client-fixes

for you to fetch changes up to e03677100707f849f01d8faf07ee58b4e56cdbf1:

  cifs: get rid of dead check in smb2_reconnect() (2023-03-30 17:56:30 -0500)

----------------------------------------------------------------
Four cifs/smb3 client (reconnect and DFS related) fixes, including two
for stable:
- DFS oops fix
- DFS reconnect recursion fix
- An SMB1 parallel reconnect fix
- Trivial dead code removal in smb2_reconnect

This P/R does not include the important deferred close lease break fix
(additional changes were needed for that).
----------------------------------------------------------------
David Disseldorp (1):
      cifs: fix DFS traversal oops without CONFIG_CIFS_DFS_UPCALL

Paulo Alcantara (3):
      cifs: avoid races in parallel reconnects in smb1
      cifs: prevent infinite recursion in CIFSGetDFSRefer()
      cifs: get rid of dead check in smb2_reconnect()

 fs/cifs/cifsfs.h  |  5 ++++-
 fs/cifs/cifssmb.c | 30 ++++++++++++++++++++++--------
 fs/cifs/smb2pdu.c |  1 -
 3 files changed, 26 insertions(+), 10 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 16 Mar 2023 15:39:53 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/38e04b3e4240a6d8fb43129ebad41608db64bc6f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
fe15c26ee26efa11741a7b632e9f23b01aca4cc6:

  Linux 6.3-rc1 (2023-03-05 14:52:03 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc2-smb3-client-fixes

for you to fetch changes up to 6284e46bdd47743a064fe6ac834a7ac05b1fd206:

  cifs: use DFS root session instead of tcon ses (2023-03-14 22:48:53 -0500)

----------------------------------------------------------------
seven cifs/smb3 client fixes, all also for stable
- four DFS fixes
- multichannel reconnect fix
- fix smb1 stats for cancel command
- fix for set file size error path
----------------------------------------------------------------
Paulo Alcantara (4):
      cifs: set DFS root session in cifs_get_smb_ses()
      cifs: fix use-after-free bug in refresh_cache_worker()
      cifs: return DFS root session id in DebugData
      cifs: use DFS root session instead of tcon ses

Shyam Prasad N (1):
      cifs: generate signkey for the channel that's reconnecting

Volker Lendecke (1):
      cifs: Fix smb2_set_path_size()

Zhang Xiaoxu (1):
      cifs: Move the in_send statistic to __smb_send_rqst()

 fs/cifs/cifs_debug.c    |   5 +++
 fs/cifs/cifs_dfs_ref.c  |   1 +
 fs/cifs/cifs_fs_sb.h    |   2 -
 fs/cifs/cifsglob.h      |   4 +-
 fs/cifs/connect.c       |  10 ++---
 fs/cifs/dfs.c           |  67 ++++++++++++++++++----------
 fs/cifs/dfs.h           |  19 +++++++-
 fs/cifs/dfs_cache.c     | 140
-----------------------------------------------------------
 fs/cifs/dfs_cache.h     |   2 -
 fs/cifs/fs_context.h    |   1 +
 fs/cifs/misc.c          |   8 ++++
 fs/cifs/smb2inode.c     |  31 ++++++++++---
 fs/cifs/smb2transport.c |   2 +-
 fs/cifs/transport.c     |  21 ++++-----
 14 files changed, 118 insertions(+), 195 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 3 Mar 2023 17:29:17 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3162745aad939af6b8bc00951d1344ee872526a9

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
ab7362d04d7c14923420c1e19e889da512a65cd7:

  cifs: Fix cifs_writepages_region() (2023-02-24 11:01:58 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc-smb3-client-fixes-part2

for you to fetch changes up to 71562809e401b2f5ad371d99ce0323e988406fd6:

  cifs: Fix memory leak in direct I/O (2023-03-01 18:18:25 -0600)

----------------------------------------------------------------
9 cifs/smb3 client fixes
- xfstest generic/208 fix (memory leak)
- minor netfs fix (to address smatch warning)
- a DFS fix for stable
- a reconnect race fix
- two multichannel fixes
- RDMA (smbdirect) fix
- two additional writeback fixes from David

----------------------------------------------------------------
David Howells (5):
      cifs: Add some missing xas_retry() calls
      cifs: Fix an uninitialised variable
      cifs: Fix cifs_write_back_from_locked_folio()
      iov: Fix netfs_extract_user_to_sg()
      cifs: Fix memory leak in direct I/O

Paulo Alcantara (2):
      cifs: improve checking of DFS links over STATUS_OBJECT_NAME_INVALID
      cifs: prevent data race in cifs_reconnect_tcon()

Shyam Prasad N (2):
      cifs: match even the scope id for ipv6 addresses
      cifs: reuse cifs_match_ipaddr for comparison of dstaddr too

 fs/cifs/cifsproto.h |  21 +++++++---
 fs/cifs/cifssmb.c   |  43 ++------------------
 fs/cifs/connect.c   |  31 ++-------------
 fs/cifs/file.c      |  11 +++++-
 fs/cifs/misc.c      | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/cifs/smb2inode.c |  21 +++++-----
 fs/cifs/smb2ops.c   |  23 ++++++-----
 fs/cifs/smb2pdu.c   |  82 ++++++++++----------------------------
 fs/cifs/smbdirect.c |   2 +-
 fs/netfs/iterator.c |   2 +-
 10 files changed, 190 insertions(+), 157 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Wed, 22 Feb 2023 18:02:29 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/307e14c039063f0c9bd7a18a7add8f940580dcc9

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
c9c3395d5e3dcc6daee66c6908354d47bf98cb0c:

  Linux 6.2 (2023-02-19 14:24:22 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.3-rc-smb3-client-fixes

for you to fetch changes up to fdbf807215250217c83f1cb715b883cd910102fa:

  update internal module version number for cifs.ko (2023-02-21 01:25:44 -0600)

----------------------------------------------------------------
46 fs/cifs (smb3 client) changesets, 37 for the fs/cifs directory and 9
outside (for related helper functions and cleanup of now unused
functions) from David Howells and Willy.

Note that there's a conflict with the mm tree with regard to the
replacement of find_get_pages_range_tag() with
filemap_get_folios_tag() which can be resolved by the patch David
provided: https://lore.kernel.org/lkml/2885897.1676990364@warthog.procyon.org.uk/
or what Stephen Rothwell did:
https://lore.kernel.org/lkml/20230222134927.459b036b@canb.auug.org.au/
in linux-next

The largest subset of this P/R is from David Howells et al: making the cifs/smb3
driver pass iov_iters down to the lowest layers, directly to the
network transport rather than passing lists of pages around, helping
multiple areas:
 (-) Pin user pages, thereby fixing the race between concurrent DIO read and
     fork, where the pages containing the DIO read buffer may end up
     belonging to the child process and not the parent - with the result
     that the parent might not see the retrieved data.
 (-) cifs shouldn't take refs on pages extracted from non-user-backed
     iterators (eg. KVEC).  With these changes, cifs will apply the
     appropriate cleanup.
 (-) Making it easier to transition to using folios in cifs rather than
     pages by dealing with them through BVEC and XARRAY iterators.
 (-) Allowing cifs to use the new splice function

The remainder are:
- ten fixes for stable, including various fixes for uninitialized
memory, wrong length field causing mount issue to very old servers,
important directory lease fixes and reconnect fixes
- 9 cleanups (unused code removal, change one element array usage, and
a change form strtobool to kstrtobool, and 2 Kconfig cleanups)
- 6 SMBDIRECT (RDMA) fixes including iov_iter integration and UAF fixes
- 2 reconnect fixes
- 3 multichannel fixes, including improving channel allocation (to
least used channel)
- remove last use of lock_page_killable by moving to folio_lock_killable

Also FYI there are additional important directory lease (metadata
caching fixes) and multichannel fixes being tested that are not
included in this P/R but should be ready next week.  And two small
fixes to David's series were also identified that I can send next week
(I also wanted to reduce risk of merge conflicts)
----------------------------------------------------------------
Andy Shevchenko (1):
      cifs: Get rid of unneeded conditional in the smb2_get_aead_req()

Christophe JAILLET (1):
      cifs: Use kstrtobool() instead of strtobool()

David Howells (17):
      mm: Pass info, not iter, into filemap_get_pages()
      splice: Add a func to do a splice from a buffered file without ITER_PIPE
      splice: Add a func to do a splice from an O_DIRECT file without ITER_PIPE
      iov_iter: Define flags to qualify page extraction.
      iov_iter: Add a function to extract a page list from an iterator
      splice: Export filemap/direct_splice_read()
      cifs: Implement splice_read to pass down ITER_BVEC not ITER_PIPE
      netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator
      netfs: Add a function to extract an iterator into a scatterlist
      cifs: Add a function to build an RDMA SGE list from an iterator
      cifs: Add a function to Hash the contents of an iterator
      cifs: Add some helper functions
      cifs: Add a function to read into an iter from a socket
      cifs: Change the I/O paths to use an iterator rather than a page list
      cifs: Build the RDMA SGE list directly from an iterator
      cifs: Remove unused code
      cifs: DIO to/from KVEC-type iterators should now work

Gustavo A. R. Silva (1):
      cifs: Replace zero-length arrays with flexible-array members

Kees Cook (3):
      cifs: Convert struct fealist away from 1-element array
      cifs: Replace remaining 1-element arrays
      smb3: Replace smb2pdu 1-element arrays with flex-arrays

Matthew Wilcox (Oracle) (2):
      cifs: Use a folio in cifs_page_mkwrite()
      filemap: Remove lock_page_killable()

Namjae Jeon (1):
      cifs: remove unneeded 2bytes of padding from smb2 tree connect

Paulo Alcantara (4):
      cifs: prevent data race in smb2_reconnect()
      cifs: get rid of unneeded conditional in cifs_get_num_sgs()
      cifs: fix mount on old smb servers
      cifs: get rid of dns resolve worker

Ronnie Sahlberg (2):
      cifs: Check the lease context if we actually got a lease
      cifs: return a single-use cfid if we did not get a lease

Shyam Prasad N (4):
      cifs: print last update time for interface list
      cifs: use the least loaded channel for sending requests
      cifs: use tcon allocation functions even for dummy tcon
      cifs: update ip_addr for ses only for primary chan setup

Stefan Metzmacher (3):
      cifs: introduce cifs_io_parms in smb2_async_writev()
      cifs: split out smb3_use_rdma_offload() helper
      cifs: don't try to use rdma offload on encrypted connections

Steve French (3):
      cifs: update Kconfig description
      cifs: fix indentation in make menuconfig options
      update internal module version number for cifs.ko

Volker Lendecke (2):
      cifs: Fix uninitialized memory read in smb3_qfs_tcon()
      cifs: Fix uninitialized memory reads for oparms.mode

Zhang Xiaoxu (2):
      cifs: Fix lost destroy smbd connection when MR allocate failed
      cifs: Fix warning and UAF when destroy the MR list

 block/bio.c               |    6 +-
 block/blk-map.c           |    8 +-
 fs/cifs/Kconfig           |   66 ++--
 fs/cifs/cached_dir.c      |   43 ++-
 fs/cifs/cifs_debug.c      |   11 +-
 fs/cifs/cifs_spnego.h     |    2 +-
 fs/cifs/cifsacl.c         |   34 +-
 fs/cifs/cifsencrypt.c     |  172 ++++++++--
 fs/cifs/cifsfs.c          |   12 +-
 fs/cifs/cifsfs.h          |    8 +-
 fs/cifs/cifsglob.h        |   81 +++--
 fs/cifs/cifspdu.h         |   98 +++---
 fs/cifs/cifsproto.h       |   11 +-
 fs/cifs/cifssmb.c         |   48 ++-
 fs/cifs/connect.c         |  179 ++++------
 fs/cifs/dir.c             |   19 +-
 fs/cifs/file.c            | 1810
+++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------
 fs/cifs/fscache.c         |   22 +-
 fs/cifs/fscache.h         |   10 +-
 fs/cifs/inode.c           |   53 +--
 fs/cifs/link.c            |   66 ++--
 fs/cifs/misc.c            |  128 +------
 fs/cifs/ntlmssp.h         |    4 +-
 fs/cifs/readdir.c         |    6 +-
 fs/cifs/sess.c            |    1 -
 fs/cifs/smb1ops.c         |   72 ++--
 fs/cifs/smb2file.c        |    2 +-
 fs/cifs/smb2inode.c       |   17 +-
 fs/cifs/smb2misc.c        |    2 +-
 fs/cifs/smb2ops.c         |  606 ++++++++++++++++-----------------
 fs/cifs/smb2pdu.c         |  291 +++++++++-------
 fs/cifs/smb2pdu.h         |    4 +-
 fs/cifs/smbdirect.c       |  539 +++++++++++++++++------------
 fs/cifs/smbdirect.h       |    7 +-
 fs/cifs/transport.c       |   87 ++---
 fs/ksmbd/smb2ops.c        |    8 +-
 fs/ksmbd/smb2pdu.c        |    6 +-
 fs/netfs/Makefile         |    1 +
 fs/netfs/iterator.c       |  371 ++++++++++++++++++++
 fs/smbfs_common/smb2pdu.h |   42 ++-
 fs/splice.c               |   93 +++++
 include/linux/fs.h        |    6 +
 include/linux/netfs.h     |    8 +
 include/linux/pagemap.h   |   10 -
 include/linux/pipe_fs_i.h |   20 ++
 include/linux/uio.h       |   35 +-
 lib/iov_iter.c            |  284 +++++++++++++++-
 mm/filemap.c              |  157 ++++++++-
 mm/internal.h             |    6 +
 mm/vmalloc.c              |    1 +
 50 files changed, 3220 insertions(+), 2353 deletions(-)
 create mode 100644 fs/netfs/iterator.c

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 20 Jan 2023 15:23:33 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc4-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4e31badaa188d0e2923f5082c041083c05bda3ff

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
5dc4c995db9eb45f6373a956eb1f69460e69e6d4:

  Linux 6.2-rc4 (2023-01-15 09:22:43 -0600)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc4-smb3-client-fixes

for you to fetch changes up to a1b7c8457ecc062f612a1aca174c2e1c21f9ac10:

  cifs: remove unused function (2023-01-18 14:49:51 -0600)

----------------------------------------------------------------
8 smb3 client fixes
- important fix for packet signature calculation error
- three fixes to correct DFS deadlock, and DFS refresh problem
- remove an unused DFS function, and duplicate tcon refresh code
- DFS cache lookup fix
- uninitialized rc fix
----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: do not include page data when checking signature

Paulo Alcantara (7):
      cifs: fix potential deadlock in cache_refresh_path()
      cifs: avoid re-lookups in dfs_cache_find()
      cifs: don't take exclusive lock for updating target hints
      cifs: remove duplicate code in __refresh_tcon()
      cifs: handle cache lookup errors different than -ENOENT
      cifs: fix return of uninitialized rc in dfs_cache_update_tgthint()
      cifs: remove unused function

 fs/cifs/dfs_cache.c | 243
+++++++++++++++++++++++++++++++-----------------------------------------------
 fs/cifs/dfs_cache.h |   3 -
 fs/cifs/smb2pdu.c   |  15 +++--
 3 files changed, 105 insertions(+), 156 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 13 Jan 2023 19:19:09 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc3-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b35ad63eeccadbcc83f295a64a029f7e7188444f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
b7bfaa761d760e72a969d116517eaa12e404c262:

  Linux 6.2-rc3 (2023-01-08 11:49:43 -0600)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc3-smb3-client-fixes

for you to fetch changes up to a152d05ae4a71d802d50cf9177dba34e8bb09f68:

  cifs: Fix uninitialized memory read for smb311 posix symlink create
(2023-01-12 09:51:48 -0600)

----------------------------------------------------------------
7 smb3 client fixes, most also for stable
- memory leak and double free fix
- two symlink fixes
- minor cleanup fix
- two smb1 fixes

----------------------------------------------------------------
Colin Ian King (1):
      cifs: remove redundant assignment to the variable match

Paulo Alcantara (5):
      cifs: fix file info setting in cifs_query_path_info()
      cifs: fix file info setting in cifs_open_file()
      cifs: fix double free on failed kerberos auth
      cifs: do not query ifaces on smb1 mounts
      cifs: fix potential memory leaks in session setup

Volker Lendecke (1):
      cifs: Fix uninitialized memory read for smb311 posix symlink create

 fs/cifs/cifsencrypt.c |  1 +
 fs/cifs/connect.c     |  9 +++++---
 fs/cifs/dfs_cache.c   |  1 -
 fs/cifs/link.c        |  1 +
 fs/cifs/sess.c        |  2 ++
 fs/cifs/smb1ops.c     | 63 +++++++++++++++++++++++++++------------------------
 fs/cifs/smb2pdu.c     |  6 ++++-
 7 files changed, 49 insertions(+), 34 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Tue, 20 Dec 2022 15:49:40 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/0a924817d2ed9396401e0557c6134276d2e26382

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
851f657a86421dded42b6175c6ea0f4f5e86af97:

  Merge tag '6.2-rc-smb3-client-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2022-12-15 14:53:14 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc-smb3-client-fixes-part2

for you to fetch changes up to aacfc939cc42293fbcfe113040b4e8abaef68429:

  cifs: update internal module number (2022-12-19 08:04:50 -0600)

As mentioned in the earlier smb3 client P/R, last week we were still
testing various additional important fixes: a series of DFS and reconnect
fixes from Paulo, which are now included in this P/R
----------------------------------------------------------------
20 cifs/smb3 client fixes, mostly related to reconnect and/or DFS

- two important reconnect fixes: cases where status of recently connected IPCs
and shares were not being updated leaving them in an incorrect state
- fix for older Windows servers that would return STATUS_OBJECT_NAME_INVALID
to query info requests on DFS links in a namespace that contained non-ASCII
characters, reducing number of wasted roundtrips.
- fix for leaked -ENOMEM to userspace when cifs.ko couldn't perform I/O due
to a disconnected server, expired or deleted session.
- removal of all unneeded DFS related mount option string parsing (now using
fs_context for automounts)
-improve clarity/readability, moving various DFS related functions out
of fs/cifs/connect.c
(which was getting too big to be readable) to new file.
- Fix problem when large number of DFS connections.  Allow sharing of DFS
connections and fix how the referral paths are matched
- Referral caching fix: Instead of looking up ipc connections to
refresh cached referrals,
store direct dfs root server's IPC pointer in new sessions so can
simply access it to
either refresh or create a new referral that such connections belong to.
- Fix to allow dfs root server's connections to also failover
- Optimized reconnect of nested DFS links
- Set correct status of IPC connections marked for reconnect
----------------------------------------------------------------
Paulo Alcantara (19):
      cifs: set correct tcon status after initial tree connect
      cifs: set correct ipc status after initial tree connect
      cifs: reduce roundtrips on create/qinfo requests
      cifs: use fs_context for automounts
      cifs: get rid of mount options string parsing
      cifs: remove unused smb3_fs_context::mount_options
      cifs: set resolved ip in sockaddr
      cifs: split out ses and tcon retrieval from mount_get_conns()
      cifs: share dfs connections and supers
      cifs: don't refresh cached referrals from unactive mounts
      cifs: fix refresh of cached referrals
      cifs: refresh root referrals
      cifs: don't block in dfs_cache_noreq_update_tgthint()
      cifs: fix confusing debug message
      cifs: fix source pathname comparison of dfs supers
      cifs: optimize reconnect of nested links
      cifs: set correct status of tcon ipc when reconnecting
      cifs: use origin fullpath for automounts
      cifs: don't leak -ENOMEM in smb2_open_file()

Steve French (1):
      cifs: update internal module number

 fs/cifs/Makefile       |   2 +-
 fs/cifs/cifs_debug.c   |   8 +
 fs/cifs/cifs_dfs_ref.c | 255 +++++++-------------------------
 fs/cifs/cifsfs.c       |   6 -
 fs/cifs/cifsfs.h       |   4 +-
 fs/cifs/cifsglob.h     |  18 ++-
 fs/cifs/cifsproto.h    |  14 +-
 fs/cifs/connect.c      | 899
++++++++++++++++++---------------------------------------------------------------------------------------------
 fs/cifs/dfs.c          | 544
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/cifs/dfs.h          |  46 ++++++
 fs/cifs/dfs_cache.c    | 276 +++++++---------------------------
 fs/cifs/dfs_cache.h    |   2 +-
 fs/cifs/dir.c          |  21 ++-
 fs/cifs/dns_resolve.c  |  49 +++---
 fs/cifs/dns_resolve.h  |   4 +-
 fs/cifs/fs_context.c   |  13 +-
 fs/cifs/fs_context.h   |   3 +-
 fs/cifs/inode.c        |   6 -
 fs/cifs/misc.c         |  81 ++--------
 fs/cifs/smb2file.c     |   4 +-
 fs/cifs/smb2inode.c    |  46 ++++--
 fs/cifs/smb2ops.c      |  28 +++-
 22 files changed, 991 insertions(+), 1338 deletions(-)
 create mode 100644 fs/cifs/dfs.c
 create mode 100644 fs/cifs/dfs.h


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 15 Dec 2022 16:40:44 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/851f657a86421dded42b6175c6ea0f4f5e86af97

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
76dcd734eca23168cb008912c0f69ff408905235:

  Linux 6.1-rc8 (2022-12-04 14:48:12 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.2-rc-smb3-client-fixes-part1

for you to fetch changes up to d74f4a3f6d88a2416564bc6bf937e423a4ae8f8e:

  cifs: Remove duplicated include in cifsglob.h (2022-12-13 22:54:40 -0600)

There is a slightly larger set of fixes being tested, which is not
included in this
P/R since need to be tested a bit more: e.g. 12 patches from Paulo
(mostly DFS related fixes) and also two performance fixes and a
security (password expired) fix, but I wanted to at least get these
easier ones in that have been in for-next for longer.
----------------------------------------------------------------
13 cifs/smb3 client fixes
- 2 SMB3.1.1 POSIX Extensions fixes
- 3 patches to remove cifs_writepages
- 2 memory management fixes
- 2 mount parm parsing fixes
- 4 minor cleanup fixes
----------------------------------------------------------------
Christoph Hellwig (3):
      cifs: wire up >migrate_folio
      cifs: stop using generic_writepages
      cifs: remove ->writepage

Paulo Alcantara (2):
      cifs: skip alloc when request has no pages
      cifs: fix oops during encryption

Steve French (4):
      cifs: minor cleanup of some headers
      cifs: fix various whitespace errors in headers
      cifs: fix missing display of three mount options
      cifs: print warning when conflicting soft vs. hard mount options specified

Volker Lendecke (3):
      Fix path in cifs/usage.rst
      cifs: Add "extbuf" and "extbuflen" args to smb2_compound_op()
      cifs: Parse owner/group for stat in smb311 posix extensions

Yang Li (1):
      cifs: Remove duplicated include in cifsglob.h

 Documentation/admin-guide/cifs/usage.rst |   2 +-
 fs/cifs/cifs_ioctl.h                     |   2 +-
 fs/cifs/cifsfs.c                         |   8 ++++-
 fs/cifs/cifsfs.h                         |   4 +--
 fs/cifs/cifsglob.h                       |  76
++++++++++++++++++++++++++++++++++++++++++--
 fs/cifs/cifspdu.h                        |  50 ++++++++++++-----------------
 fs/cifs/cifsproto.h                      |   6 ++--
 fs/cifs/file.c                           |  36 +++++++++++++--------
 fs/cifs/fs_context.c                     |  11 +++++--
 fs/cifs/inode.c                          |  13 +++++---
 fs/cifs/misc.c                           |   4 +--
 fs/cifs/smb2inode.c                      |  68
++++++++++++++++++++++++++++++++-------
 fs/cifs/smb2ops.c                        | 179
+++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------
 fs/cifs/smb2proto.h                      |   5 ++-
 14 files changed, 298 insertions(+), 166 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 26 Nov 2022 22:44:50 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc6-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/30a853c1bdede177adedd2de537ea16158125181

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
926028aaa3827554096d42ffb0c2973bc7f5e80f:

  Merge tag '6.1-rc5-smb3-fixes' of
git://git.samba.org/sfrench/cifs-2.6 (2022-11-19 08:58:58 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc6-smb3-fixes

for you to fetch changes up to 502487847743018c93d75b401eac2ea4c4973123:

  cifs: fix missing unlock in cifs_file_copychunk_range() (2022-11-21
10:27:03 -0600)

----------------------------------------------------------------
Two small cifs/smb3 client fixes:
- an unlock missing in an error path in copychunk_range found by xfstest 476
- a fix for a use after free in a debug code path
----------------------------------------------------------------
ChenXiaoSong (1):
      cifs: fix missing unlock in cifs_file_copychunk_range()

Dan Carpenter (1):
      cifs: Use after free in debug code

 fs/cifs/cifsfs.c | 4 +++-
 fs/cifs/sess.c   | 4 ++--


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 18 Nov 2022 23:02:22 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc5-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/926028aaa3827554096d42ffb0c2973bc7f5e80f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
f0c4d9fc9cc9462659728d168387191387e903cc:

  Linux 6.1-rc4 (2022-11-06 15:07:11 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc5-smb3-fixes

for you to fetch changes up to a51e5d293dd1c2e7bf6f7be788466cd9b5d280fb:

  cifs: add check for returning value of SMB2_set_info_init
(2022-11-16 12:24:26 -0600)

----------------------------------------------------------------
4 small cifs/smb3 client fixes:
- two missing and one incorrect return value checks
- fix leak on tlink mount failure

----------------------------------------------------------------
Anastasia Belova (2):
      cifs: add check for returning value of SMB2_close_init
      cifs: add check for returning value of SMB2_set_info_init

Zhang Xiaoxu (2):
      cifs: Fix connections leak when tlink setup failed
      cifs: Fix wrong return value checking when GETFLAGS

 fs/cifs/connect.c | 14 +++++++++++---
 fs/cifs/ioctl.c   |  4 ++--
 fs/cifs/smb2ops.c |  4 ++++
 3 files changed, 17 insertions(+), 5 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 6 Nov 2022 00:07:38 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc4-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/90153f928bee544c794a2410afba6d936a09edce

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
30a0b95b1335e12efef89dd78518ed3e4a71a763:

  Linux 6.1-rc3 (2022-10-30 15:19:28 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc4-smb3-fixes

for you to fetch changes up to 542228db2f28fdf775b301f2843e1fe486e7c797:

  cifs: fix use-after-free on the link name (2022-11-04 23:36:54 -0500)

----------------------------------------------------------------
3 cifs/smb3 fixes,
- one for symlink handling race (fixes a bug spotted with KASAN)
- two fix multichannel issues with iterating channels instead of using
the primary channel. The
more important one fixes a bug when leases are disabled (ie using
oplocks instead) that was
spotted with xfstest generic/013 timing out

----------------------------------------------------------------
ChenXiaoSong (1):
      cifs: fix use-after-free on the link name

Shyam Prasad N (2):
      cifs: always iterate smb sessions using primary channel
      cifs: avoid unnecessary iteration of tcp sessions

 fs/cifs/cifsfs.c        | 26 +++++++++++++++++++++++++-
 fs/cifs/inode.c         |  5 -----
 fs/cifs/misc.c          |  6 +++++-
 fs/cifs/smb2misc.c      | 81
+++++++++++++++++++++++++++++++++++++++++++++------------------------------------
 fs/cifs/smb2ops.c       | 30 ++++++++++++++++++------------
 fs/cifs/smb2transport.c | 19 ++++++++++++-------
 6 files changed, 105 insertions(+), 62 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 29 Oct 2022 21:40:29 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc2-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/28b7bd4ad25f7dc662a84636a619e61c97ac0e06

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
247f34f7b80357943234f93f247a1ae6b6c3a740:

  Linux 6.1-rc2 (2022-10-23 15:27:33 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc2-smb3-fixes

for you to fetch changes up to 153695d36ead0ccc4d0256953c751cabf673e621:

  cifs: fix use-after-free caused by invalid pointer `hostname`
(2022-10-27 23:59:13 -0500)

----------------------------------------------------------------
3 cifs/smb3 fixes (also for stable)
- use after free fix for reconnect race
- two memory leak fixes

A broader fix for reconnect races (killing the cifsd thread earlier),
and an important for for multichannel oplock breaks are not included
in this P/R since still being tested.
----------------------------------------------------------------
Zeng Heng (1):
      cifs: fix use-after-free caused by invalid pointer `hostname`

Zhang Xiaoxu (2):
      cifs: Fix pages array leak when writedata alloc failed in
cifs_writedata_alloc()
      cifs: Fix pages leak when writedata alloc failed in cifs_write_from_iter()

 fs/cifs/connect.c |  1 +
 fs/cifs/file.c    | 13 ++++++++++---


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 21 Oct 2022 09:40:07 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc1-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/bd8e963412c8e676fc73ae456f311cdcabe8642d

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
9abf2313adc1ca1b6180c508c25f22f9395cc780:

  Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc1-smb3-fixes

for you to fetch changes up to 73b1b8d25e39a1478b3792a7075f43e053ee62c2:

  cifs: update internal module number (2022-10-19 17:57:51 -0500)

----------------------------------------------------------------
12 small cifs/smb3 fixes, half for stable
- two memory leak fixes
- two fixes for directory leases, including an important one which
fixes a problem noticed by git functional tests
- five fixes relating to missing free_xid calls (helpful for
tracing/debugging of entry/exit into cifs.ko)
- a multichannel fix
- a small cleanup fix (use of list_move instead of list_del/list_add)
----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: fix memory leaks in session setup

Ronnie Sahlberg (2):
      cifs: set rc to -ENOENT if we can not get a dentry for the cached dir
      cifs: drop the lease for cached directories on rmdir or rename

Steve French (2):
      smb3: interface count displayed incorrectly
      cifs: update internal module number

Yang Yingliang (1):
      cifs: use LIST_HEAD() and list_move() to simplify code

Zhang Xiaoxu (6):
      cifs: Fix xid leak in cifs_create()
      cifs: Fix xid leak in cifs_copy_file_range()
      cifs: Fix xid leak in cifs_flock()
      cifs: Fix xid leak in cifs_ses_add_channel()
      cifs: Fix xid leak in cifs_get_file_info_unix()
      cifs: Fix memory leak when build ntlmssp negotiate blob failed

 fs/cifs/cached_dir.c | 39 +++++++++++++++++++++++++++++----------
 fs/cifs/cached_dir.h |  4 ++++
 fs/cifs/cifsfs.c     |  7 +++++--
 fs/cifs/cifsfs.h     |  4 ++--
 fs/cifs/dir.c        |  6 ++++--
 fs/cifs/file.c       | 11 +++++++----
 fs/cifs/inode.c      |  6 ++++--
 fs/cifs/sess.c       |  1 +
 fs/cifs/smb2inode.c  |  2 ++
 fs/cifs/smb2ops.c    |  3 ++-
 fs/cifs/smb2pdu.c    | 17 ++++++++---------
 11 files changed, 68 insertions(+), 32 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 15 Oct 2022 19:33:08 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b08cd74448fafaa302ce2bc11beab5e5a55d0065

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
ac1e8c6c95bf805c699656046aef0a05205edfbd:

  Merge tag '6.1-rc-smb3-client-fixes-part1' of
git://git.samba.org/sfrench/cifs-2.6 (2022-10-10 20:04:22 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc-smb3-client-fixes-part2

for you to fetch changes up to e3e9463414f610e91528f2b920b8cb655f4bae33:

  smb3: improve SMB3 change notification support (2022-10-15 10:05:53 -0500)

----------------------------------------------------------------
15 cifs/smb3 fixes including 2 for stable
- fix a regression in guest mounts to old servers
- improvements to directory leasing (caching directory entries safely
beyond the root directory)
- symlink improvement (reducing roundtrips needed to process symlinks)
- an lseek fix (to problem where some dir entries could be skipped)
- improved ioctl for returning more detailed information on directory
change notifications
- clarify multichannel interface query warning
- cleanup fix (for better aligning buffers using ALIGN and round_up)
- a compounding fix
- fix some uninitialized variable bugs found by Coverity and the
kernel test robot
----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: use ALIGN() and round_up() macros

Paulo Alcantara (5):
      cifs: improve symlink handling for smb2+
      cifs: fix uninitialised var in smb2_compound_op()
      cifs: prevent copying past input buffer boundaries
      cifs: fix static checker warning
      cifs: fix double-fault crash during ntlmssp

Ronnie Sahlberg (4):
      cifs: fix skipping to incorrect offset in emit_cached_dirents
      cifs: fix regression in very old smb1 mounts
      cifs: enable caching of directories for which a lease is held
      cifs: find and use the dentry for cached non-root directories also

Steve French (5):
      smb3: clarify multichannel warning
      smb3: must initialize two ACL struct fields to zero
      cifs: lease key is uninitialized in smb1 paths
      cifs: lease key is uninitialized in two additional functions when smb1
      smb3: improve SMB3 change notification support

 fs/cifs/cached_dir.c | 469
++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
 fs/cifs/cached_dir.h |  20 ++--
 fs/cifs/cifs_ioctl.h |   8 ++
 fs/cifs/cifsfs.c     |   9 +-
 fs/cifs/cifsglob.h   |  48 +++++++---
 fs/cifs/cifsproto.h  |  13 ++-
 fs/cifs/cifssmb.c    |   2 +-
 fs/cifs/connect.c    |  22 +++--
 fs/cifs/dir.c        |  32 +++----
 fs/cifs/file.c       |  45 ++++-----
 fs/cifs/inode.c      | 176 +++++++++++++++++++++--------------
 fs/cifs/ioctl.c      |  25 ++++-
 fs/cifs/link.c       | 107 +--------------------
 fs/cifs/readdir.c    |  31 +++++--
 fs/cifs/sess.c       |  34 +++----
 fs/cifs/smb1ops.c    |  56 ++++++-----
 fs/cifs/smb2file.c   | 127 ++++++++++++++++++++-----
 fs/cifs/smb2inode.c  | 170 +++++++++++++++++----------------
 fs/cifs/smb2misc.c   |   2 +-
 fs/cifs/smb2ops.c    | 149 +++++++++++------------------
 fs/cifs/smb2pdu.c    |  75 +++++++++------
 fs/cifs/smb2pdu.h    |   3 +
 fs/cifs/smb2proto.h  |  25 +++--
 23 files changed, 922 insertions(+), 726 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 9 Oct 2022 00:50:33 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ac1e8c6c95bf805c699656046aef0a05205edfbd

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
f76349cf41451c5c42a99f18a9163377e4b364ff:

  Linux 6.0-rc7 (2022-09-25 14:01:02 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.1-rc-smb3-client-fixes-part1

for you to fetch changes up to 958553d13478ad0e35fa09fecad3ce73277ccaf5:

  smb3: fix oops in calculating shash_setkey (2022-10-07 23:08:41 -0500)

----------------------------------------------------------------
21 cifs/smb3 fixes, including 4 for stable
- data corruption fix when cache disabled
- four RDMA (smbdirect) improvements, including enabling support for SoftiWARP
- four signing improvements
- three directory lease improvements
- four cleanup fixes
- minor security fix
- two debugging improvements

Additional security improvements including enabling GMAC signing, and
patches to extend use of directory leases (improved safe metadata and
directory entry caching) and improvements to symlink handling are
still being tested and are not included in this P/R.
----------------------------------------------------------------
Enzo Matsumiya (4):
      cifs: return correct error in ->calc_signature()
      cifs: replace kfree() with kfree_sensitive() for sensitive data
      smb3: rename encryption/decryption TFMs
      cifs: secmech: use shash_desc directly, remove sdesc

Gustavo A. R. Silva (1):
      cifs: Replace a couple of one-element arrays with flexible-array members

Jiangshan Yi (1):
      cifs: misc: fix spelling typo in comment

Muhammad Usama Anjum (1):
      cifs: remove initialization value

Ronnie Sahlberg (4):
      cifs: destage dirty pages before re-reading them for cache=none
      cifs: Make tcon contain a wrapper structure cached_fids instead
of cached_fid
      cifs: improve handlecaching
      cifs: store a pointer to a fid in the cfid structure instead of the struct

Steve French (5):
      MAINTAINERS: Add Tom Talpey as cifs.ko reviewer
      smb3: add dynamic trace points for tree disconnect
      smb3: define missing create contexts
      smb3: do not log confusing message when server returns no
network interfaces
      smb3: fix oops in calculating shash_setkey

Tom Talpey (4):
      Decrease the number of SMB3 smbdirect client SGEs
      Reduce client smbdirect max receive segment size
      Handle variable number of SGEs in client smbdirect send.
      Fix formatting of client smbdirect RDMA logging

Zhang Xiaoxu (1):
      cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message

 MAINTAINERS               |   1 +
 fs/cifs/cached_dir.c      |  92 ++++++++++++++++++++++++++++---------
 fs/cifs/cached_dir.h      |  10 ++++-
 fs/cifs/cifs_debug.c      |   4 +-
 fs/cifs/cifs_debug.h      |   6 +--
 fs/cifs/cifs_swn.c        |  12 ++---
 fs/cifs/cifsencrypt.c     | 100 ++++++++++++++---------------------------
 fs/cifs/cifsglob.h        |  30 +++++--------
 fs/cifs/cifspdu.h         |   7 +--
 fs/cifs/cifsproto.h       |   7 ++-
 fs/cifs/cifssmb.c         |   2 +-
 fs/cifs/connect.c         |  21 ++++-----
 fs/cifs/dfs_cache.c       |   2 +-
 fs/cifs/dir.c             |   8 ++--
 fs/cifs/file.c            |   9 ++++
 fs/cifs/fs_context.c      |  12 ++++-
 fs/cifs/fscache.c         |   2 +-
 fs/cifs/inode.c           |   2 +-
 fs/cifs/link.c            |  13 +++---
 fs/cifs/misc.c            |  63 +++++++++++++-------------
 fs/cifs/sess.c            |  24 ++++++----
 fs/cifs/smb2inode.c       |   2 +-
 fs/cifs/smb2misc.c        |  13 +++---
 fs/cifs/smb2ops.c         |  38 ++++++++++------
 fs/cifs/smb2pdu.c         |  41 +++++++++++------
 fs/cifs/smb2transport.c   |  98 +++++++++++++++++-----------------------
 fs/cifs/smbdirect.c       | 227
+++++++++++++++++++++++++++++++++++++++-----------------------------------------------------
 fs/cifs/smbdirect.h       |  14 +++---
 fs/cifs/trace.h           |   3 ++
 fs/smbfs_common/smb2pdu.h |   6 ++-
 30 files changed, 445 insertions(+), 424 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 16 Sep 2022 00:25:02 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc5-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/714820c63914c7c4c1fd37fafdd2baa14cb605ec

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
80e78fcce86de0288793a0ef0f6acf37656ee4cf:

  Linux 6.0-rc5 (2022-09-11 16:22:01 -0400)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc5-smb3-fixes

for you to fetch changes up to 8af8aed97bebe8b26a340da5236e277c3d84a8ec:

  cifs: update internal module number (2022-09-14 04:00:06 -0500)

----------------------------------------------------------------
Four fixes for stable
- important fix to revalidate mapping when doing direct writes
- missing spinlock
- two fixes to socket handling
- and trivial change to update internal version number for cifs.ko

----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: add missing spinlock around tcon refcount

Ronnie Sahlberg (1):
      cifs: revalidate mapping when doing direct writes

Stefan Metzmacher (2):
      cifs: don't send down the destination address to sendmsg for a SOCK_STREAM
      cifs: always initialize struct msghdr smb_msg completely

Steve French (1):
      cifs: update internal module number

 fs/cifs/cifsfs.h    |  4 ++--
 fs/cifs/connect.c   | 14 ++++++--------
 fs/cifs/file.c      |  3 +++
 fs/cifs/transport.c |  6 +-----
 4 files changed, 12 insertions(+), 15 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 1 Sep 2022 19:44:29 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc3-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1551f8f21e007e608fff00cf27caac8504283b43

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
b90cb1053190353cc30f0fef0ef1f378ccc063c5:

  Linux 6.0-rc3 (2022-08-28 15:05:29 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc3-smb3-client-fixes

for you to fetch changes up to 27893dfc1285f80f80f46b3b8c95f5d15d2e66d0:

  cifs: fix small mempool leak in SMB2_negotiate() (2022-08-30 20:08:13 -0500)

----------------------------------------------------------------
5 cifs/smb3 fixes, all also for stable
- fixes for collapse range and insert range (also fixes xfstest generic/031)
- memory leak fix
----------------------------------------------------------------
David Howells (2):
      smb3: Move the flush out of smb2_copychunk_range() into its callers
      smb3: fix temporary data corruption in insert range

Enzo Matsumiya (1):
      cifs: fix small mempool leak in SMB2_negotiate()

Steve French (2):
      smb3: fix temporary data corruption in collapse range
      smb3: use filemap_write_and_wait_range instead of filemap_write_and_wait

 fs/cifs/cifsfs.c  |  6 +++++
 fs/cifs/smb2ops.c | 69 +++++++++++++++++++++++++++++++++----------------------
 fs/cifs/smb2pdu.c | 12 ++++++----
 3 files changed, 55 insertions(+), 32 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 27 Aug 2022 16:43:51 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c7bb3fbc1b499b56a8819b56978c514fd63f66cc

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
1c23f9e627a7b412978b4e852793c5e3c3efc555:

  Linux 6.0-rc2 (2022-08-21 17:32:54 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc2-smb3-client-fixes

for you to fetch changes up to d291e703f420d5f8f999fe54f360d54d213bddb4:

  cifs: Add helper function to check smb1+ server (2022-08-24 22:30:09 -0500)

----------------------------------------------------------------
6 cifs/smb3 fixes, three for stable:
- two locking fixes (zero range, punch hole)
- DFS 9 fix (padding),  affecting some servers
- three minor cleanup changes

There are a few additional important fixes (collapse range, insert range) that
are not included since still being tested.
----------------------------------------------------------------
David Howells (2):
      smb3: missing inode locks in zero range
      smb3: missing inode locks in punch hole

Paulo Alcantara (1):
      cifs: skip extra NULL byte in filenames

Zhang Xiaoxu (3):
      cifs: Use help macro to get the header preamble size
      cifs: Use help macro to get the mid header size
      cifs: Add helper function to check smb1+ server

 fs/cifs/cifsencrypt.c |  3 +--
 fs/cifs/cifsglob.h    |  7 ++++++
 fs/cifs/connect.c     | 23 ++++++++----------
 fs/cifs/smb2ops.c     | 67 +++++++++++++++++++++++++++------------------------
 fs/cifs/smb2pdu.c     | 16 +++++-------
 fs/cifs/transport.c   | 21 ++++++++--------
 6 files changed, 70 insertions(+), 67 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 20 Aug 2022 17:34:30 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc1-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/367bcbc5b5ffc7164fb6ce1547e84dbf21795562

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
568035b01cfb107af8d2e4bd2fb9aea22cf5b868:

  Linux 6.0-rc1 (2022-08-14 15:50:18 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/6.0-rc1-smb3-client-fixes

for you to fetch changes up to 13609a8b3ac6b0af38127a2b97fe62c0d06a8282:

  cifs: move from strlcpy with unused retval to strscpy (2022-08-19
11:02:26 -0500)

----------------------------------------------------------------
5 cifs/smb3 fixes, one for stable
- memory leak fix
- two small cleanup
- trivial strlcpy removal
- update missing entry for cifs headers in MAINTAINERS file

There are a pair of important fixes for insert range and collapse
range that are being tested
now that I plan to send next week.
----------------------------------------------------------------
Enzo Matsumiya (2):
      cifs: remove unused server parameter from calc_smb_size()
      cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()

Steve French (1):
      cifs: missing directory in MAINTAINERS file

Wolfram Sang (1):
      cifs: move from strlcpy with unused retval to strscpy

Zhang Xiaoxu (1):
      cifs: Fix memory leak on the deferred close

 MAINTAINERS          |  1 +
 fs/cifs/cifs_debug.c |  2 +-
 fs/cifs/cifsglob.h   |  2 +-
 fs/cifs/cifsproto.h  |  2 +-
 fs/cifs/cifsroot.c   |  2 +-
 fs/cifs/connect.c    |  2 +-
 fs/cifs/misc.c       |  8 +++++++-
 fs/cifs/netmisc.c    |  2 +-
 fs/cifs/readdir.c    |  6 ++----
 fs/cifs/smb2file.c   |  1 -
 fs/cifs/smb2misc.c   |  4 ++--
 fs/cifs/smb2ops.c    | 37 ++++++++++++++-----------------------
 fs/cifs/smb2pdu.c    | 22 ++++++++++------------
 fs/cifs/smb2proto.h  |  6 +++---
 14 files changed, 45 insertions(+), 52 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 13 Aug 2022 16:44:58 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.20-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/332019e23a51db1aa46fec695a9a763445fbe09f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
0d168a58fca34806b575c7cba87afb11208acb54:

  cifs: update internal module number (2022-08-05 11:24:17 -0500)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.20-rc-smb3-client-fixes-part2

for you to fetch changes up to 7eb59a98701d3113671b513593bb489cc76f58d2:

  cifs: Do not access tcon->cfids->cfid directly from
is_path_accessible (2022-08-12 17:40:15 -0500)

----------------------------------------------------------------
8 cifs/smb3 fixes:
- two fixes for stable, one for a lock length miscalculation, and
another fixes a lease break timeout bug
- improvement to handle leases, allows the close timeout to be
configured more safely
- five restructuring/cleanup patches
----------------------------------------------------------------
Bharath SM (1):
      SMB3: fix lease break timeout when multiple deferred close
handles for the same file.

David Howells (1):
      cifs: Remove {cifs,nfs}_fscache_release_page()

Paulo Alcantara (1):
      cifs: fix lock length calculation

Ronnie Sahlberg (4):
      cifs: Move cached-dir functions into a separate file
      cifs: Do not use tcon->cfid directly, use the cfid we get from
open_cached_dir
      cifs: Add constructor/destructors for tcon->cfid
      cifs: Do not access tcon->cfids->cfid directly from is_path_accessible

Steve French (1):
      smb3: allow deferred close timeout to be configurable

 fs/cifs/Makefile     |   2 +-
 fs/cifs/cached_dir.c | 388 +++++++++++++++++++++++++++++++++++++++++++++++++
 fs/cifs/cached_dir.h |  64 ++++++++
 fs/cifs/cifsfs.c     |  21 +--
 fs/cifs/cifsglob.h   |  42 +-----
 fs/cifs/cifsproto.h  |   1 -
 fs/cifs/connect.c    |   2 +
 fs/cifs/file.c       |  39 +----
 fs/cifs/fs_context.c |   9 ++
 fs/cifs/fs_context.h |   8 +
 fs/cifs/fscache.h    |  16 --
 fs/cifs/inode.c      |   1 +
 fs/cifs/misc.c       |  20 ++-
 fs/cifs/readdir.c    |   5 +-
 fs/cifs/smb2inode.c  |  11 +-
 fs/cifs/smb2misc.c   |  11 +-
 fs/cifs/smb2ops.c    | 320 +++-------------------------------------
 fs/cifs/smb2pdu.c    |   3 +-
 fs/cifs/smb2proto.h  |  10 --
 19 files changed, 528 insertions(+), 445 deletions(-)
 create mode 100644 fs/cifs/cached_dir.c
 create mode 100644 fs/cifs/cached_dir.h


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sun, 7 Aug 2022 00:03:50 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.20-rc-smb3-client-fixes-part1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3bc1bc0b59d04e997db25b84babf459ca1cd80b7

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
3d7cb6b04c3f3115719235cc6866b10326de34cd:

  Linux 5.19 (2022-07-31 14:03:01 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.20-rc-smb3-client-fixes-part1

for you to fetch changes up to 0d168a58fca34806b575c7cba87afb11208acb54:

  cifs: update internal module number (2022-08-05 11:24:17 -0500)

----------------------------------------------------------------
19 cifs/smb3 fixes, mostly cleanup, including:
- multichannel perf improvement patch
- 1 to moving additional SMB1 code to not be compiled in when legacy
support is disabled.
- 3 bug fixes, including one important one for memory leak
- 12 cleanup patches

We are still working/testing some deferred close improvements
including an important
lease break fix for case when multiple deferred closes are still open,
and also some
additional perf improvements - so those are not included in this P/R
----------------------------------------------------------------
Colin Ian King (1):
      cifs: remove redundant initialization to variable mnt_sign_enabled

Enzo Matsumiya (4):
      smb2: small refactor in smb2_check_message()
      cifs: list_for_each() -> list_for_each_entry()
      cifs: remove useless DeleteMidQEntry()
      cifs: remove "cifs_" prefix from init/destroy mids functions

Matthew Wilcox (Oracle) (1):
      cifs: Fix memory leak when using fscache

Shyam Prasad N (1):
      cifs: avoid use of global locks for high contention data

Steve French (9):
      smb3: check xattr value length earlier
      cifs: remove some camelCase and also some static build warnings
      cifs: remove minor build warning
      cifs: update MAINTAINERS file with reviewers
      cifs: remove remaining build warnings
      cifs: trivial style fixup
      cifs: when insecure legacy is disabled shrink amount of SMB1 code
      cifs: alloc_mid function should be marked as static
      cifs: update internal module number

Yang Yingliang (1):
      cifs: fix wrong unlock before return from cifs_tree_connect()

Yu Zhe (2):
      cifs: remove unnecessary type castings
      cifs: remove unnecessary (void*) conversions.

 MAINTAINERS             |   7 +-
 fs/cifs/Makefile        |   4 +-
 fs/cifs/cifs_debug.c    |  72 +++-----
 fs/cifs/cifsacl.c       |   2 +
 fs/cifs/cifsencrypt.c   |   6 +-
 fs/cifs/cifsfs.c        |  53 ++++--
 fs/cifs/cifsfs.h        |   4 +-
 fs/cifs/cifsglob.h      | 135 +++++++++-----
 fs/cifs/cifsproto.h     |  10 +-
 fs/cifs/cifssmb.c       | 477 ++----------------------------------------------
 fs/cifs/connect.c       | 299 ++++++++++++++++++------------
 fs/cifs/dfs_cache.c     |   8 +-
 fs/cifs/dir.c           |   8 +
 fs/cifs/file.c          | 283 ++++++++++++++++++++++++++--
 fs/cifs/inode.c         |  64 ++++++-
 fs/cifs/ioctl.c         |   2 +
 fs/cifs/link.c          |   8 +
 fs/cifs/misc.c          |  33 ++--
 fs/cifs/netmisc.c       |   2 +-
 fs/cifs/sess.c          |   5 +-
 fs/cifs/smb1ops.c       |  10 +-
 fs/cifs/smb2misc.c      |  49 +++--
 fs/cifs/smb2ops.c       |  61 ++++---
 fs/cifs/smb2pdu.c       |  32 ++--
 fs/cifs/smb2transport.c |  38 ++--
 fs/cifs/transport.c     | 334 +++++++++++++++++++++++++--------
 fs/cifs/xattr.c         |   5 +-
 27 files changed, 1104 insertions(+), 907 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 14 Jul 2022 13:41:54 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc6-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f41d5df5f146d606df02ec8fafd080a5ee6e6e81

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
32346491ddf24599decca06190ebca03ff9de7f8:

  Linux 5.19-rc6 (2022-07-10 14:40:51 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc6-smb3-client-fixes

for you to fetch changes up to 32f319183c439b239294cb2d70ada3564c4c7c39:

  smb3: workaround negprot bug in some Samba servers (2022-07-13 19:59:47 -0500)
----------------------------------------------------------------
[resending due to cut-n-paste error in earlier P/R]

Three smb3 client fixes:
- 2 related to multichannel, one fixes a potential deadlock freeing a channel,
  and the other fixing race condition on failed creation of new channel
- one fixes a mount failure, working around a server bug in some
  common older Samba servers by avoiding padding at the end of the
  negotiate protocol request

----------------------------------------------------------------
Shyam Prasad N (2):
      cifs: fix race condition with delayed threads
      cifs: remove unnecessary locking of chan_lock while freeing session

Steve French (1):
      smb3: workaround negprot bug in some Samba servers

 fs/cifs/connect.c |  2 --
 fs/cifs/sess.c    | 11 +++++++++--
 fs/cifs/smb2pdu.c | 13 +++++++------
 3 files changed, 16 insertions(+), 10 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[Linus Torvalds]

On Wed, Jul 13, 2022 at 8:36 PM Steve French <smfrench@gmail.com> wrote:
>
> Three smb3 client fixes:

You don't even point to a git tree..

Please use the whole "git request-pull" thing, and include everything.

              Linus

[GIT PULL] smb3 client fixes

[Steve French]

----------------------------------------------------------------
Three smb3 client fixes:
- 2 related to multichannel, one fixes a potential deadlock freeing a channel,
  and the other fixing race condition on failed creation of new channel
- one fixes a mount failure, working around a server bug in some
  common older Samba servers by avoiding padding at the end of the
  negotiate protocol request

----------------------------------------------------------------
Shyam Prasad N (2):
      cifs: fix race condition with delayed threads
      cifs: remove unnecessary locking of chan_lock while freeing session

Steve French (1):
      smb3: workaround negprot bug in some Samba servers

 fs/cifs/connect.c |  2 --
 fs/cifs/sess.c    | 11 +++++++++--
 fs/cifs/smb2pdu.c | 13 +++++++------
 3 files changed, 16 insertions(+), 10 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 25 Jun 2022 16:38:40 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc3-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/918c30dffd14cd3f4af1e67cb40db91a008fc4fe

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
a111daf0c53ae91e71fd2bfe7497862d14132e3e:

  Linux 5.19-rc3 (2022-06-19 15:06:47 -0500)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc3-smb3-client-fixes

for you to fetch changes up to af3a6d1018f02c6dc8388f1f3785a559c7ab5961:

  cifs: update cifs_ses::ip_addr after failover (2022-06-24 13:34:28 -0500)

----------------------------------------------------------------
7 SMB3 fixes, addressing important multichannel, reconnect issues.
Multichannel mounts when the server network interfaces changed, or
ip addresses changed, uncovered problems, especially in reconnect, but
the patches for this were held up until recently due to some lock conflicts
that are now addressed.   Included in this set of fixes:

- 3 fixes relating to multichannel reconnect, dynamically adjusting the list of
server interfaces to avoid problems during reconnect
- a lock conflict fix related to the above
- 2 important fixes for negotiate on secondary channels (null netname can
unintentionally cause multichannel to be disabled to some servers)
- a reconnect fix (reporting incorrect IP address in some cases)

----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: update cifs_ses::ip_addr after failover

Shyam Prasad N (5):
      smb3: use netname when available on secondary channels
      cifs: change iface_list from array to sorted linked list
      cifs: during reconnect, update interface if necessary
      cifs: periodically query network interfaces from server
      cifs: avoid deadlocks while updating iface

Steve French (1):
      smb3: fix empty netname context on secondary channels

 fs/cifs/cifs_debug.c |  12 ++--
 fs/cifs/cifsglob.h   |  58 ++++++++++++++++-
 fs/cifs/cifsproto.h  |   7 +++
 fs/cifs/connect.c    |  59 ++++++++++++++++--
 fs/cifs/misc.c       |   9 ++-
 fs/cifs/sess.c       | 166 +++++++++++++++++++++++++++++++++++++-----------
 fs/cifs/smb2ops.c    | 173 +++++++++++++++++++++++++++------------------------
 fs/cifs/smb2pdu.c    |  21 +++++--
 8 files changed, 366 insertions(+), 139 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 18 Jun 2022 17:38:54 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ace2045ed56f9b00beb4cd23c76a5b6cae69f2fe

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3:

  Linux 5.19-rc2 (2022-06-12 16:11:37 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc2-smb3-client-fixes

for you to fetch changes up to 5d24968f5b7e00bae564b1646c3b9e0e3750aabe:

  cifs: when a channel is not found for server, log its connection id
(2022-06-18 14:55:06 -0500)

----------------------------------------------------------------
2 smb3 debugging improvements
- one found to deal with debugging a multichannel problem and one for
a recent fallocate issue

Did not include the two larger multichannel reconnect (dynamically
adjusting interfaces on reconnect) patches in this P/R, because
recently found an additional problem with multichannel  to one server
type that I want to include at the same time.
----------------------------------------------------------------
Shyam Prasad N (1):
      cifs: when a channel is not found for server, log its connection id

Steve French (1):
      smb3: add trace point for SMB2_set_eof

 fs/cifs/sess.c    |  3 +++
 fs/cifs/smb2pdu.c |  2 ++
 fs/cifs/trace.h   | 38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 11 Jun 2022 11:38:45 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc1-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/2275c6babfa53278c90b7915441c61392dd687cc

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
f2906aa863381afb0015a9eb7fefad885d4e5a56:

  Linux 5.19-rc1 (2022-06-05 17:18:54 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc1-smb3-client-fixes

for you to fetch changes up to 4c14d7043fede258957d7b01da0cad2d9fe3a205:

  cifs: populate empty hostnames for extra channels (2022-06-10 18:55:02 -0500)

----------------------------------------------------------------
3 smb3 reconnect fixes, all for stable as well

One of these three reconnect fixes does address a problem with
multichannel reconnect,
but this P/R does not include the additional fix (still being tested)
for dynamically
detecting multichannel adapter changes which will improve those
reconnect scenarios
even more.
----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: fix reconnect on smb3 mount types

Shyam Prasad N (2):
      cifs: return errors during session setup during reconnects
      cifs: populate empty hostnames for extra channels

 fs/cifs/cifsfs.c  |  2 +-
 fs/cifs/cifsfs.h  |  2 +-
 fs/cifs/connect.c |  4 ++++
 fs/cifs/misc.c    | 27 ++++++++++++++++-----------
 fs/cifs/sess.c    |  5 ++++-
 fs/cifs/smb2pdu.c |  3 +++
 6 files changed, 29 insertions(+), 14 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 4 Jun 2022 18:00:34 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc-smb3-client-fixes-part2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d66016c5cd3d4c474cd24622c511dcd358645613

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
bf272460d744112bacd4c4d562592decbf0edf64:

  Merge tag '5.19-rc-smb3-client-fixes-updated' of
git://git.samba.org/sfrench/cifs-2.6 (2022-05-27 16:05:57 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc-smb3-client-fixes-part2

for you to fetch changes up to ee3c8019cce254f586b7fc2c5b836c275b275527:

  cifs: fix uninitialized pointer in error case in
dfs_cache_get_tgt_share (2022-06-04 13:33:42 -0500)

----------------------------------------------------------------
Includes various cifs/smb3 fixes:
- DFS fix
- double free fix
- potential deadlock fix
- fallocate (extend file size) improvement
- two legacy code cleanup fixes (do not include in build when legacy disabled)
- duplicate error message cleanup

This does not include the two multichannel (dynamic requery on interface change)
fixes, nor the important multichannel signing reconnect fix, which are important
but were recently changed by Shyam, so I wanted to give a few more days for
testing for them.
----------------------------------------------------------------
Enzo Matsumiya (1):
      cifs: remove repeated debug message on cifs_put_smb_ses()

Paulo Alcantara (1):
      cifs: skip trailing separators of prefix paths

Ronnie Sahlberg (2):
      cifs: fix potential double free during failed mount
      cifs: when extending a file with falloc we should make files not-sparse

Steve French (4):
      cifs: do not build smb1ops if legacy support is disabled
      cifs: version operations for smb20 unneeded when legacy support disabled
      cifs: update internal module number
      cifs: fix uninitialized pointer in error case in dfs_cache_get_tgt_share

Vincent Whitchurch (1):
      cifs: fix potential deadlock in direct reclaim

 fs/cifs/Makefile      |  4 ++-
 fs/cifs/cifs_swn.c    |  4 +--
 fs/cifs/cifsencrypt.c |  8 ++---
 fs/cifs/cifsfs.c      | 10 +++---
 fs/cifs/cifsfs.h      |  5 +--
 fs/cifs/cifsglob.h    | 24 ++++++++++++--
 fs/cifs/connect.c     | 27 ++++++++--------
 fs/cifs/dfs_cache.c   | 90 +++++++++++++++++++++++++++++----------------------
 fs/cifs/sess.c        |  6 ++--
 fs/cifs/smb1ops.c     |  6 ++--
 fs/cifs/smb2ops.c     |  9 ++++--
 fs/cifs/smb2pdu.c     |  6 ++--
 fs/cifs/smbdirect.c   |  4 +--
 fs/cifs/transport.c   | 40 +++++++++++------------
 14 files changed, 143 insertions(+), 100 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] SMB3 client fixes

[Steve French]

Al wants to postpone Dave's iov_iter changes (he had some additional
things he wants changed in those).  I will resend the P/R without
those 4 patches from Dave Howells.

On Fri, May 27, 2022 at 1:52 AM Steve French <smfrench@gmail.com> wrote:
>
> Please pull the following changes since commit
> 42226c989789d8da4af1de0c31070c96726d990c:
>
>   Linux 5.18-rc7 (2022-05-15 18:08:58 -0700)
>
> are available in the Git repository at:
>
>   git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc-smb3-client-fixes-part1
>
> for you to fetch changes up to 9f114d7bfc6c35ca23a82efce60e0db535a186f1:
>
>   smb3: remove unneeded null check in cifs_readdir (2022-05-26 11:15:14 -0500)
>
> ----------------------------------------------------------------
> Twenty eight cifs/smb3 client fixes, including:
> - a series of fixes for multichannel fixes to improve reconnect after
> network failure
> - improved caching of root directory contents (extending benefit of
> directory leases)
> - 2 DFS fixes
> - 3 fixes for improved debugging
> - an NTLMSSP fix for mounts t0 older servers
> - new mount parm to allow disabling creating sparse files
> - various cleanup fixes and minor fixes pointed out by coverity
> - the first part of Dave's updates for iov_iter support
>
> Not included in this P/R are the last two patches in Dave's series
> converting i/o paths in cifs.ko to use iterators,
> as well as some RDMA (smbdirect) fixes and a patch to dynamically
> requery and adjust the network interfaces on the
> fly - all of which are still being tested.
> ----------------------------------------------------------------
> ChenXiaoSong (1):
>       cifs: return the more nuanced writeback error on close()
>
> David Howells (4):
>       iov_iter: Add a function to extract an iter's buffers to a bvec iter
>       iov_iter: Add a general purpose iteration function
>       cifs: Add some helper functions
>       cifs: Add a function to read into an iter from a socket
>
> Enzo Matsumiya (3):
>       cifs: don't call cifs_dfs_query_info_nonascii_quirk() if nodfs was set
>       cifs: return ENOENT for DFS lookup_cache_entry()
>       cifs: print TIDs as hex
>
> Julia Lawall (1):
>       cifs: smbd: fix typo in comment
>
> Paulo Alcantara (2):
>       cifs: fix signed integer overflow when fl_end is OFFSET_MAX
>       cifs: fix ntlmssp on old servers
>
> Ronnie Sahlberg (4):
>       cifs: move definition of cifs_fattr earlier in cifsglob.h
>       cifs: check for smb1 in open_cached_dir()
>       cifs: set the CREATE_NOT_FILE when opening the directory in
> use_cached_dir()
>       cifs: cache the dirents for entries in a cached directory
>
> Shyam Prasad N (3):
>       cifs: do not use tcpStatus after negotiate completes
>       cifs: use new enum for ses_status
>       cifs: avoid parallel session setups on same channel
>
> Steve French (10):
>       SMB3: EBADF/EIO errors in rename/open caused by race condition
> in smb2_compound_op
>       smb3: add trace point for lease not found issue
>       smb3: add trace point for oplock not found
>       Add defines for various newer FSCTLs
>       Add various fsctl structs
>       cifs: fix minor compile warning
>       smb3: check for null tcon
>       smb3: don't set rc when used and unneeded in query_info_compound
>       smb3: add mount parm nosparse
>       smb3: remove unneeded null check in cifs_readdir
>
>  fs/cifs/cifs_debug.c       |  11 +++-
>  fs/cifs/cifsfs.c           |   2 +
>  fs/cifs/cifsfs.h           |   3 +
>  fs/cifs/cifsglob.h         | 124 +++++++++++++++++++++++++++------------
>  fs/cifs/cifsproto.h        |  12 ++++
>  fs/cifs/cifssmb.c          |  99 ++++++++++++++++++++++++++++++-
>  fs/cifs/connect.c          | 123 +++++++++++++++++++++++----------------
>  fs/cifs/dfs_cache.c        |   6 +-
>  fs/cifs/file.c             |  13 +++--
>  fs/cifs/fs_context.c       |  33 +++--------
>  fs/cifs/fs_context.h       |   4 +-
>  fs/cifs/misc.c             |  11 ++--
>  fs/cifs/readdir.c          | 179
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  fs/cifs/sess.c             |  33 ++++++++++-
>  fs/cifs/smb2inode.c        |   7 ++-
>  fs/cifs/smb2misc.c         |  12 +++-
>  fs/cifs/smb2ops.c          |  32 +++++++++--
>  fs/cifs/smb2pdu.c          |   5 +-
>  fs/cifs/smb2pdu.h          |  22 -------
>  fs/cifs/smb2transport.c    |   7 ++-
>  fs/cifs/smbdirect.c        |   2 +-
>  fs/cifs/trace.h            |   2 +
>  fs/cifs/transport.c        |   8 +--
>  fs/smbfs_common/smb2pdu.h  | 108 +++++++++++++++++++++++++++++++---
>  fs/smbfs_common/smbfsctl.h |   6 ++
>  include/linux/uio.h        |   8 +++
>  lib/iov_iter.c             | 133 ++++++++++++++++++++++++++++++++++++++++++
>  27 files changed, 816 insertions(+), 189 deletions(-)
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve

[GIT PULL] SMB3 client fixes

[Steve French]

Please pull the following changes since commit
42226c989789d8da4af1de0c31070c96726d990c:

  Linux 5.18-rc7 (2022-05-15 18:08:58 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.19-rc-smb3-client-fixes-part1

for you to fetch changes up to 9f114d7bfc6c35ca23a82efce60e0db535a186f1:

  smb3: remove unneeded null check in cifs_readdir (2022-05-26 11:15:14 -0500)

----------------------------------------------------------------
Twenty eight cifs/smb3 client fixes, including:
- a series of fixes for multichannel fixes to improve reconnect after
network failure
- improved caching of root directory contents (extending benefit of
directory leases)
- 2 DFS fixes
- 3 fixes for improved debugging
- an NTLMSSP fix for mounts t0 older servers
- new mount parm to allow disabling creating sparse files
- various cleanup fixes and minor fixes pointed out by coverity
- the first part of Dave's updates for iov_iter support

Not included in this P/R are the last two patches in Dave's series
converting i/o paths in cifs.ko to use iterators,
as well as some RDMA (smbdirect) fixes and a patch to dynamically
requery and adjust the network interfaces on the
fly - all of which are still being tested.
----------------------------------------------------------------
ChenXiaoSong (1):
      cifs: return the more nuanced writeback error on close()

David Howells (4):
      iov_iter: Add a function to extract an iter's buffers to a bvec iter
      iov_iter: Add a general purpose iteration function
      cifs: Add some helper functions
      cifs: Add a function to read into an iter from a socket

Enzo Matsumiya (3):
      cifs: don't call cifs_dfs_query_info_nonascii_quirk() if nodfs was set
      cifs: return ENOENT for DFS lookup_cache_entry()
      cifs: print TIDs as hex

Julia Lawall (1):
      cifs: smbd: fix typo in comment

Paulo Alcantara (2):
      cifs: fix signed integer overflow when fl_end is OFFSET_MAX
      cifs: fix ntlmssp on old servers

Ronnie Sahlberg (4):
      cifs: move definition of cifs_fattr earlier in cifsglob.h
      cifs: check for smb1 in open_cached_dir()
      cifs: set the CREATE_NOT_FILE when opening the directory in
use_cached_dir()
      cifs: cache the dirents for entries in a cached directory

Shyam Prasad N (3):
      cifs: do not use tcpStatus after negotiate completes
      cifs: use new enum for ses_status
      cifs: avoid parallel session setups on same channel

Steve French (10):
      SMB3: EBADF/EIO errors in rename/open caused by race condition
in smb2_compound_op
      smb3: add trace point for lease not found issue
      smb3: add trace point for oplock not found
      Add defines for various newer FSCTLs
      Add various fsctl structs
      cifs: fix minor compile warning
      smb3: check for null tcon
      smb3: don't set rc when used and unneeded in query_info_compound
      smb3: add mount parm nosparse
      smb3: remove unneeded null check in cifs_readdir

 fs/cifs/cifs_debug.c       |  11 +++-
 fs/cifs/cifsfs.c           |   2 +
 fs/cifs/cifsfs.h           |   3 +
 fs/cifs/cifsglob.h         | 124 +++++++++++++++++++++++++++------------
 fs/cifs/cifsproto.h        |  12 ++++
 fs/cifs/cifssmb.c          |  99 ++++++++++++++++++++++++++++++-
 fs/cifs/connect.c          | 123 +++++++++++++++++++++++----------------
 fs/cifs/dfs_cache.c        |   6 +-
 fs/cifs/file.c             |  13 +++--
 fs/cifs/fs_context.c       |  33 +++--------
 fs/cifs/fs_context.h       |   4 +-
 fs/cifs/misc.c             |  11 ++--
 fs/cifs/readdir.c          | 179
++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 fs/cifs/sess.c             |  33 ++++++++++-
 fs/cifs/smb2inode.c        |   7 ++-
 fs/cifs/smb2misc.c         |  12 +++-
 fs/cifs/smb2ops.c          |  32 +++++++++--
 fs/cifs/smb2pdu.c          |   5 +-
 fs/cifs/smb2pdu.h          |  22 -------
 fs/cifs/smb2transport.c    |   7 ++-
 fs/cifs/smbdirect.c        |   2 +-
 fs/cifs/trace.h            |   2 +
 fs/cifs/transport.c        |   8 +--
 fs/smbfs_common/smb2pdu.h  | 108 +++++++++++++++++++++++++++++++---
 fs/smbfs_common/smbfsctl.h |   6 ++
 include/linux/uio.h        |   8 +++
 lib/iov_iter.c             | 133 ++++++++++++++++++++++++++++++++++++++++++
 27 files changed, 816 insertions(+), 189 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Fri, 22 Apr 2022 12:00:06 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.18-rc3-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/88c5060d56d8f756653bbee89fa45a752e241c9c

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
b2d229d4ddb17db541098b83524d901257e93845:

  Linux 5.18-rc3 (2022-04-17 13:57:31 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.18-rc3-smb3-fixes

for you to fetch changes up to f5d0f921ea362636e4a2efb7c38d1ead373a8700:

  cifs: destage any unwritten data to the server before calling
copychunk_write (2022-04-20 22:54:54 -0500)

----------------------------------------------------------------
4 fixes to cifs client, 2 for stable
- fcollapse fix
- reconnect lock fix
- DFS oops fix
- minor cleanup patch
----------------------------------------------------------------
Haowen Bai (1):
      cifs: Use kzalloc instead of kmalloc/memset

Paulo Alcantara (2):
      cifs: fix NULL ptr dereference in refresh_mounts()
      cifs: use correct lock type in cifs_reconnect()

Ronnie Sahlberg (1):
      cifs: destage any unwritten data to the server before calling
copychunk_write

 fs/cifs/connect.c   | 11 ++++++++++-
 fs/cifs/dfs_cache.c | 19 ++++++++++++-------
 fs/cifs/smb2ops.c   |  8 ++++++++
 fs/cifs/transport.c |  3 +--
 4 files changed, 31 insertions(+), 10 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 14 Apr 2022 15:42:58 -0500:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.18-rc2-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/62345e482899185a247b126f32a96e4665018f45

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
5a5dcfd1e8789053730908c96639151b4151c4d0:

  Merge tag '5.18-rc1-smb3-fixes' of
git://git.samba.org/sfrench/cifs-2.6 (2022-04-07 19:16:49 -1000)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.18-rc2-smb3-fixes

for you to fetch changes up to 8b6c58458ee3206dde345fce327a4cb83e69caf9:

  cifs: verify that tcon is valid before dereference in cifs_kill_sb
(2022-04-14 00:07:36 -0500)

----------------------------------------------------------------
5 fixes to cifs client, 1 for stable
- two related to unmount
- symlink overflow fix
- minor netfs fix
- improved tracing for crediting (flow control)

----------------------------------------------------------------
David Howells (2):
      cifs: Check the IOCB_DIRECT flag, not O_DIRECT
      cifs: Split the smb3_add_credits tracepoint

Harshit Mogalapalli (1):
      cifs: potential buffer overflow in handling symlinks

Ronnie Sahlberg (1):
      cifs: verify that tcon is valid before dereference in cifs_kill_sb

Shyam Prasad N (1):
      cifs: release cached dentries only if mount is complete

 fs/cifs/cifsfs.c    | 30 ++++++++++++++++--------------
 fs/cifs/connect.c   |  2 +-
 fs/cifs/link.c      |  3 +++
 fs/cifs/smb2ops.c   |  9 ++++++---
 fs/cifs/trace.h     |  7 +++++++
 fs/cifs/transport.c |  4 ++--
 6 files changed, 35 insertions(+), 20 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Thu, 17 Feb 2022 18:26:04 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.17-rc5-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7476b043b1914413f75b7e99040969734ae1fab6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
754e0b0e35608ed5206d6a67a791563c631cec07:

  Linux 5.17-rc4 (2022-02-13 12:13:30 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.17-rc5-smb3-fixes

for you to fetch changes up to 53923e0fe2098f90f339510aeaa0e1413ae99a16:

  cifs: fix confusing unneeded warning message on smb2.1 and earlier
(2022-02-16 17:16:49 -0600)

----------------------------------------------------------------
6 small smb3 client fixes, 3 for stable:
-fix for snapshot mount option
- 2 ACL related fixes
- use after free race fix
- fix for confusing warning message logged with older dialects

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/904
----------------------------------------------------------------
Amir Goldstein (1):
      cifs: fix set of group SID via NTSD xattrs

Ronnie Sahlberg (3):
      cifs: do not use uninitialized data in the owner/group sid
      cifs: fix double free race when mount fails in cifs_get_root()
      cifs: modefromsids must add an ACE for authenticated users

Steve French (2):
      smb3: fix snapshot mount option
      cifs: fix confusing unneeded warning message on smb2.1 and earlier

 fs/cifs/cifsacl.c    |  9 ++++++---
 fs/cifs/cifsfs.c     |  1 +
 fs/cifs/fs_context.c |  4 ++--
 fs/cifs/sess.c       | 11 ++++++-----
 fs/cifs/xattr.c      |  2 ++
 5 files changed, 17 insertions(+), 10 deletions(-)

--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 12 Feb 2022 14:20:30 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.17-rc4-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e9c25787db080cb28601ce182088ce77659f684b

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
dfd42facf1e4ada021b939b4e19c935dcdd55566:

  Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.17-rc4-smb3-fixes

for you to fetch changes up to 2a05137a0575b7d1006bdf4c1beeee9e391e22a0:

  cifs: mark sessions for reconnection in helper function (2022-02-08
22:13:52 -0600)

----------------------------------------------------------------
3 small smb3 reconnect fixes and an error log clarification

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/897

This pull request does not include the recent snapshot fix and 2
ACL/SID fixes that are still being tested (I can send those next
week).
----------------------------------------------------------------
Shyam Prasad N (3):
      cifs: call cifs_reconnect when a connection is marked
      cifs: call helper functions for marking channels for reconnect
      cifs: mark sessions for reconnection in helper function

Steve French (1):
      [smb3] improve error message when mount options conflict with posix

 fs/cifs/cifs_swn.c  |  6 +++---
 fs/cifs/connect.c   | 31 +++++++++++++++++++++++++------
 fs/cifs/dfs_cache.c |  2 +-
 fs/cifs/smb1ops.c   |  4 +---
 fs/cifs/transport.c |  5 +----
 5 files changed, 31 insertions(+), 17 deletions(-)


-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 18 Dec 2021 19:36:43 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc5-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/9273d6cb9935f536c309186744e5163c9e488a57

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
2585cf9dfaaddf00b069673f27bb3f8530e2039c:

  Linux 5.16-rc5 (2021-12-12 14:53:01 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc5-smb3-client-fixes

for you to fetch changes up to a31080899d5fdafcccf7f39dd214a814a2c82626:

  cifs: sanitize multiple delimiters in prepath (2021-12-17 19:16:49 -0600)

----------------------------------------------------------------
Two cifs/smb3 fixes, one fscache related, and one mount path parsing
related (for stable)

(Does not include the recent kernel DNS caching fix, which is still
being tested and reviewed)

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/856
----------------------------------------------------------------
Shyam Prasad N (1):
      cifs: ignore resource_id while getting fscache super cookie

Thiago Rafael Becker (1):
      cifs: sanitize multiple delimiters in prepath

 fs/cifs/connect.c    |  7 +++++++
 fs/cifs/fs_context.c | 38 +++++++++++++++++++++++++++++++++++++-
 fs/cifs/inode.c      | 13 -------------
 3 files changed, 44 insertions(+), 14 deletions(-)


--
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 4 Dec 2021 14:41:36 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc3-smb3-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/23b55d673d7527b093cd97b7c217c82e70cd1af0

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
d58071a8a76d779eedab38033ae4c821c30295a5:

  Linux 5.16-rc3 (2021-11-28 14:09:19 -0800)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc3-smb3-fixes

for you to fetch changes up to bbb9db5e2a7a1ca0926d26a279000384be21b789:

  cifs: avoid use of dstaddr as key for fscache client cookie
(2021-12-03 12:38:25 -0600)

----------------------------------------------------------------
3 SMB3 multichannel/fscache fixes and a DFS fix. In testing
multichannel reconnect scenarios recently various problems with the
cifs.ko implementation of fscache were found (e.g. incorrect
initialization of fscache cookies in some cases).

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/846
----------------------------------------------------------------
Paulo Alcantara (1):
      cifs: fix missed refcounting of ipc tcon

Shyam Prasad N (3):
      cifs: wait for tcon resource_id before getting fscache super
      cifs: add server conn_id to fscache client cookie
      cifs: avoid use of dstaddr as key for fscache client cookie

 fs/cifs/connect.c | 11 +++++------
 fs/cifs/fscache.c | 46 ++++++++++------------------------------------
 fs/cifs/inode.c   |  7 +++++++
 3 files changed, 22 insertions(+), 42 deletions(-)

-- 
Thanks,

Steve

Re: [GIT PULL] smb3 client fixes

[pr-tracker-bot]

The pull request you sent on Sat, 13 Nov 2021 14:17:53 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc-part2-smb3-client-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c8103c2718eb99aab954187ca5be14f3d994c9be

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL] smb3 client fixes

[Steve French]

Please pull the following changes since commit
b5013d084e03e82ceeab4db8ae8ceeaebe76b0eb:

  Merge tag '5.16-rc-part1-smb3-client-fixes' of
git://git.samba.org/sfrench/cifs-2.6 (2021-11-06 16:47:53 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.16-rc-part2-smb3-client-fixes

for you to fetch changes up to 46bb1b9484aeaf701da50c9ee063f3e93ce2a37b:

  cifs: do not duplicate fscache cookie for secondary channels
(2021-11-12 23:29:08 -0600)

----------------------------------------------------------------
23 cifs/smb3 fixes, including:
- improvements to reconnect and multichannel
- a performance improvement (additional use of SMB3 compounding)
- DFS code cleanup and improvements
- various trivial Coverity fixes
- two fscache fixes
- an fsync fix

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/836
----------------------------------------------------------------
Paulo Alcantara (8):
      cifs: fix print of hdr_flags in dfscache_proc_show()
      cifs: introduce new helper for cifs_reconnect()
      cifs: convert list_for_each to entry variant
      cifs: split out dfs code from cifs_reconnect()
      cifs: set a minimum of 120s for next dns resolution
      cifs: support nested dfs links over reconnect
      cifs: fix memory leak of smb3_fs_context_dup::server_hostname
      cifs: fix potential use-after-free bugs

Shyam Prasad N (7):
      cifs: nosharesock should not share socket with future sessions
      cifs: send workstation name during ntlmssp session setup
      cifs: for compound requests, use open handle if possible
      cifs: do not negotiate session if session already exists
      cifs: protect session channel fields with chan_lock
      cifs: connect individual channel servers to primary channel server
      cifs: do not duplicate fscache cookie for secondary channels

Steve French (8):
      smb3: do not error on fsync when readonly
      smb3: remove trivial dfs compile warning
      smb3: add additional null check in SMB2_ioctl
      smb3: add additional null check in SMB2_open
      smb3: add additional null check in SMB2_tcon
      cifs: release lock earlier in dequeue_mid error case
      smb3: add additional null check in SMB311_posix_mkdir
      smb3: do not setup the fscache_super_cookie until fsinfo initialized

 fs/cifs/cifs_debug.c   |    7 +-
 fs/cifs/cifs_dfs_ref.c |   59 +--
 fs/cifs/cifs_fs_sb.h   |    5 -
 fs/cifs/cifsglob.h     |   47 +-
 fs/cifs/cifsproto.h    |   10 +-
 fs/cifs/connect.c      | 1468
+++++++++++++++++++++++++++++++++-----------------------------
 fs/cifs/dfs_cache.c    |   46 +-
 fs/cifs/file.c         |   35 +-
 fs/cifs/fs_context.c   |   36 +-
 fs/cifs/fs_context.h   |    1 +
 fs/cifs/fscache.c      |    8 +
 fs/cifs/misc.c         |   64 +--
 fs/cifs/ntlmssp.h      |    4 +-
 fs/cifs/sess.c         |  240 ++++++----
 fs/cifs/smb2inode.c    |   22 +-
 fs/cifs/smb2ops.c      |   10 +-
 fs/cifs/smb2pdu.c      |   52 ++-
 fs/cifs/transport.c    |    3 +
 18 files changed, 1184 insertions(+), 933 deletions(-)

--
Thanks,

Steve